Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Ferrazzutti2014-05-29 13:49:16 +0000
committerJeff Johnston2014-06-06 19:32:20 +0000
commit86a9c08a95a9aa2d0ec2be86a3e4d9455692a3f9 (patch)
treecbe143b77ed0bfaa0dd9b6d92026eca9fc7fc138
parent4bec4ab8cddd7ca584c9c88a54c60981cf2c2dfe (diff)
downloadorg.eclipse.linuxtools-86a9c08a95a9aa2d0ec2be86a3e4d9455692a3f9.tar.gz
org.eclipse.linuxtools-86a9c08a95a9aa2d0ec2be86a3e4d9455692a3f9.tar.xz
org.eclipse.linuxtools-86a9c08a95a9aa2d0ec2be86a3e4d9455692a3f9.zip
Systemtap: Stop BrowserView crashes on re-open.
Prevent BrowserViews from disposing their content trees when they are closed. This disposal caused TapsetLibrary trees to be disposed, which are not rebuilt the the next time the views are opened. This resulted in the NPEs that prevented the views from being re-opened after being closed. Resolves EBZ #435979. Change-Id: I4428340898c5943970e105d4de8ad33e5ba8e0fa Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com> Reviewed-on: https://git.eclipse.org/r/27534 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Tested-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/28151
-rw-r--r--systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java4
1 files changed, 0 insertions, 4 deletions
diff --git a/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java b/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
index 3890fc7248..acedd5bfe2 100644
--- a/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
+++ b/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
@@ -154,10 +154,6 @@ public abstract class BrowserView extends ViewPart {
collapseHandler.dispose();
collapseHandler = null;
}
- if (tree != null) {
- tree.dispose();
- tree = null;
- }
if (viewer != null) {
if (doubleClickAction != null) {
viewer.removeDoubleClickListener(doubleClickAction);

Back to the top