Increased warning level and fixed worst issues.

24 files changed, 142 insertions, 76 deletions

diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.core.prefs b/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.core.prefs
new file mode 100644
index 000000000..3c6f371c7
--- /dev/null
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.core.prefs
@@ -0,0 +1,77 @@
+#Fri Apr 06 21:12:03 PDT 2007
+eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=disabled
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.4
+org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
+org.eclipse.jdt.core.compiler.compliance=1.4
+org.eclipse.jdt.core.compiler.debug.lineNumber=generate
+org.eclipse.jdt.core.compiler.debug.localVariable=generate
+org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.doc.comment.support=enabled
+org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
+org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.autoboxing=warning
+org.eclipse.jdt.core.compiler.problem.deprecation=warning
+org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
+org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
+org.eclipse.jdt.core.compiler.problem.discouragedReference=ignore
+org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore
+org.eclipse.jdt.core.compiler.problem.enumIdentifier=warning
+org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
+org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
+org.eclipse.jdt.core.compiler.problem.fieldHiding=warning
+org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
+org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning
+org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
+org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning
+org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
+org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
+org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=protected
+org.eclipse.jdt.core.compiler.problem.localVariableHiding=warning
+org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
+org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingJavadocComments=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=protected
+org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=protected
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
+org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
+org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
+org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
+org.eclipse.jdt.core.compiler.problem.nullReference=ignore
+org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
+org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
+org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
+org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
+org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
+org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
+org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
+org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
+org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
+org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
+org.eclipse.jdt.core.compiler.problem.typeParameterHiding=ignore
+org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
+org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=error
+org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
+org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
+org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning
+org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.unusedImport=error
+org.eclipse.jdt.core.compiler.problem.unusedLabel=warning
+org.eclipse.jdt.core.compiler.problem.unusedLocal=error
+org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
+org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=error
+org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
+org.eclipse.jdt.core.compiler.source=1.4
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.ui.prefs b/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.ui.prefs
new file mode 100644
index 000000000..82eb6c152
--- /dev/null
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/.settings/org.eclipse.jdt.ui.prefs
@@ -0,0 +1,3 @@
+#Fri Apr 06 18:25:15 PDT 2007
+eclipse.preferences.version=1
+org.eclipse.jdt.ui.text.custom_code_templates=<?xml version\="1.0" encoding\="UTF-8"?><templates/>
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/JSFUICommonPlugin.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/JSFUICommonPlugin.java
index 004c6e5a5..8a82e5f25 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/JSFUICommonPlugin.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/JSFUICommonPlugin.java
@@ -160,7 +160,7 @@ public class JSFUICommonPlugin extends AbstractUIPlugin implements ICommonConsta
 	/**
 	 * get the alerts objects associated with this plugin for alerting the user.
 	 * 
-	 * @return
+	 * @return the alerts object
 	 */
 	public static Alerts getAlerts() {
 		return _alerts;
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/actions/OpenPageAction.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/actions/OpenPageAction.java
index 5b1e1a0fe..252e44caf 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/actions/OpenPageAction.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/actions/OpenPageAction.java
@@ -78,8 +78,7 @@ public class OpenPageAction extends Action implements IExecutableExtension {
 
 	/**
 	 * set the class name to open.
-	 * 
-	 * @param pageID
+	 * @param className 
 	 */
 	public void setPageName(String className) {
 		this.pageID = className;
@@ -88,7 +87,7 @@ public class OpenPageAction extends Action implements IExecutableExtension {
 	/**
 	 * get the current active editor
 	 * 
-	 * @return
+	 * @return the active editor part
 	 */
 	public static IEditorPart getActiveEditor() {
 		IEditorPart editor = null;
@@ -103,10 +102,16 @@ public class OpenPageAction extends Action implements IExecutableExtension {
 		return editor;
 	}
 
+	/**
+	 * @return stored selection
+	 */
 	public ISelection getSelection() {
 		return selection;
 	}
 
+	/**
+	 * @param selection
+	 */
 	public void setSelection(ISelection selection) {
 		this.selection = selection;
 	}
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogField.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogField.java
index d9f342d66..fe4029191 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogField.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogField.java
@@ -74,7 +74,7 @@ public interface DialogField {
 	 * Get attached data by key.
 	 * 
 	 * @param key
-	 * @return
+	 * @return the attached data object for key
 	 */
 	public abstract Object getAttachedData(Object key);
 
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldBase.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldBase.java
index 7ffc0279b..bfc56d41c 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldBase.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldBase.java
@@ -481,7 +481,7 @@ public class DialogFieldBase implements DialogField {
 	 * Get attached data by key.
 	 * 
 	 * @param key
-	 * @return
+	 * @return the attached data object for key
 	 */
 	public Object getAttachedData(Object key) {
 		if (_attachedData != null) {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldGroup.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldGroup.java
index ffbd83d4d..2e4c5bcbb 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldGroup.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldGroup.java
@@ -29,14 +29,10 @@ public abstract class DialogFieldGroup {
 
 	private IDialogFieldApplyListener _defaultApplyListener;
 
-	public DialogFieldGroup() {
-		// initialize();
-	}
-
 	/**
 	 * set default handler, should be called before <code>initialize()</code>
+	 * @param changelistener 
 	 * 
-	 * @param applylistener
 	 */
 	public void setDefaultChangeListener(
 			IDialogFieldChangeListener changelistener) {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldWrapper.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldWrapper.java
index e934a5605..a0bf3014a 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldWrapper.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/DialogFieldWrapper.java
@@ -33,7 +33,7 @@ import org.eclipse.ui.forms.widgets.FormToolkit;
  * 
  * @author mengbo
  * @version 1.5
- * @see org.eclipse.jst.pagedesigner.properties.celleditors.CellEditorWrapper
+ * see CellEditorWrapper TODO: what relation to page designer?
  */
 
 public class DialogFieldWrapper implements DialogField, ISupportTextValue {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/PackageButtonDialogField.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/PackageButtonDialogField.java
index df6c03eab..5b3bcb483 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/PackageButtonDialogField.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/PackageButtonDialogField.java
@@ -45,7 +45,7 @@ public class PackageButtonDialogField extends StringButtonDialogField {
 	private IPackageFragment _fCurrPackage;
 
 	/**
-	 * @param adapter
+	 * @param packageRoot 
 	 */
 	public PackageButtonDialogField(IPackageFragmentRoot packageRoot) {
 		super(null);
@@ -82,10 +82,6 @@ public class PackageButtonDialogField extends StringButtonDialogField {
 	 * 
 	 * @param root
 	 *            The new root.
-	 * @param canBeModified
-	 *            if <code>false</code> the source folder field can not be
-	 *            changed by the user. If <code>true</code> the field is
-	 *            editable
 	 */
 	public void setPackageFragmentRoot(IPackageFragmentRoot root) {
 		_fCurrRoot = root;
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/RadiosDialogField.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/RadiosDialogField.java
index c927f35d9..cfe52bca0 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/RadiosDialogField.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/RadiosDialogField.java
@@ -45,7 +45,7 @@ public class RadiosDialogField extends DialogFieldBase {
 	private boolean _fireEvent = true;
 
 	/**
-	 * @param formToolkit
+	 * Default constructor
 	 */
 	public RadiosDialogField() {
 		super();
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/SourceFolderButtonDialogField.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/SourceFolderButtonDialogField.java
index 1b68830d9..03f9b12a7 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/SourceFolderButtonDialogField.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogfield/SourceFolderButtonDialogField.java
@@ -58,7 +58,7 @@ public class SourceFolderButtonDialogField extends StringButtonDialogField {
 	private IProject _project;
 
 	/**
-	 * @param adapter
+	 * @param project 
 	 */
 	public SourceFolderButtonDialogField(IProject project) {
 		super(null);
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/CommonResourceDialog.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/CommonResourceDialog.java
index fb4313947..48f5cb99a 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/CommonResourceDialog.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/CommonResourceDialog.java
@@ -100,7 +100,7 @@ public class CommonResourceDialog extends TreeViewerSelectionDialog {
 		}
 
 		/**
-		 * @see ITreeContentProvider#getElements
+		 * @see org.eclipse.jface.viewers.IStructuredContentProvider#getElements(Object)
 		 */
 		public Object[] getElements(Object element) {
 			return getChildren(element);
@@ -124,7 +124,7 @@ public class CommonResourceDialog extends TreeViewerSelectionDialog {
 		}
 
 		/**
-		 * @see IContentProvider#inputChanged
+		 * @see org.eclipse.jface.viewers.IContentProvider#inputChanged(Viewer, Object, Object)
 		 */
 		public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
             // no viewer change support required
@@ -235,7 +235,8 @@ public class CommonResourceDialog extends TreeViewerSelectionDialog {
 	 * include IFolder, IProject, IFile, user can provide
 	 * 
 	 * @param parentShell
-	 * @param project
+	 * @param folder 
+	 * @param style 
 	 */
 	public CommonResourceDialog(Shell parentShell, IFolder folder, int style) {
 		this(parentShell, (folder == null ? null : folder.getProject()), style);
@@ -318,8 +319,8 @@ public class CommonResourceDialog extends TreeViewerSelectionDialog {
 	}
 
 	/**
-	 * @param _suffixs
-	 *            The _suffixs to set.
+	 * @param suffixs
+	 *            The suffixs to set.
 	 */
 	public void setSuffixs(String[] suffixs) {
 		this._suffixs = convertTolowercase(suffixs);
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/TreeViewerSelectionDialog.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/TreeViewerSelectionDialog.java
index 9416c0dad..492353375 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/TreeViewerSelectionDialog.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/dialogs/TreeViewerSelectionDialog.java
@@ -121,9 +121,7 @@ public abstract class TreeViewerSelectionDialog extends SelectionDialog {
 
 	/**
 	 * Returns a new drill down viewer for this dialog.
-	 * 
-	 * @param heightHint -
-	 *            height hint for the drill down composite
+	 * @param parent 
 	 */
 	protected void createTreeViewer(Composite parent) {
 		// Create drill down
@@ -195,9 +193,7 @@ public abstract class TreeViewerSelectionDialog extends SelectionDialog {
 
 	/**
 	 * Sets the selected existing container.
-	 * 
-	 * @param container -
-	 *            the current selected container.
+	 * @param selection 
 	 */
 	public void setSelectedElement(Object[] selection) {
 		// Expand to and select the specified container
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/Alerts.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/Alerts.java
index 5b0db05b9..c416e71e7 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/Alerts.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/Alerts.java
@@ -53,8 +53,7 @@ public class Alerts {
 	 * be used from the root plugin that has access to the resource bundle for
 	 * this plugin.
 	 * 
-	 * @param AbstractUIPlugin
-	 *            the name plugin.
+	 * @param plugin 
 	 * @param rb
 	 *            the resource bundle to use.
 	 */
@@ -351,7 +350,7 @@ public class Alerts {
 	 *            user
 	 * @param arg0 -
 	 *            arg to place into the resource bundle message.
-	 * @param arg0 -
+	 * @param arg1 -
 	 *            arg to place into the resource bundle message.
 	 * @param tt -
 	 *            exception to place in the details.
@@ -429,7 +428,7 @@ public class Alerts {
 	 * @param pluginId
 	 * @param message
 	 * @param tt
-	 * @return
+	 * @return the result of the operation
 	 */
 	public IStatus buildStackTraceStatus(int code, String pluginId,
 			String message, Throwable tt) {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/CollapsableSection.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/CollapsableSection.java
index 198afc388..83777fcb0 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/CollapsableSection.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/CollapsableSection.java
@@ -52,13 +52,13 @@ public abstract class CollapsableSection {
 	/**
 	 * Creates a class to be used to build the control for a collapseable area.
 	 * 
+	 * @param toolkit 
+	 * 
 	 * @param scomp
 	 *            the scrollable composite used inside the container. This is
 	 *            used to force resizing of the bars on dinking the control.
 	 * @param title
 	 *            the string to place next to the collapsable icon.
-	 * @param innerComposite
-	 *            this should be the composite to place this widget on.
 	 * @param bCollapsed
 	 *            should this area start collapsed?
 	 */
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/ImageContainer.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/ImageContainer.java
index c917bf47c..b2a6a3e4b 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/ImageContainer.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/ImageContainer.java
@@ -38,7 +38,6 @@ public class ImageContainer extends Composite {
 
 	/**
 	 * @param parent
-	 * @param style
 	 */
 	public ImageContainer(Composite parent) {
 		super(parent, SWT.NONE);// SWT.NO_BACKGROUND );//|
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/IntroductionSection.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/IntroductionSection.java
index 78e18d599..9c1f4a7c3 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/IntroductionSection.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/IntroductionSection.java
@@ -90,7 +90,7 @@ public class IntroductionSection extends SectionPart {
 	 *            id of the editor this page is for.
 	 * @param managedForm
 	 * @param toolkit
-	 * @param helpContextId
+	 * @param contextId 
 	 * @param helpTooltip
 	 */
 	public IntroductionSection(String editorId, IManagedForm managedForm,
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/OverviewSection.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/OverviewSection.java
index 97702fd71..7fd9e54f0 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/OverviewSection.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/OverviewSection.java
@@ -60,9 +60,9 @@ public class OverviewSection extends SectionPart {
 	protected FormEditor editor;
 
 	/**
-	 * @param parent
+	 * @param editorId 
+	 * @param managedForm 
 	 * @param toolkit
-	 * @param style
 	 */
 	public OverviewSection(String editorId, IManagedForm managedForm,
 			FormToolkit toolkit) {
@@ -101,7 +101,8 @@ public class OverviewSection extends SectionPart {
 	}
 
 	/**
-	 * @param parent
+	 * @param editor 
+	 * @param managedForm 
 	 * @param toolkit
 	 * @param style
 	 */
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/SWTUtils.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/SWTUtils.java
index ee0598a66..b955c9775 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/SWTUtils.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/guiutils/SWTUtils.java
@@ -55,10 +55,6 @@ public class SWTUtils {
 	 * 
 	 * @param parent
 	 *            the composite in which to create the checkbox
-	 * @param label
-	 *            the string to set into the checkbox
-	 * @param numColumns
-	 *            the number of columns the new checkbox is to occupy
 	 * @return the new checkbox
 	 */
 	public static Button createCheckBox(Composite parent) {
@@ -185,8 +181,7 @@ public class SWTUtils {
 	 * 
 	 * @param parent
 	 *            the composite in which to create the combo
-	 * @param items
-	 *            the items in the combo
+	 * @param tokenString 
 	 * @param numColumns
 	 *            the number of columns the new combo is to occupy
 	 * @param minWidth
@@ -366,7 +361,7 @@ public class SWTUtils {
 	 * @param horizontalSpan
 	 *            the number of columns this group should span on the parent
 	 *            composite.
-	 * @param fill
+	 * @param gridDataFill
 	 *            the fill style of the new group -- set to for filling just
 	 *            around the object: GridData.BEGINNING | GridData.CENTER
 	 * @return the newly created group
@@ -506,7 +501,7 @@ public class SWTUtils {
 	 * 
 	 * @param parent
 	 *            the parent for the new button
-	 * @param label
+	 * @param theImage
 	 *            the label for the new button
 	 * @param widthHint
 	 *            use this width for the button.
@@ -594,7 +589,7 @@ public class SWTUtils {
 	 *            the parent for the new label
 	 * @param numColumns
 	 *            the number of columns for the new composite
-	 * @param int
+	 * @param minWidth
 	 *            minimum width of spacer
 	 */
 	public static void createSpacer(Composite parent, int numColumns,
@@ -957,8 +952,6 @@ public class SWTUtils {
 	 *            the items in the list
 	 * @param bmulti
 	 *            whether multiple item selection is allowed
-	 * @param verticalSpan
-	 *            the number of rows the list box is to occupy
 	 * @return the new list
 	 */
 	public static List createList(Composite parent, int numColumns,
@@ -1081,6 +1074,7 @@ public class SWTUtils {
 		}
 
 		public void controlMoved(ControlEvent e) {
+		    // nothing for move
 		}
 	};
 
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/FavoriteConfigurations.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/FavoriteConfigurations.java
index 1625c1666..d084f5aae 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/FavoriteConfigurations.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/FavoriteConfigurations.java
@@ -210,7 +210,7 @@ public class FavoriteConfigurations {
 	/**
 	 * Get a list of all the favorites stored in this file.
 	 * 
-	 * @return
+	 * @return list of favorites
 	 */
 	public String[] getFavoritesList() {
 		Object[] objs = _favorites.keySet().toArray();
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/ResourceUtils.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/ResourceUtils.java
index 513609de3..07bdff727 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/ResourceUtils.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/ResourceUtils.java
@@ -70,7 +70,7 @@ public abstract class ResourceUtils {
 	 * 
 	 * @param key
 	 *            the key in the resource bundle.
-	 * @param theDefault
+	 * @param defaultValue
 	 *            default int to return if no value is found for the key.
 	 */
 	public int getValue(String key, int defaultValue) {
@@ -94,7 +94,7 @@ public abstract class ResourceUtils {
 	 * 
 	 * @param key
 	 *            the key in the resource bundle.
-	 * @param theDefault
+	 * @param defaultValue
 	 *            default long to return if no value is found for the key.
 	 */
 	public long getValue(String key, long defaultValue) {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StringUtil.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StringUtil.java
index b7403aacd..a55677216 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StringUtil.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StringUtil.java
@@ -144,8 +144,9 @@ public class StringUtil {
 	/**
 	 * Determine whether a string is empty or not Example: null string -> return
 	 * true; Example: "" string -> return true; Otherwise, will return false;
+	 * @param str 
 	 * 
-	 * @return
+	 * @return true if str is null or empty
 	 */
 	public static boolean isEmptyString(String str) {
 		if (str == null || str.length() == 0) {
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StyleCombo.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StyleCombo.java
index 5314b2ed3..bbcf2ce3c 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StyleCombo.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/StyleCombo.java
@@ -103,7 +103,7 @@ public final class StyleCombo extends Composite {
 	 *                <ul>
 	 *                <li>ERROR_NULL_ARGUMENT - if the parent is null</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_THREAD_INVALID_ACCESS - if not called from the
 	 *                thread that created the parent</li>
@@ -112,7 +112,6 @@ public final class StyleCombo extends Composite {
 	 * @see SWT#BORDER
 	 * @see SWT#READ_ONLY
 	 * @see SWT#FLAT
-	 * @see Widget#getStyle()
 	 */
 	public StyleCombo(Composite parent, int style) {
 		super(parent, style = checkStyle(style));
@@ -215,7 +214,7 @@ public final class StyleCombo extends Composite {
 	 *                <ul>
 	 *                <li>ERROR_NULL_ARGUMENT - if the string is null</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -254,7 +253,7 @@ public final class StyleCombo extends Composite {
 	 *                <li>ERROR_INVALID_RANGE - if the index is not between 0
 	 *                and the number of elements in the list (inclusive)</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -285,7 +284,7 @@ public final class StyleCombo extends Composite {
 	 *                <ul>
 	 *                <li>ERROR_NULL_ARGUMENT - if the listener is null</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -322,7 +321,7 @@ public final class StyleCombo extends Composite {
 	 *                <ul>
 	 *                <li>ERROR_NULL_ARGUMENT - if the listener is null</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -332,7 +331,6 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @see SelectionListener
 	 * @see #removeSelectionListener
-	 * @see SelectionEvent
 	 */
 	public void addSelectionListener(SelectionListener listener1) {
 		checkWidget();
@@ -366,7 +364,7 @@ public final class StyleCombo extends Composite {
 	 * <code>deselectAll()</code>.
 	 * </p>
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -479,7 +477,7 @@ public final class StyleCombo extends Composite {
 	 * @param index
 	 *            the index of the item to deselect
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -499,7 +497,7 @@ public final class StyleCombo extends Composite {
 	 * <code>clearSelection()</code>.
 	 * </p>
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -600,7 +598,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return whether or not the reciever is editable
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -628,7 +626,7 @@ public final class StyleCombo extends Composite {
 	 *                <li>ERROR_INVALID_RANGE - if the index is not between 0
 	 *                and the number of elements in the list minus 1 (inclusive)</li>
 	 *                </ul>
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -646,7 +644,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return the number of items
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -665,7 +663,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return the height of one item
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -688,7 +686,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return the items in the receiver's list
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -728,7 +726,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return a point representing the selection start and end
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
@@ -747,7 +745,7 @@ public final class StyleCombo extends Composite {
 	 * 
 	 * @return the index of the selected item
 	 * 
-	 * @exception org.eclipse.swt.org.eclipse.swt.SWTException
+	 * @exception org.eclipse.swt.SWTException
 	 *                <ul>
 	 *                <li>ERROR_WIDGET_DISPOSED - if the receiver has been
 	 *                disposed</li>
diff --git a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/WebrootUtil.java b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/WebrootUtil.java
index 0fe5e182a..51d2916c4 100644
--- a/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/WebrootUtil.java
+++ b/jsf/plugins/org.eclipse.jst.jsf.common.ui/src/org/eclipse/jst/jsf/common/ui/internal/utils/WebrootUtil.java
@@ -42,7 +42,7 @@ public class WebrootUtil {
 	 * "/filename.jsp" or "/folder/*";
 	 * 
 	 * @param path
-	 * @return
+	 * @return the web path
 	 */
 	public static String getWebPath(IPath path) {
 		String strWebrootPath = "";
@@ -63,7 +63,7 @@ public class WebrootUtil {
 	 * To see if a resource is under the webcontent folder.
 	 * 
 	 * @param resource
-	 * @return
+	 * @return true if resource is within the web content folder hierarchy
 	 */
 	public static boolean isUnderWebContentFolder(IResource resource) {
 		IPath webContentPath = getWebContentPath(resource.getProject());
@@ -96,7 +96,7 @@ public class WebrootUtil {
 	 * Return the name of the web content folder. i.e, "WebContent"
 	 * 
 	 * @param project
-	 * @return
+	 * @return the web content folder name
 	 */
 	public static String getWebContentFolderName(IProject project) {
 		IPath webContentPath = getWebContentPath(project);