From 2c5ed560c925fba9700d97390a9ffe44426f758f Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Tue, 26 Nov 2019 12:16:47 +0900 Subject: Bazel: Add missing newlines at end of BUILD files Change-Id: I11afc45141da988e28382898246995f6b45eb09c Signed-off-by: David Pursehouse --- lib/jmh/BUILD | 2 +- org.eclipse.jgit.benchmarks/BUILD | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/jmh/BUILD b/lib/jmh/BUILD index deb2a78def..b15e66c2b9 100644 --- a/lib/jmh/BUILD +++ b/lib/jmh/BUILD @@ -9,4 +9,4 @@ java_library( "@jopt//jar", "@math3//jar", ], -) \ No newline at end of file +) diff --git a/org.eclipse.jgit.benchmarks/BUILD b/org.eclipse.jgit.benchmarks/BUILD index 3c6ff0e12b..7e331b101a 100644 --- a/org.eclipse.jgit.benchmarks/BUILD +++ b/org.eclipse.jgit.benchmarks/BUILD @@ -10,4 +10,4 @@ jmh_java_benchmarks( deps = [ "//org.eclipse.jgit:jgit", ], -) \ No newline at end of file +) -- cgit v1.2.3 From 7554bdfad5be0eff0b95dcfcec11a2cb19883b18 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Tue, 26 Nov 2019 12:17:52 +0900 Subject: Bazel: Use java_plugin and java_binary from @rules_java in jmh.bzl Change-Id: I80456f74bc17a1ebb0248fce8050a4cb07bf18f1 Signed-off-by: David Pursehouse --- tools/bzl/jmh.bzl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/bzl/jmh.bzl b/tools/bzl/jmh.bzl index eee9ed02c6..a51a42cf33 100644 --- a/tools/bzl/jmh.bzl +++ b/tools/bzl/jmh.bzl @@ -41,6 +41,8 @@ # Definitions to run jmh microbenchmarks +load("@rules_java//java:defs.bzl", "java_binary", "java_plugin") + def jmh_java_benchmarks(name, srcs, deps = [], tags = [], plugins = [], **kwargs): """Builds runnable JMH benchmarks. This rule builds a runnable target for one or more JMH benchmarks @@ -48,14 +50,14 @@ def jmh_java_benchmarks(name, srcs, deps = [], tags = [], plugins = [], **kwargs except for main_class. """ plugin_name = "_{}_jmh_annotation_processor".format(name) - native.java_plugin( + java_plugin( name = plugin_name, deps = ["//lib/jmh:jmh"], processor_class = "org.openjdk.jmh.generators.BenchmarkProcessor", visibility = ["//visibility:private"], tags = tags, ) - native.java_binary( + java_binary( name = name, srcs = srcs, main_class = "org.openjdk.jmh.Main", @@ -63,4 +65,4 @@ def jmh_java_benchmarks(name, srcs, deps = [], tags = [], plugins = [], **kwargs plugins = plugins + [plugin_name], tags = tags, **kwargs - ) \ No newline at end of file + ) -- cgit v1.2.3