summaryrefslogtreecommitdiffstatsabout
diff options
context:
space:
mode:
authorMathias Kinzler2010-07-28 05:46:05 (EDT)
committer Mathias Kinzler2010-07-28 05:46:05 (EDT)
commit51c6f513b02bd178cc27c8afbde4f49611e81a8e (patch)
treeb8baf1dd275455497788c03f59945712d68e8b40
parent396fe6da4593645e1b9bada4fe314f6169ab2d17 (diff)
downloadjgit-51c6f513b02bd178cc27c8afbde4f49611e81a8e.zip
jgit-51c6f513b02bd178cc27c8afbde4f49611e81a8e.tar.gz
jgit-51c6f513b02bd178cc27c8afbde4f49611e81a8e.tar.bz2
Stack Overflow in EGit History View refs/changes/83/1183/1
This is caused by a recursion in PlotWalk.getTags(). As a hotfix, the sort was simply removed. The sort must be re-implemented so that parseAny() is not called again (currently, this happens in the PlotRefComparator). Change-Id: I060d26fda8a75ac803acaf89cfb7d3b4317328f3 Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com> Signed-off-by: Christian Halstrick <christian.halstrick@sap.com>
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java
index 476592f..666cb02 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java
@@ -45,7 +45,6 @@
package org.eclipse.jgit.revplot;
import java.io.IOException;
-import java.util.Arrays;
import java.util.Collection;
import java.util.Comparator;
import java.util.Map;
@@ -108,7 +107,9 @@ public class PlotWalk extends RevWalk {
tags = null;
else {
tags = list.toArray(new Ref[list.size()]);
- Arrays.sort(tags, new PlotRefComparator());
+ // TODO hotfix, this results in a loop and consequently stack overflow
+ // when opening the history view in EGit
+ // Arrays.sort(tags, new PlotRefComparator());
}
return tags;
}