diff options
| author | Matthias Sohn | 2019-08-20 22:29:45 +0000 |
|---|---|---|
| committer | Matthias Sohn | 2019-08-20 22:29:45 +0000 |
| commit | c130e5e708a34619a90474afd8f259931fc8e7c2 (patch) | |
| tree | 7bb25eb04f08dbb0daf7d99391a7b10ced4cbee1 | |
| parent | 6cb21049d7a48dbc4384fe98a3d3093eb457e381 (diff) | |
| download | jgit-c130e5e708a34619a90474afd8f259931fc8e7c2.tar.gz jgit-c130e5e708a34619a90474afd8f259931fc8e7c2.tar.xz jgit-c130e5e708a34619a90474afd8f259931fc8e7c2.zip | |
Avoid sign extension when comparing mtime with Instant#getEpochSecond
Ensure we use the same type when comparing seconds since the epoch.
This does not prevent that in 2038 timestamps in seconds since the epoch
stored in a 32 bit integer will overflow. Integer.MAX_VALUE translates
to 2038-01-19T03:14:07Z. After this date we'll have an issue since we
store seconds since the epoch in a 32 bit integer in some places.
Bug: 319142
Change-Id: If0c03003d40b480f044686e2f7a2f62c9f4e2fe1
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| -rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java b/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java index d2a59c1310..b118fd6bc9 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java @@ -378,7 +378,7 @@ public class DirCacheEntry { // final int base = infoOffset + P_MTIME; final int mtime = NB.decodeInt32(info, base); - if (smudge.getEpochSecond() == mtime) { + if ((int) smudge.getEpochSecond() == mtime) { return smudge.getNano() <= NB.decodeInt32(info, base + 4); } return false; |