Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Wilkins2015-01-02 14:31:34 +0000
committerGreg Wilkins2015-01-02 14:31:34 +0000
commitdcd9182f87ec9bc890311657cc155ce0099fc11b (patch)
tree0ac595e750390b574f8d280c77313e9fdcd2d132
parenta4d2895400f033a6b2018b117a8d555ccef0ed58 (diff)
downloadorg.eclipse.jetty.project-dcd9182f87ec9bc890311657cc155ce0099fc11b.tar.gz
org.eclipse.jetty.project-dcd9182f87ec9bc890311657cc155ce0099fc11b.tar.xz
org.eclipse.jetty.project-dcd9182f87ec9bc890311657cc155ce0099fc11b.zip
fixed client test for new lazy consumeAll behaviour
-rw-r--r--jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientStreamTest.java2
-rw-r--r--jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTest.java18
-rw-r--r--jetty-client/src/test/java/org/eclipse/jetty/client/RespondThenConsumeHandler.java27
3 files changed, 28 insertions, 19 deletions
diff --git a/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientStreamTest.java b/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientStreamTest.java
index 469505cabe..956a684c55 100644
--- a/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientStreamTest.java
+++ b/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientStreamTest.java
@@ -89,7 +89,7 @@ public class HttpClientStreamTest extends AbstractHttpClientServerTest
output.write(kb);
}
- start(new EmptyServerHandler());
+ start(new RespondThenConsumeHandler());
final AtomicLong requestTime = new AtomicLong();
ContentResponse response = client.newRequest("localhost", connector.getLocalPort())
diff --git a/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTest.java b/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTest.java
index 5c59060ee2..eed2866802 100644
--- a/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTest.java
+++ b/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTest.java
@@ -19,7 +19,6 @@
package org.eclipse.jetty.client;
import java.io.IOException;
-import java.io.InputStream;
import java.io.OutputStream;
import java.net.HttpCookie;
import java.net.URI;
@@ -580,23 +579,6 @@ public class HttpClientTest extends AbstractHttpClientServerTest
Files.delete(file);
}
- private static class RespondThenConsumeHandler extends AbstractHandler
- {
- @Override
- public void handle(String target, org.eclipse.jetty.server.Request baseRequest, HttpServletRequest request, HttpServletResponse response)
- throws IOException, ServletException
- {
- baseRequest.setHandled(true);
- response.setContentLength(0);
- response.setStatus(200);
- response.flushBuffer();
-
- InputStream in = request.getInputStream();
- while(in.read()>=0);
- }
-
- }
-
@Test
public void test_ExchangeIsComplete_WhenRequestFailsMidway_WithResponse() throws Exception
{
diff --git a/jetty-client/src/test/java/org/eclipse/jetty/client/RespondThenConsumeHandler.java b/jetty-client/src/test/java/org/eclipse/jetty/client/RespondThenConsumeHandler.java
new file mode 100644
index 0000000000..b5c0644a73
--- /dev/null
+++ b/jetty-client/src/test/java/org/eclipse/jetty/client/RespondThenConsumeHandler.java
@@ -0,0 +1,27 @@
+package org.eclipse.jetty.client;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.eclipse.jetty.server.handler.AbstractHandler;
+
+class RespondThenConsumeHandler extends AbstractHandler
+{
+ @Override
+ public void handle(String target, org.eclipse.jetty.server.Request baseRequest, HttpServletRequest request, HttpServletResponse response)
+ throws IOException, ServletException
+ {
+ baseRequest.setHandled(true);
+ response.setContentLength(0);
+ response.setStatus(200);
+ response.flushBuffer();
+
+ InputStream in = request.getInputStream();
+ while(in.read()>=0);
+ }
+
+} \ No newline at end of file

Back to the top