aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Becker2013-09-23 08:35:58 (EDT)
committerThomas Becker2013-09-23 08:39:49 (EDT)
commitbfb90523d67d62aa5e4da05b9ad8925591e9f84a (patch)
treecbcc6c13c1f8ada81b370457c9d2066137cd19d5
parent4708c907c1f070ab573d361e29092a52c79374ae (diff)
downloadorg.eclipse.jetty.project-bfb90523d67d62aa5e4da05b9ad8925591e9f84a.zip
org.eclipse.jetty.project-bfb90523d67d62aa5e4da05b9ad8925591e9f84a.tar.gz
org.eclipse.jetty.project-bfb90523d67d62aa5e4da05b9ad8925591e9f84a.tar.bz2
SPDY remove unnecessary flush calls
-rw-r--r--jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java6
-rw-r--r--jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardStream.java2
2 files changed, 0 insertions, 8 deletions
diff --git a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
index 66804fe..e2921dc 100644
--- a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
+++ b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
@@ -533,7 +533,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
streamListener = notifyOnSyn(listener, stream, synInfo);
}
stream.setStreamFrameListener(streamListener);
- flush();
// The onSyn() listener may have sent a frame that closed the stream
if (stream.isClosed())
removeStream(stream);
@@ -698,7 +697,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
RstInfo rstInfo = new RstInfo(frame.getStreamId(), StreamStatus.from(frame.getVersion(), frame.getStatusCode()));
notifyOnRst(listener, rstInfo);
- flush();
if (stream != null)
removeStream(stream);
@@ -722,7 +720,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
}
SettingsInfo settingsInfo = new SettingsInfo(frame.getSettings(), frame.isClearPersisted());
notifyOnSettings(listener, settingsInfo);
- flush();
}
private void onPing(PingFrame frame)
@@ -732,7 +729,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
{
PingResultInfo pingResultInfo = new PingResultInfo(frame.getPingId());
notifyOnPing(listener, pingResultInfo);
- flush();
}
else
{
@@ -747,7 +743,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
//TODO: Find a better name for GoAwayResultInfo
GoAwayResultInfo goAwayResultInfo = new GoAwayResultInfo(frame.getLastStreamId(), SessionStatus.from(frame.getStatusCode()));
notifyOnGoAway(listener, goAwayResultInfo);
- flush();
// SPDY does not require to send back a response to a GO_AWAY.
// We notified the application of the last good stream id and
// tried our best to flush remaining data.
@@ -788,7 +783,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
private void onCredential(CredentialFrame frame)
{
LOG.warn("{} frame not yet supported", frame.getType());
- flush();
}
protected void close()
diff --git a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardStream.java b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardStream.java
index 698c4bb..3fe6559 100644
--- a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardStream.java
+++ b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardStream.java
@@ -246,7 +246,6 @@ public class StandardStream extends IdleTimeout implements IStream
throw new IllegalStateException();
}
}
- session.flush();
}
@Override
@@ -270,7 +269,6 @@ public class StandardStream extends IdleTimeout implements IStream
updateCloseState(dataInfo.isClose(), false);
notifyOnData(dataInfo);
- session.flush();
}
@Override