423974 - Optimize flow control.

Don't send the window update if the stream is closed.

1 files changed, 13 insertions, 5 deletions

diff --git a/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/SimpleFlowControlStrategy.java b/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/SimpleFlowControlStrategy.java
index 450529f2b1..3714503fe3 100644
--- a/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/SimpleFlowControlStrategy.java
+++ b/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/SimpleFlowControlStrategy.java
@@ -52,11 +52,19 @@ public class SimpleFlowControlStrategy extends AbstractFlowControlStrategy
         Frame[] streamFrame = Frame.EMPTY_ARRAY;
         if (stream != null)
         {
-            streamFrame = new Frame[1];
-            streamFrame[0] = new WindowUpdateFrame(stream.getId(), length);
-            stream.updateRecvWindow(length);
-            if (LOG.isDebugEnabled())
-                LOG.debug("Data consumed, increased stream recv window by {} for {}", length, stream);
+            if (stream.isClosed())
+            {
+                if (LOG.isDebugEnabled())
+                    LOG.debug("Data consumed, ignoring update stream recv window by {} for closed {}", length, stream);
+            }
+            else
+            {
+                streamFrame = new Frame[1];
+                streamFrame[0] = new WindowUpdateFrame(stream.getId(), length);
+                stream.updateRecvWindow(length);
+                if (LOG.isDebugEnabled())
+                    LOG.debug("Data consumed, increased stream recv window by {} for {}", length, stream);
+            }
         }
 
         session.control(stream, Callback.Adapter.INSTANCE, sessionFrame, streamFrame);