diff options
| author | Lars Vogel | 2018-06-29 12:44:00 +0000 |
|---|---|---|
| committer | Lars Vogel | 2018-07-03 07:42:14 +0000 |
| commit | bd8e49db68c0f414680cc5220b826de22a17e60e (patch) | |
| tree | d66a53a2d21b4a7b40af656571c300a21a698b21 | |
| parent | 0d197ba1da706a1fef89adace81d9feed3fad428 (diff) | |
| download | eclipse.jdt.ui-bd8e49db68c0f414680cc5220b826de22a17e60e.tar.gz eclipse.jdt.ui-bd8e49db68c0f414680cc5220b826de22a17e60e.tar.xz eclipse.jdt.ui-bd8e49db68c0f414680cc5220b826de22a17e60e.zip | |
Fixes method invokes inefficient new String(String) constructor
https://sonar.eclipse.org/drilldown/issues/33296?&rule=findbugs%3ADM_STRING_CTOR&rule_sev=MAJOR&severity=MAJOR
Change-Id: Idc85b5619209abed960aed787b4065e13054ef02
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
4 files changed, 5 insertions, 5 deletions
diff --git a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgPolicyFactory.java b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgPolicyFactory.java index bc17e3d97f..585cb974b3 100644 --- a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgPolicyFactory.java +++ b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgPolicyFactory.java @@ -4385,7 +4385,7 @@ public final class ReorgPolicyFactory { } } - final String value= new String(buffer.toString().trim()); + final String value= buffer.toString().trim(); if (!"".equals(value)) //$NON-NLS-1$ arguments.put(ATTRIBUTE_LOG, value); } @@ -4425,7 +4425,7 @@ public final class ReorgPolicyFactory { buffer.append(DELIMITER_RECORD); } } - final String value= new String(buffer.toString().trim()); + final String value= buffer.toString().trim(); if (!"".equals(value)) //$NON-NLS-1$ arguments.put(ATTRIBUTE_LOG, value); } diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchQuery.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchQuery.java index 36a07e458f..b8a253a3ff 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchQuery.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchQuery.java @@ -278,7 +278,7 @@ public class JavaSearchQuery implements ISearchQuery { } else if (firstSpecification instanceof PatternQuerySpecification) { return BasicElementLabels.getFilePattern(((PatternQuerySpecification) firstSpecification).getPattern()); } else { - return new String(""); //$NON-NLS-1$ + return ""; //$NON-NLS-1$ } } diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaSourceViewerConfiguration.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaSourceViewerConfiguration.java index 90e1968f8b..49f5c04b34 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaSourceViewerConfiguration.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaSourceViewerConfiguration.java @@ -595,7 +595,7 @@ public class JavaSourceViewerConfiguration extends TextSourceViewerConfiguration if (i < tabWidth) indentPrefixes[i+1]= spaces + '\t'; else - indentPrefixes[i+1]= new String(spaces); + indentPrefixes[i+1]= spaces; } indentPrefixes[tabWidth + 1]= ""; //$NON-NLS-1$ diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/CompletionProposalCollector.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/CompletionProposalCollector.java index b31be12ffa..dfab32e3d0 100755 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/CompletionProposalCollector.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/CompletionProposalCollector.java @@ -836,7 +836,7 @@ public class CompletionProposalCollector extends CompletionRequestor { javaProposal.setProposalInfo(new MethodProposalInfo(fJavaProject, proposal)); javaProposal.setRelevance(computeRelevance(proposal)); - fSuggestedMethodNames.add(new String(name)); + fSuggestedMethodNames.add(name); return javaProposal; } |