Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-06-12Bug 544073 - break, BreakStatement - Grammar and related changesmanoj_544073_yieldManoj Palat28-293/+82
Change-Id: I312a7d9a76408ede5d7144d3b7f00ef324e2e6c6
2019-06-10Bug 544073 - further improvements - WIPManoj Palat9-118/+252
Change-Id: I07a5cd7f99554912164b062420609bcfc5ab6223
2019-06-08Bug 544073 - Experimental initial Commit - WIP - DONOTUSEManoj Palat33-600/+3507
Change-Id: Ibc5371807c81c46bd2cbb53e76fdc42605d9f4d6
2019-05-28Bug 545771 - [13] Create Java 13 version and supporting code in testsJay Arthanareeswaran7-9/+90
Change-Id: I55340ff889650cb958c8f3c24029f386a37fdce6 Signed-off-by: Jay Arthanareeswaran <>
2019-05-22Bug 545983: [12] EJC allows switch expression to be concluded withoutS4_12_0_M3I20190527-0600I20190526-1800I20190526-0600I20190525-1800I20190525-0600I20190524-1800I20190524-0135I20190522-1800I20190522-0600Jay Arthanareeswaran2-3/+3
returning a value Fixing the error message Change-Id: I86334dc6025d234c7c8ea66e5f07043e9008c305 Signed-off-by: Jay Arthanareeswaran <>
2019-05-20Bug 547479 - Java 9+ (JPMS) Intermittent compilation error "The type...I20190521-1800I20190521-0600I20190520-1805Christoph Langer2-0/+57
is not accessible". LookupEnvironment::reset() shall reset "this.stepCompleted" to 0. Change-Id: I6748f8cf08f460f5e47c39dadd0f52099e03edf6 Signed-off-by: Christoph Langer <> Also-by: Stephan Herrmann <>
2019-05-20Bug 543266 Allow comments in enum declarationKenneth2-0/+58
Change-Id: I9f19fc03dd15144e7bd408361e0886164fdc0c44 Signed-off-by: Kenneth <>
2019-05-19Bug 502327 - [compiler][inference] Problem marker 'method not applicableI20190520-0600I20190519-1800Stephan Herrmann2-1/+36
for the arguments' Change-Id: I0a4c948d6ce72772d5236fd461ee84998f0e0c79
2019-05-19Bug 525822 - [1.8] ECJ compiles ambiguous lambda method invocationStephan Herrmann19-51/+206
without warning, breaking builds with javac. Change-Id: Iaad08af8fe399311ed05252129037b7377f4fa72 Signed-off-by: Stephan Herrmann <>
2019-05-18Bug 545420 - [1.8][inference] Receiving The target type of thisStephan Herrmann2-0/+32
expression must be a functional interface Change-Id: Ia55c7f0399cdea0c4448a15bf835406ceb828977
2019-05-17Bug 541466 - Eclipse APT implementation fails when annotation referencesI20190518-1800I20190517-1800Till Brychcy1-12/+18
a class not on the class path Change-Id: Ic80814c9a2cf99dc02cc18ac51225c763d6ae6b8
2019-05-16Bug 544306 - [Java 11] Error in Editor when using class in Test sourceI20190516-1800Till Brychcy5-8/+69
code from modular test dependency Change-Id: I316d5bf212a555b2855dafc7481abcf7b275ad1e
2019-05-16Bug 545715 comment 25 - [12] Assignment analysis doesn't work in switchI20190516-1405I20190516-1335I20190516-1250I20190516-1200I20190516-1055Manoj Palat1-3/+7
statement with -> Change-Id: I1f03d9bc91b6f8d2db9ca1655f4f3607ba6f63b5
2019-05-15Bug 543604 - [9] Error when hovering a HashMapStephan Herrmann1-2/+36
- fix test isolation: don't delete project required by other tests! - added test variant trying to use project option Change-Id: I886d9cb0e27dd45c799e505cc8c1011a9bc27eeb
2019-05-15Bug 543604 - [9] Error when hovering a HashMapI20190515-1800Simeon Andreev6-11/+77
The bug was observed under the following conditions: 1. Debug a snippet with a map variable on Java 9 or above JRE. 2. Enable "Show Logical Structure" in the variables view. 3. Expand a local variable or a parameter of type java.util.Map or inheriting, either in the debug hover in the Java source editor or in the Variables view. 4. Observe an error text instead of content. The error is caused by JDT debug attempting to compile a snippet as follows: package java.util; abstract class Map___ implements java.util.Map { void ___run() throws Throwable { return entrySet().toArray(); } } This snippet is constructed in order to validate whether the expression "return entrySet().toArray();" compiles in the context of the current breakpoint. On Java 9 and above, this snippet is not legal. java.util is already contained in the JRE libraries; its not possible to define a package like this and compile it without extra compile arguments (in particular --patch-module). To fix this problem, we add a special compile mode to JDT core, used by JDT debug. When in this mode, the JDT compiler will ignore split package problems. The compiled expression "return entrySet().toArray();" is then used for evaluation against the underlying java.util.Map, which does work with JRE 9+. Change-Id: Iaaf3edde97e5006aecc8792df9da789b8eddbfce Signed-off-by: Simeon Andreev <> Signed-off-by: Andrey Loskutov <>
2019-05-15Bug 547148 - Expose Outer Synthetic Locals from Method BindingManoj Palat4-4/+95
Requested by JDT debug for bug 534687, to allow debug framework show captured lambda variable names as val$outerArg instead of arg$1 etc. Change-Id: I47a3719efbcb7fb82ea04b27321eb0f3fa92bd80 Signed-off-by: Andrey Loskutov <>
2019-05-13Bug 540902 - JRE Verify Error Case: Inconsistent stackmap framesI20190515-0205I20190513-1800Jay Arthanareeswaran2-20/+119
Change-Id: Idbb98d5dfbf676b014637d2d9f13ba7dfd3fb78a Signed-off-by: Jay Arthanareeswaran <>
2019-05-13Bug 547051 - do not run Java 9+ subclass search in tests on Java 8Andrey Loskutov1-0/+6
Change-Id: I161d32da87f1a4a9e83e703c4ee09caed64870a1 Signed-off-by: Andrey Loskutov <>
2019-05-13Bug 547125 [12] NPE inJay Arthanareeswaran2-19/+87
compiler.problem.ProblemReporter.duplicateCase(...) on reconcile Change-Id: Ie97b4e108f4ce1c15376cba577d55e40d148663c Signed-off-by: Jay Arthanareeswaran <>
2019-05-13Bug 545446 - Content assist sorting by relevance is broken Vikas Chandra2-10/+10
Change-Id: I01ce846af74f8ce45cd4f07581fae80a4bd66750 Signed-off-by: Vikas Chandra <>
2019-05-12Bug 404648 - [1.8][compiler] investigate differences between ECJ & javacI20190512-1800Stephan Herrmann1-0/+15
- improve cleanup between javac invocations Change-Id: Ib5cca78c085e68b97fd7dca9f19f03d5564dbd18 Signed-off-by: Stephan Herrmann <>
2019-05-12Bug 512156 - [inference] Eclipse build freezes due to genericsStephan Herrmann1-7/+2
processing - test fix wrt run-javac Change-Id: I4a770afd19e978e90adf92ede6bec0ccc3bb7499 Signed-off-by: Stephan Herrmann <>
2019-05-12Bug 547197 - [9][model] API to get the kind of a IModuleDescriptionStephan Herrmann1-0/+15
Change-Id: I711c1322ade275a3ca0fff51e53588a02cef2935 Signed-off-by: Stephan Herrmann <>
2019-05-11Bug 547114 - NPE at ModuleBinding.addReads(...) on changing ModuleStephan Herrmann10-11/+120
Dependencies Change-Id: I3689bb56f02eba46dcc9b5a8b689c109bbc227ff Signed-off-by: Stephan Herrmann <>
2019-05-11Bug 547051 - subclass search with patterns doesn't work for modulesI20190511-1800Andrey Loskutov3-12/+104
Updated IndexBasedHierarchyBuilder.createInfoFromClassFileInJar() to include module name of the given type. Change-Id: I3e1a2842728b7e576472ea9534a0ea3753e3b73d Signed-off-by: Andrey Loskutov <>
2019-05-10Bug 547094 - Refactoring not working with Java 11 (NPE atStephan Herrmann1-1/+2
org.eclipse.jdt.internal.compiler.util.Sorting.sortSuper( - avoid escaping of TheNotFoundType. Change-Id: I40c69c5f202a92127b24d7579ea78d9d960c6a46 Signed-off-by: Stephan Herrmann <>
2019-05-10Bug 547095 - SIOOBE trying to search in context of a class from modularI20190510-1800Andrey Loskutov4-2/+98
JDK Updated documentPath constructed in findIndexMatches() to consider module name of the requested type. Change-Id: Ifbae408c357c4822500adce26fddd1bf44e47781 Signed-off-by: Andrey Loskutov <>
2019-05-09Bug 547061 - [1.8][inference] Unresolved compilation problem forI20190509-1800Stephan Herrmann2-3/+49
exception in lambda Change-Id: I5704a6e714d842156b6509a99e84d618a362be51 Signed-off-by: Stephan Herrmann <>
2019-05-08Bug 547051 - Java search with HierarchyScope does not find JDK classesAndrey Loskutov3-10/+83
on modular JVM Updated focusPath and resourcePaths to consider module name of the requested type. Change-Id: Id5b8565ac280af7f4f1abdd56edaa82d83de79b4 Signed-off-by: Andrey Loskutov <>
2019-05-04Bug 544898 - [newindex] Disable new index in JDT coreI20190508-1800I20190508-0450I20190508-0150I20190507-1800I20190507-0155I20190506-1800I20190505-1800I20190504-1800Andrey Loskutov6-56/+61
Change-Id: Ic7a72f57887109eb8e109aae464f80980547d119 Signed-off-by: Andrey Loskutov <>
2019-05-03Bug 546084 - Using Junit 5s MethodSource leads to ClassCastExceptionI20190503-1800Pierre-Yves B.2-15/+125
Change-Id: Iabe4314df651de44e3f7b3ee94399e5530f146ad Signed-off-by: Pierre-Yves B. <>
2019-05-01Bug 512156 - [inference] Eclipse build freezes due to generics process.Sebastian Lohmeier3-8/+177
- Add innerContext argument to InferenceContext18.resumeSuspendedInference(...) to be able to detect multiple invocations for same inner context and to eliminate duplicate inference variables in this case to speed up compilation Change-Id: I0b8f36c0bf94ed1c137294143e500a05938f444e Signed-off-by: Sebastian Lohmeier <>
2019-04-30Bug 546319 - ConcurrentModificationException inI20190502-1800I20190501-1800Andrey Loskutov3-29/+38
org.eclipse.jdt.internal.compiler.batch.ClasspathJrt.allModules() Access to module names maps stored in ModulesCache must be synchronized, because it is used from global static context and is not MT safe. Change-Id: I3f6b5e478070a1e2de8d9431fdf43a3513085677 Signed-off-by: Andrey Loskutov <>
2019-04-30Bug 546146 - [12] AST Rewrite should use current formatter settingsI20190501-0525I20190430-1800Sarika Sinha4-35/+83
Change-Id: Icb86dd1558b090e7fb0403b2a7454f11ac99cb07
2019-04-29Bug 545898 - [formatter] IOOBE with empty javadoc @paramI20190429-1800Mateusz Matela2-3/+16
2019-04-26Bug 546653 - [9] More details in module-related classpath attributes:I20190429-0240I20190428-1800I20190427-1800I20190426-1800Stephan Herrmann6-20/+83
add add-opens, enhance patch-module Change-Id: I7585b97f7b73ce7948bccb6dd7798fc0b3d9682e Signed-off-by: Stephan Herrmann <>
2019-04-26Bug 546649 - [9][model] API to get exports and opens from anStephan Herrmann2-1/+55
IModuleDescription Change-Id: I09fcaa4cc94e96ef6d54cff3717f6fc69c4d82e7 Signed-off-by: Stephan Herrmann <>
2019-04-26Bug 546352 - [9] New comprehensive UI for Modularity DetailsStephan Herrmann1-1/+6
- make ModularClassFileMatchLocator more robust Change-Id: Ie9e59b0b225282d3dc2c1fac4d6c18d7292362bc Signed-off-by: Stephan Herrmann <>
2019-04-26reverting the api filter part of bug 545983 for the issue reported inManoj Palat1-0/+9
bug 546762
2019-04-26Bug 545716 - [12] expression switch doesn't consider that having allManoj Palat2-3/+3
cases of an enum is enough to be exhaustive - minor commit for method name as per bug 545716 comment 9 Change-Id: I20216be5cc924dcae6e6f3d6ed1c59f5602d8c8d
2019-04-25Bug 545983 - [12] EJC allows switch expression to be concluded withoutManoj Palat7-11/+83
returning a value Change-Id: Ief731591c3c460e09df23c7110c8bdb62dc1d69a
2019-04-24Bug 546677 - Add @apiNote, @implSpec and @implNote to TagElementI20190425-1800I20190425-0030I20190424-1800Vikas Chandra1-1/+19
Change-Id: Ia436e65b5c53e676a1a756d06e8683d780591107 Signed-off-by: Vikas Chandra <>
2019-04-23Bug 546362 - Deploy ecj compiler from S-4.12M1-201904110625 and use itI20190423-1800Till Brychcy2-1/+20
for 4.12 M3 build Change-Id: I3ba29b351c598950735296de8efc9be9d20cccb3
2019-04-21Bug 545491 - Improved performance of ReferenceCollectionI20190422-1800I20190421-1800Sebastian Zarnekow5-104/+612
The implementation of reference collection suffered from a couple of quadratic lookup operations in its logic to determine, whether the collection includes certain names. Instead of doing a simple nested loop scanning of the given arrays, we apply an algorithm based on the reduced runtime complexity of binary searches. The reference collections are long living objects that are far more often queried than modified. Now we use a simple comparator to sort the arrays by length and content. When the collection is asked whether it contains another list of names, these names have to be interned. In addition to the interning, we also sort the argument arrays. Now we do have a total of three pairs of arrays, each of the paired arrays is sorted by the same criteria. That allows to walk both arrays pairways so even if the worst case, we do no longer need O(n*m) with n=first.length and m = second.length, but only O(2*(n+m)) comparisons. For longer arrays, we even use binary search logic to skip more than one array index when we advance the iteration. In our scenario, this reduced the accumulated time for invocations of include from 90s to less than one second. Change-Id: Ib35b4250ab34fbab55723ebe1f9ad345afca86dd Signed-off-by: Sebastian Zarnekow <> Signed-off-by: Andrey Loskutov <>
2019-04-17Bug 545715 - [12] Assignment analysis doesn't work in switch statementI20190420-1800I20190419-1800I20190418-1800I20190417-1800Manoj Palat3-3/+22
with -> Change-Id: I1e8c81771aa6ccb0462a55e8ad662c38cd087b29
2019-04-16Bug 542795 - NPE in ProblemReporter.deprecatedSinceValue(...)I20190416-1800Stephan Herrmann3-0/+103
Change-Id: Ib993ac655af27f5caf14c3037b25144d47e070b2 Signed-off-by: Stephan Herrmann <>
2019-04-16Bug 546410 - [12][test] ASTStructuralPropertyTest needs an update afterStephan Herrmann1-3/+3
addition of SwitchExpression Change-Id: I36767e628c16a4c12b7fcac784d4c70268b7a946
2019-04-15Bug 546397 - [impl] conflicting constants in JavadocTagConstants I20190415-1800Vikas Chandra1-11/+11
Change-Id: I5ddc305765045600033e189bb006610281b4ad13 Signed-off-by: Vikas Chandra <>
2019-04-15Bug 546338 - NPE at Loskutov1-0/+3
Change-Id: I9c3baaed4984e5a10c44d212954fd6f9a4970d39 Signed-off-by: Andrey Loskutov <>
2019-04-14Bug 421821 - Two errors reported for unresolved type accessI20190414-1800Stephan Herrmann2-20/+10
Change-Id: I9cbf25d6b5931bcfce05ea490cadddcb8253da93 Signed-off-by: Stephan Herrmann <>

Back to the top