Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJayaprakash Arthanareeswaran2012-01-21 06:00:18 +0000
committerJayaprakash Arthanareeswaran2012-01-21 06:00:18 +0000
commit8c93d4e99b8a943865cb7391e781eba5bb83dfc9 (patch)
tree85ab62bf74fffc4094409725c0ee3889f6fd393f
parent92ff37d9e6ed58e7d36e82817b405bcadb5692ad (diff)
downloadeclipse.jdt.core-8c93d4e99b8a943865cb7391e781eba5bb83dfc9.tar.gz
eclipse.jdt.core-8c93d4e99b8a943865cb7391e781eba5bb83dfc9.tar.xz
eclipse.jdt.core-8c93d4e99b8a943865cb7391e781eba5bb83dfc9.zip
HEAD - Fix for bug 369251: Starved worker threads
-rw-r--r--org.eclipse.jdt.core/buildnotes_jdt-core.html6
-rw-r--r--org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java18
2 files changed, 11 insertions, 13 deletions
diff --git a/org.eclipse.jdt.core/buildnotes_jdt-core.html b/org.eclipse.jdt.core/buildnotes_jdt-core.html
index 54a402f6b8..692a2eece8 100644
--- a/org.eclipse.jdt.core/buildnotes_jdt-core.html
+++ b/org.eclipse.jdt.core/buildnotes_jdt-core.html
@@ -52,7 +52,9 @@ Eclipse SDK 3.8.0 - %date% - 3.8.0 M5
<h2>What's new in this drop</h2>
<h3>Problem Reports Fixed</h3>
-<a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=365208">365208</a>
+<a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=369251">369251</a>
+Starved worker threads
+<br><a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=365208">365208</a>
[compiler][batch] command line options for annotation based null analysis
<a name="v_C30"></a>
@@ -140,8 +142,6 @@ Eclipse SDK 3.8.0 - January 20, 2012
<h3>Problem Reports Fixed</h3>
<a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=361356">361356</a>
Allow to specify encoding for source attachments
-<br><a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=368152">368152</a>
-ConcurrentModificationException on startup in ExternalFoldersManager.createPendingFolders
<br><a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=365582">365582</a>
FUP of bug 361938: Other error code pattern
<br><a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=365662">365662</a>
diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
index 192d0973d4..d6156980e7 100644
--- a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
+++ b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
@@ -122,7 +122,7 @@ public class ExternalFoldersManager {
} while (result.exists());
if (scheduleForCreation) {
if (this.pendingFolders == null)
- this.pendingFolders = Collections.synchronizedSet(new HashSet());
+ this.pendingFolders = new HashSet();
this.pendingFolders.add(externalFolderPath);
}
knownFolders.put(externalFolderPath, result);
@@ -166,15 +166,13 @@ public class ExternalFoldersManager {
catch(CoreException e) {
throw new JavaModelException(e);
}
- synchronized (this.pendingFolders) {
- Iterator iterator = this.pendingFolders.iterator();
- while (iterator.hasNext()) {
- Object folderPath = iterator.next();
- try {
- createLinkFolder((IPath) folderPath, false, externalFoldersProject, monitor);
- } catch (CoreException e) {
- Util.log(e, "Error while creating a link for external folder :" + folderPath); //$NON-NLS-1$
- }
+ Iterator iterator = this.pendingFolders.iterator();
+ while (iterator.hasNext()) {
+ Object folderPath = iterator.next();
+ try {
+ createLinkFolder((IPath) folderPath, false, externalFoldersProject, monitor);
+ } catch (CoreException e) {
+ Util.log(e, "Error while creating a link for external folder :" + folderPath); //$NON-NLS-1$
}
}
this.pendingFolders.clear();

Back to the top