| author | akozak | 2011-11-24 07:48:45 (EST) |
|---|---|---|
| committer | Winston Prakash | 2011-12-01 20:47:25 (EST) |
| commit | 3d9956dddf694b50d22f0f36ea68a7eff4d4935b (patch) (side-by-side diff) | |
| tree | f8ca4abf992bf6acfffbdc3e4c3135af63d56691 | |
| parent | 277ae3bf1d8a818be250887dd85e4a82d54f2957 (diff) | |
| download | org.eclipse.hudson.core-3d9956dddf694b50d22f0f36ea68a7eff4d4935b.zip org.eclipse.hudson.core-3d9956dddf694b50d22f0f36ea68a7eff4d4935b.tar.gz org.eclipse.hudson.core-3d9956dddf694b50d22f0f36ea68a7eff4d4935b.tar.bz2 | |
Fixed NPE (if the node on which the job previously had been built was not available)
Signed-off-by: Winston Prakash <winston.prakash@gmail.com>
| -rw-r--r-- | hudson-core/src/main/java/hudson/model/AbstractProject.java | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/hudson-core/src/main/java/hudson/model/AbstractProject.java b/hudson-core/src/main/java/hudson/model/AbstractProject.java index c728489..d936f4d 100644 --- a/hudson-core/src/main/java/hudson/model/AbstractProject.java +++ b/hudson-core/src/main/java/hudson/model/AbstractProject.java @@ -1527,7 +1527,12 @@ public abstract class AbstractProject<P extends AbstractProject<P,R>,R extends A return BUILD_NOW; } } else { - WorkspaceList l = lb.getBuiltOn().toComputer().getWorkspaceList(); + Node node = lb.getBuiltOn(); + if (node == null || node.toComputer() == null) { + LOGGER.log(Level.FINE, "Node on which this job previously was built is not available now, build is started on an available node"); + return isInQueue() ? NO_CHANGES : BUILD_NOW; + } + WorkspaceList l = node.toComputer().getWorkspaceList(); // if doing non-concurrent build, acquire a workspace in a way that causes builds to block for this workspace. // this prevents multiple workspaces of the same job --- the behavior of Hudson < 1.319. // |

