Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-01For-each conversion in RemediationOperation.Alexander Kurtakov1-4/+4
Change-Id: I81f8ea465e9127a01b248d7ca2d379d392ce93b1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-01For-each conversion in ProfileChangeRequest.Alexander Kurtakov1-4/+4
Change-Id: I20bb4044d92a3a28b73906f381fd1764f034fbe6 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-01For-each conversion in ElementUtils.Alexander Kurtakov1-23/+21
Change-Id: I07c4eeb8dc3e976ad0b20b9b52809643887e6914 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-10Bug 535824 - Check for directory traversal entry pathsY20180712-0200I20180717-0320I20180716-2000I20180716-0715I20180715-2000I20180714-1500I20180713-2000I20180712-2000I20180711-2000I20180710-2000Thomas Watson5-6/+63
Change-Id: I105a488ea8264c1a2420a819255e6a95219365ad Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2018-07-10Try-with-resources in p2.repository.tools.Alexander Kurtakov3-70/+108
Enabled the compiler warning and changed the formatter to standard eclipse one so lines are not endless. Change-Id: I90519c176f366e847ba4f24021a8ed94790a7c8e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-05Bug 536616 - Test testPauseAndResumeMoreThanOnce and testPauseAndResumeI20180709-2000I20180708-2000I20180707-1500I20180706-2000I20180705-2000Alexander Kurtakov1-4/+14
fail Switch to fetching photon content.jar. Change-Id: I65c56f6038198c4241888d94f3b3e6705cc1d773 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-26Fix typo in MirrorSelector's initMirrors(IProgressMonitor) javadocY20180705-0105I20180704-2000I20180704-0805I20180704-0605I20180704-0545I20180703-2000I20180702-2000I20180702-0435I20180701-2000I20180630-1500I20180629-2000Mykola Nikishov1-1/+1
Change-Id: Ibbc6da645c2b547971c79f75bda7871d44c2b253 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-14Nothing to return from MirrorSelector's initMirrors methodY20180628-0525I20180629-0420I20180629-0400I20180628-2000I20180628-0230I20180627-2020I20180627-2000I20180625-1545I20180621-2000I20180618-0800I20180615-0655I20180615-0300I20180614-2045I20180614-2000Mykola Nikishov1-4/+3
Change-Id: I5c469e350b720d167333ad7142d3fa5275236877 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-13Minor - Fix typosMichael Keppler4-19/+19
Rename "licence" to "license". All code changes are in tests or in classes of internal packages, therefore no public API changes. Change-Id: I39713a9a9c46cf230947e33765383cddb6d102c4 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-06-13Refactor internal MirrorSelector's computeMirrors(String, IProgressMonitor)Mykola Nikishov1-11/+15
Change-Id: I88ceb0b4f5f076b4ba00cfeccc1a0b2c567c9fdb Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-13Refactor internal MirrorSelector's computeMirrors(String, IProgressMonitor)Mykola Nikishov1-10/+14
Change-Id: I427769a505ef055d3ea5df6481f5bb3546d787de Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-13Refactor internal MirrorSelector's computeMirrors(String, IProgressMonitor)Mykola Nikishov1-16/+18
Change-Id: I38bd174a92d89945b96e380d866aa0ef1d963d16 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-12Bug 533655 - Can't deselect features from top level category which hasI20180613-0440I20180613-0300Joshua Matsuoka1-4/+13
subcategories Change-Id: I6214b2518b13c4243c84d61de0a2e4d21b20b5b5 Signed-off-by: Joshua Matsuoka <jmatsuok@redhat.com>
2018-06-12Extract method to get artifact repositories in DownloadManagerMykola Nikishov1-7/+18
Change-Id: I03f3710c7d1debf148a90911557c1353e14cc80d Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-06-11Bug 535318 - Update license to EPL-2.0 for p2 in about.htmlLars Vogel47-810/+1213
Change-Id: I9c48c4b54d9685e1ee7d5296093d7b27d3d50e54 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-06-07Fix warnings in bin.includes.I20180607-2000Alexander Kurtakov2-2/+2
Change-Id: I3a1b0fbd18434ae957c53cac520cdda12a7e8b0c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov14-162/+296
Take care of p2.tests.discovery. Bump BREE code updates and move to JUnit 4. Change-Id: I033137b0b994357f169f399801f730e6d4760a1e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov8-117/+234
Take care of p2.sar bundle. Change-Id: I1081d9df9dca93919f79e8e74deeb1133b75e5bd Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov10-62/+147
Take care of p2.artifact.processors. Bumped BREE and all kind of modernizations applied. Change-Id: I30c131ae43c427de839b08e637810c5df932f2d7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov16-213/+303
Take care of p2.artifact.optimizers. All kind of modernizations to the codebase done. Change-Id: Ic4c0422a2d3aa320ef8d126c2974964c478177d7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov24-268/+457
Take care of various modernizations and updates in p2.testserver. Change-Id: Id5ad446c1cab4cf81702a28e976c41a41070cd58 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535636 - Update bundles to Java 1.8Alexander Kurtakov25-590/+275
Take care of p2.tests.optimizers. Bump BREE, enable more warnings and fix them, remove parts testing non existing code, convert to JUnit 4 and etc. Change-Id: I8992fa1cf4bdb42a76e288e5b28aae466db21c80 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-07Bug 535318 - Update versions for next releaseAlexander Kurtakov86-85/+93
Prep for update license to EPL-2.0 Change-Id: I2fe45c006012a83c207821a2d41abaa248df3802 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-05Bug 534536 - The planner always reports detailed statusI20180606-1020Todor Boev13-139/+338
- SimplePlanner builds a MultiStatus for successful operations just like it does for failed ones - The DirectorApplication logs the status of successful planner invocations Change-Id: I0886dcf377172f99cf2d26df0f2b3dedfe9a7280 Signed-off-by: Todor Boev <rinsvind@gmail.com>
2018-06-01Bug 534372 - Cleaned up the p2 director log logicTodor Boev6-135/+224
Concentrated all output into the ILog facade: std streams and the log. Added a DefaultLog implementation of ILog instead of using if-s. All code related to the "stacktrace" flag is dead since it can't be set from the command line. Removed to simplify logic. Change-Id: Ia9a4009701eb3370d7b8a158ee4d9612286eea69 Signed-off-by: Todor Boev <rinsvind@gmail.com>
2018-06-01Bug 512407 - Let's dump 'ie.wombat.jbdiff' and related from GitI20180601-0915I20180601-0900Alexander Kurtakov48-2072/+5
repository Never have been published in our repo so safe to remove. Removed parts that used it but these bundles are not in the repo also so safe again. It is sure that if/when jbdiff is really used it should be added to Orbit and used proper instead of keeping it's source in our repo. Change-Id: Iac3cccd08d3019d70d1d18632a761d20bad444b8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-30Bug 535327 - Streamline maven poms hierachyI20180531-2125I20180531-2000I20180531-1245I20180531-0910Alexander Kurtakov50-178/+178
Needed so tycho-versions:set-versions works properly. Not all modules handled properly but majority are which is good enough for me now. Change-Id: I62d65744ed65d083f3755aab86b925fa780092b5 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-12Bug 534597 - Unanticipated comparator errors in I20180511-2000I20180515-0800I20180514-2000I20180514-0800I20180513-2000I20180513-0800I20180512-1500I20180512-0830Sravan Kumar Lakkimsetti8-0/+8
Change-Id: I81a22fab41385acd21a618ae41031e372a9387a6 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-05-02More try-with-resources in simpleconfigurator.S4_8_0_M7I20180511-2000I20180509-2000I20180509-0800I20180508-2000I20180508-0800I20180507-2205I20180507-2000I20180507-0810I20180507-0800I20180506-2000I20180506-0800I20180505-1500I20180504-2000I20180503-2000I20180503-0740I20180502-2000Alexander Kurtakov2-31/+11
Change-Id: I1e45a9d05e0c31b4b0e727310d2af56cef670bdf Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-02Make TarFile implement closeable.Alexander Kurtakov2-7/+5
And deal with it using try-with-resources. Change-Id: I0389ab78f2aefe157378f2378f39564deee0c125 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-02Try-with-resources and foreach in ConfigApplier.Alexander Kurtakov1-60/+43
Change-Id: I07351432b084b58a9dd1ef4ff907779d2c743a08 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-02Translate comment from French to EnglishMickael Istria1-1/+1
Change-Id: I21e7779bcfb7118ca6be1d48a8b7d16ed8aa7752 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-05-02Bug 534261 - Removed PackageAdmin from the p2 director applicationTodor Boev1-30/+5
Change-Id: Ic11776d49525dfc7968f09cae79ceb5179178046 Signed-off-by: Todor Boev <rinsvind@gmail.com>
2018-04-30Foreach and efficient Map traversal changes.I20180502-0100I20180501-2000I20180430-2000Alexander Kurtakov9-96/+232
Change-Id: I27e76c54d54a7c9d22aec5a124db6f11b7bc6444 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-25Update test reconciler product.I20180430-0715I20180429-2000I20180428-2020I20180428-1500I20180427-2000I20180426-2000I20180426-0500I20180425-2000I20180425-1705I20180425-1650I20180425-1455Alexander Kurtakov1-3/+14
Let it run the reconciler app instead of workbench. Add all required plugins. Change-Id: Icc15f4953f821592d596c4bd10f748d36c88cb3a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-25Add bundle vendor to o.e.equinox.frameworkadmin.test bundle.Alexander Kurtakov3-2/+17
And externalize the strings. Change-Id: I746bf1f6f437f517007bfc8b60af1bbad9e94940 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-25Remove unused method.Alexander Kurtakov1-27/+2
That causes import of deprecated PackageAdmin. Change-Id: Idb36c049f672d9b8cb17f1fe818c73372133fc4b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-25Cleanups.I20180425-0910I20180425-0725Alexander Kurtakov8-35/+31
* Foreach conversion. * Removed useless non-javadoc comments. * Use isEmpty. Change-Id: I86a3291f3abf30a8dee2b4a4c008978b24ec75d3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-25Touching reconciler product after move to Tycho 1.2.0I20180425-0505Sravan Kumar Lakkimsetti1-0/+1
Change-Id: I7ac3fbc380298c2462abe4c84702a16d2bfe9c54 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-04-18Bug 533758 - Direct use of IStructuredSelectionI20180425-0250I20180424-2000I20180423-2000I20180423-0655I20180423-0640I20180422-2000I20180421-1500I20180420-2000I20180419-2000I20180418-2000Alexander Kurtakov13-31/+46
Instead of getSelection and cast. Enable save actions to auto remove useless casts. Change-Id: Ie9fd9546ac74d146a9fa219e37d012d7a3e79415 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-16Bug 533617 - NLS missing message warnings since 4.8 M6I20180417-2000I20180416-2000Alexander Kurtakov2-0/+5
Restore MD5 error messages. They are still used in deprecated code but were errorneously removed. Change-Id: Ibf3c499075b710f640032605cf3f8d9d90b3f6bf Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-13Bug 533117 - setRepositoryProperty: fixed regression when value is nullI20180416-0305I20180415-2000I20180414-1500I20180413-2000Karsten Thoms1-3/+8
A null value should remove the entry from the repositoryProperties. But when repositoryProperties is not initialized a null value was actually added for the key. Changed conditions to first prove wether value is null and only remove the property, when field repositoryProperties is initialized. Set field to null when the last entry was removed. Change-Id: I766094f09d24bcf3c0da093202724ab5c2f0e417 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-04-09Bug 527874 - Remember failed repositories on load requestI20180412-2000Karsten Thoms1-20/+41
When a loading a repository failed once, its location is remembered to early exit on subsequent load requests. Multiple requests can happen e.g. during Check for Updates action. Change-Id: I56258d50523d95dff84ef4153bfc687f3bf80355 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-03-27Bug 532923 - Copyright property page does not resizeI20180411-2000I20180411-0735I20180411-0530I20180410-2000I20180409-2000I20180408-2000I20180407-1500I20180406-2000I20180405-2000I20180404-2000I20180403-2000I20180402-2000I20180401-2000I20180331-1500I20180330-2235I20180330-2000I20180329-2000I20180329-0000I20180328-2000I20180327-2000Michael Keppler1-1/+1
Let the main label control grab the horizontal excess space to resize with the property page. The same flag was already set for the nearly identical license property page. Change-Id: I7067f24bec245bc28a825630ad591b35b09306fa Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Bug:532923
2018-03-20Bug 531345 - Publish product osgi.ee requirement according to <vm>I20180327-0805I20180327-0630I20180326-2000I20180325-2000I20180324-1500I20180323-2000I20180323-0355I20180322-2000I20180322-0645I20180322-0225I20180321-2000I20180320-2000Mickael Istria5-48/+142
Use the EE defined in the <vm> node of product definition to define some osgi.ee capability requirements in product metadata. Add tests to make sure JRE is still included while unit isn't directly referenced by product requirements. Change-Id: Ic2bd5c30215e9936201c70f7268e5c6068979405 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-20Bug 532652 - MetadataFactory.createRequirement ignores descriptionEd Merks1-1/+1
Change-Id: Ie6f6c2ca6abad2d60c1cdbc18c085d60bf7b704d Signed-off-by: Ed Merks <ed.merks@gmail.com>
2018-03-12Bug 532118 - Eliminate exception when checking if buffer is full in ↵Mykola Nikishov1-6/+4
MessageDigestProcessingStep There is common wisdom behind the claim that throwing exception may hurt performance but I have no real numbers to say it will have real impact in this case. However, in this case it is easy to avoid exception by explicitly checking if the buffer is full before putting new data into it. Change-Id: Ifbd178aff4f943c31772aa357ee8369efcee558f Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-03-12Bug 532118 - Reduce number of calls to java.security.MessageDigest.update(byte)Mykola Nikishov3-36/+80
MD5Verifier and ChecksumVerifier are responsible for calculating artifact's checksum and must extend ProcessingStep to fulfill API requirements. ProcessingStep is effectively an unbuffered OutputStream with a method to process a single byte of artifact's data. In respect to MessageDigest, this means updating digest with every new single byte of data. So, for 16 Kb of data, both classes will call MessageDigest's update(byte) 16K times while only 1 call is enough. Introduce MessageDigestProcessingStep that accumulates incoming bytes in the internal buffer and immediately forwards them to the destination stream. As soon as buffer is full, it will update MessageDigest. AbstractBufferingStep could be used as a base class instead but it is too risky to adapt it. java.nio.ByteBuffer fits the bill almost ideally. One caveat is it communicates 'buffer is full' by throwing BufferOverflowException. There are no specific reasons for buffer's size of 16K except an assumption that it should not cause any problems: installing 1000 artifacts with 2 checksums per artifact would increase memory footprint for about 3200K. Similar approach has been used already [1], [2], claiming 5x speedup. This should make [3] less of a problem. [1] 5b2f061cd8ecf96a37783657e7ee7a0110c9d26d [2] Bug 405716 [3] Bug 532036 Change-Id: I1ba0d36267b3f07103c22b93f92c41765e33c8cc Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-03-09Bug 519085 Reduced memory consumption of SimpleArtifactDescriptorI20180312-2000I20180311-2000I20180310-1500I20180309-2000Karsten Thoms2-8/+34
Also of OrderedProperties by interning keys. Change-Id: Ic86797dd633b0537e99d86aad89de26f1c80e497 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-03-09Bug 448789 - Improved error logging for remediationOperation null refKarsten Thoms1-2/+8
Avoids the NPE as reported in the bug and logs the situation. Change-Id: I4ea13466ec7c764b6d75c9b28c0cba57fc75c301 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

Back to the top