Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/bundles/org.eclipse.equinox.p2.repository/src/org
AgeCommit message (Collapse)AuthorFilesLines
2022-02-15Bug 578322 - Provide a more flexible mechanism for managing and locatingY20220223-0600Y20220222-1350Y20220221-0600Y20220220-0600Y20220219-0600Y20220218-0600Y20220217-0600Y20220216-0600Y20220215-0600S4_23_0_M3I20220223-0600I20220222-1800I20220222-1350I20220221-1800I20220221-0600I20220220-1800I20220220-0600I20220219-1800I20220219-0600I20220218-1800I20220216-1800I20220216-0600I20220215-1800I20220215-0600Ed Merks1-21/+23
PGP public keys Delegate to DefaultPGPPublicKeyService.getLocalKeyCache(long) when looking up a key so that even without a key server or when offline, previously cached keys can be found if present in the local cache. Change-Id: If45f9871bdaf7507370e0170d49392c2fc356f1c Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/190804
2022-02-13Bug 578024 - Improve the TrustCertificateDialogI20220213-1800Ed Merks2-2/+14
Generally use lower case hex fingerprints everywhere. It's just easier on the eyes and is generally what the keyservers show as well. Change-Id: I7d5526332be58fc8ea5de98ac9fc9c212d254f93 Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/190750
2022-02-08Bug 578024 - Improve the TrustCertificateDialogY20220209-0600I20220208-1800Ed Merks1-0/+96
Introduce org.eclipse.equinox.p2.repository.artifact.spi.IArtifactUIServices optionally implemented by UIServices implementations for enriched information that includes information about the artifacts associated with certificates and keys. Ensure that the new interface can delegate to older UIServices implementations. Upgrade CertificateChecker to compute the more detailed information and that it uses IArtifactUIServices when available, but also works properly when it's not available. Update ValidationDialogServiceUI so that it implements IArtifactUIServices and uses the enhanced information when available. Completely overhaul the TrustCertificateDialog implementation. Change-Id: I268bc7176af3eeb98b1d38a47b92d525f9b9f285 Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/190518
2022-02-05Bug 578232 - Improve the trust preference pageI20220205-1800Ed Merks1-1/+1
Differentiate between the keys trusted by the user and stored in profile preferences versus the ones contributed by the extension point. The latter are not removable and should provide information to the user about which bundle contributed those keys. The preference page handles multiple selection better, enables the Remove button only when at least one of the selected keys is contributed from the preferences, and enables the Export button if one or more keys are selected. It uses a TableColumnLayout so that the user can see all the information more easily. When keys are added, the newly added keys are selected so that you know what you added. The Restore Default button will reset the state to what it was when the page was first opened. The file dialogs that open remember their location in the dialog settings so that it's easier to add/export multiple keys. They default to user.home folder. The description message is made more concise. The items are sorted for a more consistent presentation; items from the preference store come first. Change-Id: I3c520b40fb8940a2ed02dde0376f6d5535f50c45 Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/190452
2022-02-02Bug 578322 - Provide a more flexible mechanism for managing and locatingY20220203-0600Y20220202-0910I20220203-0300I20220202-1800Ed Merks4-1/+1124
PGP public keys Provide org.eclipse.equinox.p2.repository.spi.PGPPublicKeyService and its default registered implementation DefaultPGPPublicKeyService that supports network access to zero or more key servers with offline caching, caching of all locally added keys, and access to keys in the GPG pubring. Extend ValidationDialogServiceUI to make it aware of the agent such that it can access the PGPPublicKeyService to provide web-of-trust details to the user. Ensure that PGPPublicKeyStore properly handles multiple keys per key ID. Provide access to the target artifact descriptor via SimpleArtifactRepository.ArtifactOutputStream.getAdapter so that the special case handling of PGP properties in MirrorRequest.getDestinationDescriptor can be moved to PGPSignatureVerifier.close() to ensure that signatures and the keys used to verify them follow the artifact during a mirror request. Simplify CertificateChecker such that it expects the keys used for signature verification to be present in the artifact properties. Ensure that PGPSignatureVerifier can deal with multiple keys with the same key ID. Also verify key expiration (log a warning) and key revocation (abort the download), guarded by system properties p2.pgp.verifyExpiration and p2.pgp.verifyRevocation to disable the checks. Fix TrustPreferencePage to store keys in a file based on the fingerprint rather than the key ID and to present to the user the fingerprint rather than the key ID. Add a .options file to provide access to the debug/tracing options. Change-Id: I8c50ce886b9af175db129c7508774d00972a0432 Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/189910 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-10-06Bug 576428 - Log warning repo uses unsafe (eg http) protocolI20211007-0350I20211006-1800Mickael Istria3-8/+17
Change-Id: Ibbdd4e8e3905458c2414c8250ce7f473c7a185c7 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/186159 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-08-13Bug 565091 - 'Refresh' in 'Available Update Sites' has no effect onSebastian Ratz1-2/+10
Composite's children Change-Id: I4fdbcb55c5d58609ac38df8f172282a1171b1a5d Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/166057 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-07-23Use StringBuilder in XMLWriterI20210725-1800I20210724-1800I20210723-1800Lars Vogel1-2/+2
Done with JDT UI cleanup action. Change-Id: I3b3a3c01105987fb4b80a452d2d0cb95597cd0c6 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/183163 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-13Bug 574173 expose hard coded RepositoryPreferences as system propertiesY20210614-0420I20210613-1800Andrey Loskutov1-7/+26
Allow to use following system properties to configure RepositoryPreferences: p2.RepositoryPreferences.retryOnSocketTimeout (default is false) p2.RepositoryPreferences.connectionRetryCount (default is 1) p2.RepositoryPreferences.connectionMsRetryDelay (default is 200) Change-Id: I9340493bb6e88a706fcd94662a92e82ecc4fb76b Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181876 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-03-29P2 should honor retry property on time outs for repository metadataI20210329-1800Laurent Goubet2-2/+28
Bug: 520461 Signed-off-by: Laurent Goubet <laurent.goubet@obeo.fr> Change-Id: Iaa96aea34026c6cd1c539f651ff3d6aef7ca168a
2021-03-19Bug 572043 - Deprecate pack200 support for removalI20210319-1800Alexander Kurtakov1-23/+24
Mark for removal and annotate with pde.apitools so projects start seeing the future breakage and act on it. Change-Id: I947650999c584bb70356859a94e8124eb5441775 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-10-13Remove useless code.Y20201014-1200Y20201013-1200I20201014-1800I20201013-1800Alexander Kurtakov1-5/+2
Change-Id: I32c89ba1f46a2ad9be9faa9e84e8858f47bb1ba3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-16Bug 567030 - Reduce UnsupportedEncodingException in the codebaseAlexander Kurtakov1-17/+2
Handle p2.repository bundle. Change-Id: I308e403e0c9aa17398fa6012a26adfa1eabf9fc3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-13Bug 477007 - Do not use white space in XMLY20200825-1200Y20200824-1310Y20200823-1200Y20200822-1200Y20200821-1200Y20200820-1200Y20200819-1200Y20200818-1200Y20200817-1210Y20200817-0450Y20200816-1200Y20200815-1200Y20200814-1200Y20200814-0650Y20200814-0630Y20200813-1200S4_17_0_RC1S4_17_0_M3I20200828-0150I20200826-1800I20200826-0600I20200825-1800I20200825-0600I20200824-1900I20200824-0600I20200823-1800I20200823-0600I20200822-1800I20200822-0600I20200821-1800I20200821-0440I20200820-0230I20200819-1800I20200819-0600I20200818-1800I20200818-0900I20200818-0600I20200818-0340I20200817-1800I20200817-0920I20200817-0600I20200817-0450I20200816-1800I20200816-0600I20200815-1800I20200815-0600I20200814-1800I20200814-1040I20200814-0640I20200814-0330I20200813-1800Alexander Kurtakov1-12/+12
Switch the opt-out useWhitespace to opt-in ignoreWhitespace. Change-Id: If971295794f033041284016fbc64795c1448a4ef Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-07-01Bug 477007 - Do not use white space in XMLAlex Blewitt1-7/+25
Writing and reading XML white space is unnecessary from a programmatic point of view, and increases the size of compressed and decompressed files. Given that the repository sizes can be quite large removing the white space at creation time will save download and decompression memory bandwidth. Removing white space from the artifacts.xml file results in around a 10% space saving before compression. Change-Id: If93e38ca9c185e811952f5510ff28f000eadf130 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2020-01-10Use System.lineSeparator()Y20200114-0045I20200113-1800I20200113-0130I20200112-1800I20200111-1800I20200111-0325I20200111-0230I20200110-1805Alexander Kurtakov1-1/+1
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: I2807af3be704e02cb541da6b579214cb13d6194e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-10-16Use jdk 5 for-each loopCarsten Hammer3-7/+8
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: Id71f030335f035816de194384d1a3c042a350886 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-10-02Use StringBuilder instead of StringBuffer where possible.Carsten Hammer4-8/+8
Change-Id: Ie756b6925b7dfc3471659764990c85d0e17eb1df Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-09-24Bug 551396 - Fix files that have ended up with CRLF in the gitI20190924-1800Ed Merks1-32/+32
repository Change-Id: Id4b41b08f3a4dc32130aa5b22c1d58118fba7a7c Signed-off-by: Ed Merks <ed.merks@gmail.com>
2019-07-16Remove useless non-javadoc comments.Alexander Kurtakov2-5/+4
Change-Id: Ifc2500a2a4cafd13addc6ebc50fda66ba82e2a1a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-07-08Bug 541781 - Support dynamically registered MessageDigest implementationsY20190715-2335Y20190715-0900I20190715-1800I20190714-1800I20190713-1800I20190713-1105I20190713-0230I20190712-1800Mykola Nikishov3-8/+26
Extend o.e.e.p2.artifact.repository.artifactChecksums extension point with attribute providerName to support custom MessageDigest implementations as per Java Security API. To get an instance of custom MessageDigest in ChecksumProducer's getMessageDigest(String, String), look for service object under java.security.Provider interface filtered by providerName property and pass it to java.security.MessageDigest's getInstance(String, Provider). Throws NoSuchProviderException if no such service was found. Bundle that contributes such implementation should register it with the Framework service registry under interface java.security.Provider. The registration properties of the service should contain property 'providerName' with value of type String as returned by implementation's java.security.Provider.getName(). The same value should be used for providerName attribute in artifactChecksums extension point. o.e.equinox.p2.artifact.checksums.bouncycastle bundle demonstrates how this works by adding support for Whirlpool and DSTU7564 message digests using the Bouncy Castle Crypto APIs [1]. It is not part of the distribution and used by unit tests only. [1] https://bouncycastle.org/ Change-Id: I0cfd06ceca6e1911d69bab09331399500a00dcee Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2019-07-01Convert to the generic IProvisioningAgent.getService()Y20190705-0620Y20190704-0900I20190704-1800I20190704-0245I20190703-1800I20190703-0640I20190702-1800I20190702-0930I20190702-0610I20190701-1805Alexander Kurtakov4-64/+63
Take 2. Change-Id: Ia6b32d8b27efbf30d7d7bd620c84e0b9e48f843a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-06-11Use switch over strings where possibleI20190620-1800I20190620-0130I20190619-1820I20190619-1800I20190618-1805I20190618-0225I20190617-1800I20190616-1800I20190615-1800I20190614-1800I20190614-0330I20190613-1800I20190613-0210I20190612-1800I20190612-0115Carsten Hammer2-29/+49
Change cascades of ifs which can be converted to switch over Strings. Change-Id: Id86536ada5cc4a916fbd5aa31123d1b45d7b5225 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-10Remove unnecessary type specificationsCarsten Hammer10-20/+20
Since Java 7 the diamond operator can be used instead of explicit type parameters. Change-Id: I1f4692522a6ed6429f79eea1d898f0cc4a84131a Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-03-18Bug 545330 - Problems in javadoc for platformI20190325-1800I20190325-0105I20190324-1800I20190323-1800I20190322-1800I20190321-1800I20190321-0435I20190321-0245I20190320-1800I20190318-1800Alexander Kurtakov3-10/+12
Fix p2 javadoc warnings. Change-Id: I4f9cd9c79917a70f9b69e75557d6a137cfaa1473 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-16Add missing Override/Deprecated annotations to p2.repository bundle.Alexander Kurtakov16-106/+129
Change-Id: Iec7809dcb1596a843bbc5c8a3b82201b4f15f985 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-15Bug 543933 - Build javadocs with Java 11Y20190222-0110Y20190220-2200S4_11_0_M3I20190220-1800I20190220-0600I20190219-1800I20190219-0600I20190218-1800I20190218-0600I20190217-1800I20190217-0600I20190216-1800I20190216-0600Alexander Kurtakov8-8/+8
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I06b05f4c190658ed8c8d79b1e1d33ac534f1adb3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-10-05Reuse ChecksumHelper.MD5 constantI20181008-0600Mykola Nikishov1-1/+1
Change-Id: Ic011655240f2772e9356ab5a17e8a54eb3700236 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-03Fix typo in IArtifactDescriptor.*_CHECKSUM javadocsMykola Nikishov1-2/+2
Change-Id: I41c5af886d3cb354aa61a77a39e852adfbe6160b Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-08-22Bug 535802 - Update p2 EPL-2.0 for its plug-ins - Part 3Lars Vogel52-156/+312
Change-Id: I7b922fdd409b7f004a77cf1d662a72034bd18a58 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-22Adds linebreak before the EPL 1.0 licenceLars Vogel2-2/+4
Change-Id: Ic1638772d5f58d4567a83b519ecd885b80f5602b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-22Fixes incorrectly formated EPL 1.0 license headerI20180822-0800Lars Vogel2-2/+4
Change-Id: I6337f0a9e32e7eb71ba6e368137e180a456bb8da Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-03-08Bug 532190 - Buffered writingKarsten Thoms1-1/+1
Change-Id: I4630b8206e2f404573ea0fe971eb21e1aae49832 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-03-02Bug 423715 - Fix since tagsI20180304-2000I20180304-0800I20180303-1500I20180303-1200I20180303-0800I20180303-0335I20180303-0155I20180303-0055I20180302-2000Alexander Kurtakov1-2/+2
Change-Id: I8a5532c9ef2a12cc13e125b1545b466472ec4e0c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-02Bug 531917 - Remove redundant type parametersAlexander Kurtakov2-7/+7
With Java 8 and properly generified some apis it's not needed to specify the types anymore. Change-Id: Ib758c6f50b1b1fd3f56bd52eb7e664b89b6cc776 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-01Bug 423715 - Support multiple algorithms for artifact checksumsI20180301-2000Mykola Nikishov3-29/+133
Developer of p2-based software should be able to check integrity of artifact checksums using any MessageDigest implementation available, at his own discretion, without ever touching p2 internals. For the purpose of this bug, limit enabled checksum algorithms to: - MD5 (legacy one, deprecated now, for backward compatibility only) - SHA-256 (more collision-resistant than MD5) See artifactChecksums.exsd for more details. First, encode ID of the checksum algorithm into the name of the property itself so that artifact descriptor now may look like: <artifact classifier='binary' id='testKeyId' version='1.2.3'> <properties size='6'> <property name='download.md5' value='b3788632488d48b850255acf68669651'/> <property name='artifact.md5' value='b3788632488d48b850255acf68669651'/> <property name='download.checksum.sha-256' value='d594816b995d1689c2dfc97dc244859abe6bdb9ebeb4b396e401afd85a97ee16'/> <property name='download.checksum.whirlpool' value='e4f3ece3d3f289cc2686a68f0b1b5a2d03da3a8ccdc3cd6d03209e4c789af724c8fa915bb890079e1abe78df44875cec132885dd6ae1176eed7938dfb3c7b551'/> <property name='artifact.checksum.sha-256' value='d594816b995d1689c2dfc97dc244859abe6bdb9ebeb4b396e401afd85a97ee16'/> <property name='artifact.checksum.tiger' value='462a72a1a593b9e2de8721b8d79335fd03e974f2e2e1f35a'/> </properties> </artifact> Prefix helps to avoid conflicts with other, not checksum-related, properties. To find checksums of specific type, we need all properties with prefix 'artifact.checksum.', Extracting checksum id from the name of the property is also trivial. Store these prefixes in IArtifactDescriptor's DOWNLOAD_CHECKSUM and ARTIFACT_CHECKSUM. ChecksumUtilities provides internal API to deal with properties. Second, map ID of checksum algorithm to the name of MessageDigest implementation with a contribution to a new extension point org.eclipse.equinox.p2.artifact.repository.artifactChecksums: <extension point="org.eclipse.equinox.p2.artifact.repository.artifactChecksums"> <artifactChecksum algorithm="SHA-256" id="sha-256" ... /> </extension> Number of actual checksums in artifact descriptor depends on the configuration of the application that created such descriptor because p2 will: - handle MD5 checksums as usual, preserving backward compatibility - calculate other checksums using extensions that contribute to artifactChecksums extension point Last, we use id of specific checksum to get MessageDigest instance with getInstance(String). There is a number of standalone applications (like MirrorApplication) and Ant tasks (like ValidateTask) that allow user to chose specific comparator by id and ArtifactComparatorFactory is responsible for instantiating it. Legacy MD5 comparator requires no special configuration while the new ArtifactChecksumComparator is more generic and needs some parameters to instantiate. ArtifactComparatorFactory handles this by accepting fake comparator id - concatenated ArtifactChecksumComparator's id and checksum algorithm id. In other words, to compare artifacts using SHA-256 algorithm use 'org.eclipse.equinox.artifact.comparator.checksum.sha-256' as comparator id. We generate, consume and compare artifact checksums using all enabled algorithms. Ideally, configuration options should provide more control for both repository publisher and p2 client like: - a priority (compare with SHA-512 first, then SHA-256 and, finally, MD5) - skip specific checksum (do not use MD5 even if provided) - mandatory checksum (require Whirlpool and it's an error if its not available) While I have no good solution for this right now, there are some configuration options provided. Also, number of new enabled checksum algorithms is limited to SHA-256 only (more checksums = more reasons to fail = more reasons to disable). To turn checksum verification off completely: - for p2 client, use property 'eclipse.p2.checksums.disable' (see SimpleArtifactRepository.CHECKSUMS_ENABLED constant). - for p2 publisher, the old PublisherInfo's setArtifactOptions(int) and IPublisherInfo.A_NO_MD5 still could be used. To disable MD5 checksums only, existing properties 'eclipse.p2.MD5Check' and 'eclipse.p2.MD5ArtifactCheck' still can be used. Change-Id: Iacd267e13d5d096694001d34cafbaea5451e7157 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-02-15Bug 507657 - Refactor AbstractRepositoryManager's loadIndexFile(URI,I20180219-2000I20180218-2000I20180217-1500I20180216-2000I20180216-0415I20180215-2000Mykola Nikishov1-26/+25
String, IProgressMonitor) - extract methods to load local and remote p2.index file - rename method isURL to isInMemoryRepository and drop explanation on the caller's side Change-Id: I9558d1746b4f4433a63040ab8c9cae18da4a6bdd Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-01-30Bug 530526 - Don't use deprecated Number children constructorsAlexander Kurtakov1-4/+4
Deprecated in Java 9 but the replacment methods are here for long time. Change-Id: I645d66492831a95d27f61bc443c8896d73440579 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-22Revert "Revert "Bug 528387 - Dedicated xml elements for genericI20180122-2000Alexander Kurtakov2-14/+84
requirements"" This reverts commit 0e3caa9359428dcb20c1dc3a2c580fff64777d3d. Change-Id: Ifafe2feedb963b90f54a19b2e08a49d3b18d475a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-22Revert "Bug 528387 - Dedicated xml elements for generic requirements"Thomas Watson2-84/+14
This reverts commit a7a99e1fa49938a8f62d44d5c443d38981afeace.
2018-01-16Bug 528387 - Dedicated xml elements for generic requirementsI20180119-0110I20180118-2000I20180117-2000Todor Boev2-14/+84
- Renamed IProvidedCapability.getAttributes() to getProperties(). This is in sync with other parts of p2 that use "properties" for such data. E.g. the IU properties. - Extended content.xml read/write with a new serialization format for requirements with the "requiredProperties" element. It is used to build an IRequirement that has a standard match expression that applies an LDAP filter to the capability properties. It was not possible to extend the existing "required" element in a way that will make old p2 builds ignore the extended version. - Extended the content.xml read/write shared properties handling logic with "type" attribute. Older p2 builds will ignore it and use strings. Also the "type" attribute only appears in the "properties" extension of "provides" which will be ignored by old p2 builds to begin with. - Some additional cleanup to the content.xml read/write - Increased the current content.xml format version from 1.1.0 to 1.2.0. Old p2 builds declare compatibility with [1.0.0, 2). - Made the handling of the property types supported by a capability safer. E.g. unknown types are converted to Strings. E.g. ProvidedCapability verifies that only supported types are used. - Made the handling of generic requirements reflect the real semantics. E.g. with correct handling of the resolution:=optional|mandatory flag rather than to declare everything optional to avoid breakages in older p2 builds. This is possible because the "requiredProperties" element is completely ignored by older builds. E.g. now if an extender or service is missing provisioning will fail as it is supposed to. - Added factory methods to MetadataFactory for LDAP based requirements. - Added a planner test for LDAP requirements - Cleaned up the AutomatedDirectorTest - Cleaned up some LDAP matching test cases. Change-Id: Ifff77b3ea4c9cea33fd236ed101b1f33c173891d Signed-off-by: Todor Boev <rinsvind@gmail.com>
2018-01-05Fix unnecessary else clause warnings.I20180111-0530I20180110-2000I20180110-0100I20180109-2000I20180108-2000I20180107-2000I20180106-1500I20180105-2000Alexander Kurtakov1-3/+2
Change-Id: I516845d1732386a34d3078aa111cbd5b306b76c5 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-09-05Bug 521298 - Enhance deprecation messages in AbstractArtifactRepository I20170906-0225I20170905-2000Alexander Kurtakov1-1/+1
Fix @link to point to existing method. Change-Id: Ia440f5bc3782582549b96d4e836a4e4b29d5bf5c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-31Bug 518031 - XML External Entity Vulnerability in Eclipse IDEI20170904-0230I20170903-2000I20170902-1500I20170901-2000Brian de Alwis1-3/+9
Ensure XML processors are configured to use XMLConstants.FEATURE_SECURE_PROCESSING=true to avoid accessing external DTDs and expanding external entities. Change-Id: Ic29e4a0aab1ea5f642ce49914bc6fcecd238efe8 Signed-off-by: Brian de Alwis <bsd@mt.ca>
2017-08-23Bug 521298 - Enhance deprecation messages in AbstractArtifactRepository Alexander Kurtakov1-8/+8
Remove dubious comments and add messages to the deprecation tags pointing to the replacement methods. Change-Id: I24780e83ccf5cba61ca4c92b138f93c9a516d24f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-27Bug 514885 Pooling Version and VersionRangeKarsten Thoms1-1/+1
- Introduce weak object pool for Verson and VersionRange - Use VersionRange.create() for getting pooled instances - JavaDoc & check input for empty string Change-Id: Ie42bdc1059d8c667af312038c26c035a6ef674af Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-06-21Bug 518574 - Use StandardCharsetsAlexander Kurtakov2-11/+10
Bump BREE to 1.8 for bundles that were too low to have StandardCharsets. Change-Id: Iac9e9615c5179b970df893182f5f1c6e3dd4d574 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-04-05Bug 514807 - [memory] Use EMPTY_STEPS always for empty processingStepsKarsten Thoms1-2/+2
Change-Id: I829ded8e6a6cf5c10a30508d00710d1af56e3e79 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-04-03Fix javadoc on return value of LocationProperties's ↵I20170405-0300I20170405-0200I20170405-0130I20170404-2000I20170404-0840I20170404-0245I20170403-2000Mykola Nikishov1-1/+1
getArtifactFactorySearchOrder() Change-Id: Idc31cf4e6dbc1beea5b027604d5a2a980c060dff Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2017-03-29Bug 509401 - Don't hide I/O problems in ChecksumProducer's computeMD5(File)Mykola Nikishov1-5/+6
If caller doesn't care about I/O problems during checksum calculation, neither should computeMD5 method. The only two callers, RecreateRepositoryApplication and PublisherHelper, now catch such exceptions (to preserve original behavior) and log them to make troubleshooting easier. Change-Id: I1e82ac45cc958f4ffc3ed969a50cfa68aec3c8fc Signed-off-by: Mykola Nikishov <mn@mn.com.ua>

Back to the top