Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2018-04-09Bug 527874 - Remember failed repositories on load requestI20180412-2000Karsten Thoms1-20/+41
When a loading a repository failed once, its location is remembered to early exit on subsequent load requests. Multiple requests can happen e.g. during Check for Updates action. Change-Id: I56258d50523d95dff84ef4153bfc687f3bf80355 Signed-off-by: Karsten Thoms <>
2018-03-02Bug 531917 - Remove redundant type parametersAlexander Kurtakov7-17/+17
With Java 8 and properly generified some apis it's not needed to specify the types anymore. Change-Id: Ib758c6f50b1b1fd3f56bd52eb7e664b89b6cc776 Signed-off-by: Alexander Kurtakov <>
2018-01-30Bug 530486 - Remove useless thrown exceptions.I20180130-2000Alexander Kurtakov2-5/+4
Change-Id: Ieb5178a2eecbeaab88afd5e00bc3806bc615c7ae Signed-off-by: Alexander Kurtakov <>
2017-08-18Bug 521114 - Move p2 engine to Java 8Alexander Kurtakov2-21/+3
Bump minor version, try-with-resources, remove duplicate type declarations. Change-Id: I33bc01cfef2272e444614f92fb4fcc313bffbe91 Signed-off-by: Alexander Kurtakov <>
2017-07-03Bug 512312: Droplets should correctly detect feature group IUs.I20170703-2000Roland Grunberg1-2/+3
This issue has been mostly addressed by 7c95455. The logic for detection of feature groups was wrongly comparing a string and a boolean for equality as well as being computed more times than necessary. Change-Id: Icd714e39b798fba748d88c3aea2845649aa9fee1 Signed-off-by: Roland Grunberg <>
2017-06-27Bug 514885 Pooling Version and VersionRangeKarsten Thoms3-3/+3
- Introduce weak object pool for Verson and VersionRange - Use VersionRange.create() for getting pooled instances - JavaDoc & check input for empty string Change-Id: Ie42bdc1059d8c667af312038c26c035a6ef674af Signed-off-by: Karsten Thoms <>
2017-03-19Bug 513790 - Compiler warnings in I20170316-2000 after moving to M6I20170328-2000I20170327-2000I20170326-2000I20170325-2000I20170324-2000I20170323-2000I20170322-2000Andrey Loskutov2-5/+8
compiler Change-Id: I3de8ff54e4efc354443ab2d99fd75316f2abacbb Signed-off-by: Andrey Loskutov <>
2017-01-10Bug 509473: Bump p2.engine and equinox.simpleconfigurator to JavaSE-1.7.Alexander Kurtakov43-216/+310
Enable some java 1.7 and older code style warnings and fix them: * Add missing @Override. * Remove redundant type declarations. * Remove useless non-javadoc comments. Change-Id: If80ea62f65204cad77275e07fee096a276d35c5c Signed-off-by: Alexander Kurtakov <>
2017-01-09Bug 495012 - ProvisioningContext#setMetadataRepositories andLars Vogel1-3/+3
setArtifactRepositories should use varargs Change-Id: I917123d4225320c27cde4e7c05473f37d7f7e713 Signed-off-by: Lars Vogel <>
2017-01-09Bug 508905: Change File.canWrite to Files.isWritable for p2 Droplets.Roland Grunberg1-1/+2
For compatibility with Windows, use java.nio.Files.isWritable(Path) instead of This is due to the fact that canWrite always returns true for directories on Windows. - Enable all tests disabled on Windows by 416b782 - Introduce reallyReadOnly/removeReallyReadonly functions that operate recursively on a directory (like chmod -R on linux) since certain test cases require this Change-Id: I615dfdef60e4abd23c34602bd324c307325e00d4 Signed-off-by: Roland Grunberg <>
2016-08-30Bug 371970 - NPE atSergey Prigogin1-4/+20
org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry.lockProfile Change-Id: I789887493f8b5e3b601a6b00c8ec7928c77e85e3 Signed-off-by: Sergey Prigogin <>
2016-04-19Bug 489706 - Replace new Integer() with Integer.valueOf()I20160419-0800Alex Blewitt2-4/+4
There are a lot of new Integer() calls in the P2 codebase, which results in many duplicate values of Integer being stored, particularly when performing updates or checks. Integer.valueOf() performs this caching already, which means that it's unnecessary to call new Integer() and instead can call Integer.valueOf(). In the places where the int value is being used directly, the call can be further optimised to Integer.parseInt() instead. Replace calls to new Integer() with Integer.valueOf() or .parseInt() as appropriate. Change-Id: Ic760e66084c856fc90cb7c8a358007c975213638 Signed-off-by: Alex Blewitt <>
2016-01-02Bug 466249 - Propagate more exceptions to ease problem analysisEike Stepper2-5/+9
We often get problem reports with stack traces that "end" somewhere in p2 even though it's obvious from looking at these places that there was a causing exception. These causing exceptions are often not propagated with the new exception that p2 creates and throws. I'm not sure if that's on purpose or just an oversight. I've prepared a proposal to enhance these places and make it easier to analyze the problems that users report. Change-Id: Iaa53448c53c18301113b42dbe80558eccec49e8e Signed-off-by: Eike Stepper <>
2015-10-19Prevent NPE in DebugHelper's formatParameters methodI20151110-0800Mykola Nikishov1-1/+3
Change-Id: I816a68305ec086da8bfd9b7ec179ece6af35b52e Signed-off-by: Mykola Nikishov <>
2015-09-07Bug 476724 - Remove new Boolean and Boolean.valueOf().booleanValue()I20150929-0800I20150922-0800I20150916-2000I20150916-0800I20150915-2000I20150915-0800I20150914-2000I20150914-1545I20150914-1130I20150914-0800I20150913-2000I20150908-0800Alex Blewitt6-13/+12
The new Boolean constructor creates a new instance of a Boolean object, but it can easily be replaced with Boolean.valueOf which returns the reference to the global Boolean.TRUE or Boolean.FALSE. Replace calls to new Boolean() with Boolean.valueOf() for identical semantics except without object collection. Additionally Boolean.valueOf().booleanValue() is identical to Boolean.parseBoolean() and will result in no garbage. In addition, methods will be (slightly) smaller and parseBoolean will often be in-lined by the JIT, which can often prove that the value is non-null for faster checking. Replace Boolean.valueOf().booleanValue() chains with Boolean.parseBoolean(). Some other tests can use Wrapper.valueOf() to take advantage of the built-in caches that these objects maintain (for values in the range -128..127). Signed-off-by: Alex Blewitt <> Change-Id: I5da4216a26ffbb6b8fd3365515ee800dd82b36ae
2015-02-26Bug 460967 - Use type safe service retrievingI20150303-0800Alexander Kurtakov4-13/+16
Instead of retrieving services based on their String class name there is newer implementation that takes the class directly and returns the correct class preventing casts. Change-Id: I8b26f4d294b927f4c28a6ba4e68e35bd401df4ec Signed-off-by: Alexander Kurtakov <>
2015-02-02Bug 438714 - Expose whether a provisioning plan has operands or notI20150210-0800I20150203-0800Eike Stepper2-0/+11
This change adds a public isEmpty() method to IProvisioningPlan. Change-Id: Ib1eef3c306f524bc542cca0885b9b7e32c90d8a9 Signed-off-by: Eike Stepper <>
2014-05-06Bug 434225 - Use runnable repo to collect metadata.I20140511-2000I20140510-1500I20140509-2000I20140508-2000I20140507-2000I20140506-2000Roland Grunberg1-33/+29
Instead of parsing each fragment.profile individually and adding its metadata to the shared profile, use the metadata from the runnable repository as it should be identical. This allows us to eliminate 'fragment.profile' from the p2 Droplets format. Change-Id: I6b727e6433168a3527241a3d5de3ebbd09ff8db0 Signed-off-by: Roland Grunberg <>
2013-12-17Bug 422054: Create profile from existing bundles.infoI20131224-0800Krzysztof Daniel5-10/+248
I've hijacked the bug for the purpose of something that is remotely connected to the problem. Previous commit extends simpleconfigurator to load bundles from different locations, but such an extension breaks p2, as the content of OSGi application no longer corresponds to profile. In order to fix that, following things are done: 0. A fragment must contain valid P2 metadata next to the .info file. 1. User profile is dropped when there is master configuration change. Also, when fragments are changed. 2. When a new surrogate profile is created, P2 will add to the master profile all the units that are found in the fragments repos. Therefore new user profile will contain all the units that were installed by the simpleconfigurator. Fragment repos must be runnable. 3. The director application must be configured with extensions if it is supposed to work. Change-Id: I6e857ea51dd32ae7fab39d9c39bec8a91eb203b7 Signed-off-by: Krzysztof Daniel <>
2013-11-19Bug 422026 - Get rid of ColletionUtils.empty[Set|List|Map]Alexander Kurtakov3-7/+4
Now that p2 has Java 1.5 as a minimum there is no reason to not use the JVM methods. Change-Id: I89444e8d1e174c316e2b17fb4f53bc7b1d097c0a Signed-off-by: Alexander Kurtakov <>
2013-05-26Revert "Bug 408138 - Dropins are broken in after master configuration change"I20130526-2000Pascal Rapicault1-16/+0
This reverts commit e54bcf3357346b2223572bb4f352d49935674625.
2013-05-16Bug 408138 - Dropins are broken in after master configuration changeKrzysztof Daniel1-0/+16
First part of the fix. It reestablishes the connection between SimpleConfiguratorImpl and SimpleProfileRegistry, so when config.ini is modified, user profile is dropped even without timestamp change.
2013-04-08Remove unnecessary propertyPascal Rapicault (Ericsson)1-2/+0
2013-03-05API comment cleanupv20130305-154419John Arthorne2-2/+27
2013-02-28Remove unnecessary constant added in M5v20130228-212941Pascal Rapicault (Ericsson)2-2/+5
2013-02-05Rename variablev20130206-015153Pascal Rapicault (Ericsson)1-3/+3
2013-02-05Check for the presence of the agent registered propertyPascal Rapicault (Ericsson)1-4/+3
2013-02-05Bug 400011 - [shared][engine] Cleanup the SurrogateProfileHandler codePascal Rapicault (Ericsson)2-51/+5
2013-01-30Bug 399482 - Javadoc test failure: Problem in IProfilev20130130-151456Pascal Rapicault1-1/+1
2013-01-29Handle null when surrogate profile returns nullv20130129-212927I20130130-0800I20130129-2000Pascal Rapicault (Ericsson)1-0/+3
2013-01-29Bug 399406 -[engine] NPE in ↵Pascal Rapicault (Ericsson)1-1/+3
SimpleProfileRegistry.internalSetProfileStateProperty while selfthosing
2013-01-28Fix potential NPE when throwing exceptionv20130128-183545Pascal Rapicault (Ericsson)1-2/+2
2013-01-28Squashed commit of the following:v20130128-050843Pascal Rapicault (Ericsson)3-34/+139
304132 - [shared] upgrading shared base causes loss of user installer plug-ins commit 8461eae803454c36f6a18013c44e37c20810d141 Merge: 23bc40c c847dee Author: Pascal Rapicault <> Date: Sun Jan 27 22:11:45 2013 -0500 Merge branch 'master' into prapicau/sharedInstall-part1 commit 23bc40c4f85b01f37fb0ac23992524a7c8ccd892 Author: Pascal Rapicault (Ericsson) <> Date: Sun Jan 27 21:38:07 2013 -0500 Use constant and fix copyright header commit bc11d565b32b5b5c8bb5c93e5ea666b1d06b43ff Author: Pascal Rapicault (Ericsson) <> Date: Sun Jan 27 21:33:32 2013 -0500 Annotate new profile with a base profile timestamp commit ba4e7abda6e44ad47aead2fade320f9be08b27d5 Author: Pascal Rapicault (Ericsson) <> Date: Sun Jan 27 21:32:20 2013 -0500 Add constants commit 54c8d356527d1321e25bd837e674b758aa61e248 Author: Krzysztof Daniel <> Date: Thu Jan 24 13:23:15 2013 +0100 SimpleConfiguratorImpl refactoring and tests. commit 6177c466083fb7676ebfe5790bc0951043b3b727 Author: Pascal Rapicault (Ericsson) <> Date: Thu Jan 24 11:59:45 2013 -0500 detection of change in the reconciler commit f04f46d6d283a6235367872b5eaa7e3e483509ed Merge: 5243d49 c32f111 Author: Pascal Rapicault <> Date: Thu Jan 24 11:43:01 2013 -0500 Merge branch 'master' into prapicau/sharedInstall-part1 commit 5243d497142b0f2631bcda8b5fed67d7ce0ddbd5 Author: Pascal Rapicault <> Date: Wed Jan 23 15:26:41 2013 -0500 always use shared install when the ignoreUserConfig property is set commit 12eccdad23420e7ba91f99221c852f7e32eb11de Merge: c68f394 1e9fc23 Author: Pascal Rapicault <> Date: Wed Jan 23 10:29:56 2013 -0500 Merge branch 'master' into prapicau/sharedInstall-part1 commit c68f394a39c4215ed7ac960495a3c59eb3cf3eee Author: Pascal Rapicault <> Date: Tue Jan 22 22:24:04 2013 -0500 Bug 398853 - [UI] installed IU shows as update commit aa6d632dea7ff54e9ba7c3c7f9f2ecd30afe5906 Author: Pascal Rapicault <> Date: Tue Jan 22 13:50:05 2013 -0500 Differentiate initial profile creation from reset. commit 4fb3429ed3fd673d5daf7ca1ce9bf1184a0afcb3 Author: Pascal Rapicault <> Date: Tue Jan 22 13:49:23 2013 -0500 Only show migration dialog once commit a34eac29e330a41991d003e2dcd2d8b264d77145 Author: Krzysztof Daniel <> Date: Mon Jan 21 12:40:36 2013 +0100 397216: [Shared] Better shared configuration change discovery Perform dropins reindexing after master configuration had been changed. commit 6981ca8bd3c1db9ab2dd9484a1f7c8950fcd1abe Merge: dfec14b 33ca260 Author: Pascal Rapicault <> Date: Mon Jan 21 15:04:28 2013 -0500 Merge branch 'master' into prapicau/sharedInstall-part1 commit dfec14b67a69b6fa14efb860ef8a986053a58917 Merge: 6067d05 ba5f048 Author: Pascal Rapicault <> Date: Mon Jan 21 11:34:38 2013 -0500 Merge branch 'master' into prapicau/sharedInstall-part1 commit ba5f048a3ac5563430104adeb173dc4f7dda6eca Author: Pascal Rapicault <> Date: Mon Jan 21 11:28:20 2013 -0500 Bug 398539 - Got a NPE trying to add a new update site commit 6067d05e402fe796debd9d25604cae7026df5b48 Author: Pascal Rapicault <> Date: Fri Jan 18 16:16:18 2013 -0500 only write timestamp file for shared install commit 8ab9410d8c797e6a8d2a97e4ba46da3d548440fa Author: Pascal Rapicault (Ericsson) <> Date: Fri Jan 18 13:56:46 2013 -0500 Cache the fact that the is missing commit fefbc5bdec2ce6cdb7fd71b1790bf8abdee8737a Author: Pascal Rapicault (Ericsson) <> Date: Fri Jan 18 13:51:54 2013 -0500 Fix bug in change detection logic commit 3de6f8593d5c1b21be3bd21000e34acb945056b1 Author: Pascal Rapicault (Ericsson) <> Date: Wed Jan 16 19:50:32 2013 -0500 Detect changes in the commit 446649c95063dca689f4d2c886b26975a11f3499 Author: Pascal Rapicault <> Date: Tue Jan 15 14:04:57 2013 -0500 Simple notification to let the user know that the base has changed. commit e004dc5270abd33a60da9a8d0340409bc8e4a38d Author: Pascal Rapicault <> Date: Fri Jan 11 14:15:20 2013 +0100 ignore user config.ini if out of sync with base commit a0235c0c95b9047e64d6e24c9d8f6b8588087113 Author: Pascal Rapicault (Ericsson) <> Date: Wed Dec 12 09:57:36 2012 -0500 Obtain specific profile state properties without locking commit 1d0f129ca70716e7a181631e1ba0e71f16e35e08 Author: Pascal Rapicault (Ericsson) <> Date: Mon Dec 10 16:06:38 2012 -0500 Remember the timestamp of the base config.ini commit 3134caecfd244fd88386f3ce4bd1a6fc71fe8007 Author: Pascal Rapicault (Ericsson) <> Date: Wed Dec 5 16:21:50 2012 -0500 Support to ignore the existing profile if the base has changed commit 7f0ba4e643f40bc0143617b93b2238388d38216d Author: Pascal Rapicault (Ericsson) <> Date: Tue Dec 4 11:23:37 2012 -0500 Remove externalization warning
2013-01-20Null handling in the return valuev20130121-013257Pascal Rapicault2-7/+9
2013-01-19bug 397183 - initial support for lastResult variablev20130119-221347Pascal Rapicault5-14/+112
2013-01-19Remove undesirable dependency on security bundlePascal Rapicault3-4/+92
2013-01-04bug 397266 that can't cancel downloading if the cancel is raised in collect ↵v20130104-070547Mengxin Zhu2-10/+24
phase and before Collect.completePhase is called.
2012-12-28Bug 397231 - [engine] Memento should be initialized lazily v20121229-022937I20130101-0800Pascal Rapicault1-1/+3
2012-12-21Fixed p2 API tool warningsv20121221-190135I20121225-1600I20121225-0800John Arthorne1-0/+1
2012-11-16Rename constant and update copyright headersv20121117-034610Pascal Rapicault (Ericsson)3-7/+10
2012-11-16Bug 249133 - [shared] Default update site list blank in shared installPascal Rapicault (Ericsson)3-31/+144
2012-05-01Bug 378165 - p2.engine uses StringBuilder but states support forv20120501-1502I20120510-2100I20120510-1900I20120509-2100I20120509-1900I20120503-1800I20120503-1500I20120502-2000I20120502-1800I20120502-1500I20120502-1300I20120502-1000I20120502-0800John Arthorne1-7/+11
2012-03-01Bug 358842 pausing/resuming a p2 operation.v20120301-1523v20120301-0711Mengxin Zhu5-4/+84
Introduce new test cases that will download artifacts from Internet, so add vm arguments to make downloading more stable. Signed-off-by: Mengxin Zhu <>
2012-01-16364929 support customizable download statisticsv20120117-1140v20120117-0330Mengxin Zhu1-1/+7
Signed-off-by: Mengxin Zhu <>
2012-01-12316328 engine should be more verbose while performing an installationv20120112-1825Mengxin Zhu10-28/+312
1. the event of phase starts and finishes 2. download events, including how many artifacts to be downloaded, how many artifacts to be downloaded from a specific repository, the mirror request(download) result, download progress event(a wrapper of ProgressStatistics) 3. the events before/after configuring/unconfiguring an IU Signed-off-by: Mengxin Zhu <>
2011-09-18Add API to get the future state from a provisioning planv20110918-1950Pascal Rapicault2-0/+27
2011-08-30Remove invalid javadocv20110831-0232Pascal Rapicault1-3/+0
2011-08-30Bug 343706 - improve logging / error messages from CertificateCheckerPascal Rapicault2-3/+40
2011-06-28Bug 350380 - Java package can't install because of dependency on m2ePascal Rapicault1-2/+4
2011-06-12Bug 277919 - Profile registry complains on non-HFS volumePascal Rapicault1-1/+1

Back to the top