Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-21Bug 542960 - NPE in InitialSharedInstall's cleanupDotEclipseFolder() when ↵I20181222-1800I20181221-1800Mykola Nikishov1-3/+7
'~/.eclipse/' doesn't exist InitialSharedInstall's cleanupDotEclipseFolder() ensures that '${user.home}/.eclipse/' doesn't have directories/files which names start with 'p2.automated.test'. But it will throw NPE when the folder doesn't exist in the first place: setupRun(org.eclipse.equinox.p2.tests.sharedinstall.InitialSharedInstall) Time elapsed: 0.002 s <<< ERROR! java.lang.NullPointerException at org.eclipse.equinox.p2.tests.sharedinstall.InitialSharedInstall.cleanupDotEclipseFolder(InitialSharedInstall.java:72) at org.eclipse.equinox.p2.tests.sharedinstall.InitialSharedInstall.setupRun(InitialSharedInstall.java:49) In this case, make InitialSharedInstall's cleanupDotEclipseFolder() a noop. Change-Id: I4165609c644a6dde69c1d8ffe88138bf7ce16705 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-12-21Switch default target file to 4.11Mykola Nikishov1-1/+1
Change-Id: I6e3dc347a341bd0210480c9bf765d38769704b76 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-12-21Contribute MD5 via artifactChecksums extension point instead of MD5Verifier ↵Mykola Nikishov6-22/+115
processing step Since now, artifact checksums are verified exclusively by the combination of ChecksumVerifier processing step + contributions to artifactChecksums extension point. There are no more internal usages of MD5Verifier and it can be removed. But let it sit here for some time. ChecksumUtilitiesTest ensures that MD5 checksums from IArtifactDescriptor.ARTIFACT_MD5 and IArtifactDescriptor.DOWNLOAD_MD5 properties are still honored. Change-Id: Ib4bec48504c3b2f4296425f6d2e930e402b5b984 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-12-20Bug 536282 - Check whether processing step is availableI20181220-1800Mykola Nikishov10-16/+155
Extend ProcessingStep with isEnabled() method that checks if step's dependencies are available. ProcessingStepHandler's canProcess will ensure that all required processing steps are enabled and skip this check for optional processing steps. MirrorRequest's perform(IArtifactRepository, IProgressMonitor) method will skip optimized artifact if it can't be processed and chose canonical one. Pack200ProcessorStep's isEnabled() checks if 'unpack200' CLI utility is available by calling UnpackStep's canUnpack(). Change-Id: I048db3b833f6e0881cca06ad48be37ad6d17a0c9 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-12-18Bug 542873 - IBuild I20181217-1800 failed due to unresolved projectY20181219-2200I20181219-1800I20181218-1800I20181218-0120Niraj Modi1-1/+2
dependencies. Change-Id: Ib768ce797ae0c6950285d73dffa9a5da70d0910b Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-12-18Bug 542873 - IBuild I20181217-1800 failed due to unresolved projectNiraj Modi1-0/+1
dependencies. Change-Id: If64133c137cf894990ff97726aa3d32df5727295 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-12-14Version 4.11 update for org.eclipse.equinox.p2.user.uiI20181217-1800Lars Vogel2-2/+2
Change-Id: I9e6aab368914baf888c6d8d80c20d407beb71f51 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-14Version 4.11 update for org.eclipse.equinox.p2.rcp.featureLars Vogel2-2/+2
Change-Id: I8a041e5a669a475fb08780d86e501cda212ecb34 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-14Version 4.11 update for org.eclipse.equinox.p2.sdkLars Vogel2-2/+2
Change-Id: I36c4acf168472d06e82f964be70261105aa887dd Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-14Version 4.11 update for org.eclipse.equinox.p2.ui.sdkLars Vogel2-2/+2
Change-Id: Ic9ced4cfa20b847c768d2b51cce7cd1133541421 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-13Version 4.11 update for org.eclipse.equinox.p2.engineLars Vogel2-2/+2
Change-Id: I6b83642ffe5c8e24b7a13d836a6d206b44b7b007 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-13Version 4.11 update for org.eclipse.equinox.p2.core.feature andI20181216-1800I20181215-1800I20181215-0340I20181214-1800I20181214-0720Lars Vogel4-4/+4
org.eclipse.equinox.p2.extras.feature Change-Id: I12fd0b1137654a9ba81bbe7accf546b2adeba20f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-12-07Bug 541822 - POM and product version change for 4.11 releaseY20181212-2200I20181214-0105I20181213-1800I20181212-1800I20181212-0230I20181211-1800I20181211-0230I20181210-1800I20181210-0755I20181210-0535Niraj Modi61-62/+62
Change-Id: I6cc635d174e4a5a814112b7573a7cab95959fb31 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-11-23Bug 541444 - source.info contains old/duplicate bundles after platform upgradeY20181205-2200Y20181204-0315Y20181128-2200S4_10_0_RC2S4_10_0_RC1R4_10I20181206-0815I20181206-0320I20181206-0225I20181206-0030I20181205-1800I20181205-0600I20181204-1800I20181204-0600I20181203-1800I20181203-0600I20181202-1800I20181202-0600I20181201-1800I20181201-0600I20181130-1800I20181129-0330I20181128-1800I20181128-1105I20181128-0810I20181128-0600I20181128-0130I20181127-1800I20181127-0600I20181126-1800I20181126-0940I20181126-0600I20181126-0140I20181125-1800I20181125-0600I20181124-1800I20181124-0600I20181123-1800R4_10_maintenanceMat Booth5-37/+50
This change takes advantage of the fact that simpleconfigurator has already done the checking to see if the shared installation has been updated and set a system property accordingly. We then use the presence of the system property to determine whether to ignore the user configuration or not. Ignoring the user configuration means the source.info will be re -generated from scratch using the bundles in the updated shared configuration, then the migration wizard will re-insert any third -party bundles as appropriate. This avoids the possibility that there will be out-of-date entries in the source.info in the user configuration area. Change-Id: Ia59ce22133c928fe23b72c65a6034c5267f38f1b Signed-off-by: Mat Booth <mat.booth@redhat.com>
2018-11-19Close HTML tag in artifactChecksums.exsdY20181121-2200S4_10_0_M3I20181121-1800I20181121-0910I20181121-0600I20181120-1800I20181120-0600I20181119-2315I20181119-1800Mykola Nikishov1-1/+1
Change-Id: I77151f11c944c5642b7a2e5cb0e5f898628dab08 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-11-14Bug 535339 - All repositories need a NOTICE and LICENSE fileY20181114-2200I20181119-0600I20181118-1800I20181118-0600I20181117-1800I20181117-0600I20181116-1800I20181115-1800I20181115-0200I20181114-1800I20181114-1345I20181114-1325I20181114-1050Sravan Kumar Lakkimsetti3-0/+364
Change-Id: If30cc0c2054993b96dae5185a60a0d6027a936cf Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-11-13Make test variables constants to silence synthetic warnings.I20181114-0925I20181114-0355I20181114-0200Alexander Kurtakov3-9/+9
Change-Id: Id9e59cef3c13adb44d0ba7e8a0ca557af252e5c2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-11-13DisposeListener to lambda.Alexander Kurtakov3-16/+13
And enable save action so it's not introduced again. Change-Id: I78b99127b06bcfb1aa2b6bbe37a24871474dd070 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-11-06Bug 531166 - Prevent NPE on artifact download when URI scheme is null.I20181112-1800I20181112-0435I20181112-0320I20181109-0350I20181108-1800Roland Grunberg1-1/+1
Under certain circumstances, the mirror resolution requests return just the absolute file path for a resource with no scheme or host specified. (eg. /path/to/resource). This causes an NPE when getScheme() is called and used for comparison. Change-Id: Ic64323b44a9a1df7fad3a09da2f07a0a3d1a5a10 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-11-06Make MessageDigestProcessingStep's methods finalY20181107-2200I20181107-1800I20181107-0200I20181106-1800Mykola Nikishov1-4/+2
Methods write(int) and close() of this internal non-API class are not meant to be modified by subclasses. Change-Id: I9253d0f5f4ec3b8fe14f5466e78146b40b3d212a Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-11-05Uncomment tests in ProcessingStepHandlerTestI20181106-0125Mykola Nikishov1-56/+63
Change-Id: I2230fdcddca784467c307f25194f532b069df6a9 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-11-03Bug 535511 - Stackoverflow in installation details dialogI20181105-1800I20181104-1800I20181103-1800Michael Keppler3-3/+5
Avoid endless recursion by detecting the parent object being this object. Also increment the plugin versions as necessary. Change-Id: I7e1e7e69d7a01e0b089fd4d56a028d7415eb6f07 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-11-02Use varargs reflection methods.I20181102-2120I20181102-1800Alexander Kurtakov16-57/+119
Updated p2.director formatter settings to use the default Eclipse profile instead of the not-existing "core" one to prevent extra long lines. Change-Id: I4536824d8032f283e110e4aa7758feb7f110b0fc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-11-01Bug 540310 - Eclipse Fails to start if the mtime of the bundles.info file is ↵I20181101-1800Mat Booth2-2/+2
zero Fix tests failing with UnsupportedOperationException on Windows. Change-Id: Iac435bedca69156d40861bc32442d8827915a6cc Signed-off-by: Mat Booth <mat.booth@redhat.com>
2018-10-31Bug 540310 - Eclipse Fails to start if the mtime of the bundles.info file is ↵Y20181031-2200I20181031-1800Mat Booth3-8/+6
zero The o.e.e.simpleconfigurator.manipulator must also write the ctime of the base bundles.info to the .baseBundlesInfoTimestamp file in the event that the mtime is zero Change-Id: I8df7c31479899b6db9973a7f0af6471ff8b296bf Signed-off-by: Mat Booth <mat.booth@redhat.com>
2018-10-31Change p2.director formatter profile to Eclipse default one.Alexander Kurtakov3-259/+406
And format SimplePlanner with it. Change-Id: Ia3767595cb4e90a6666af40cade6a7e6b34fcc92 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-10-25Bug 540310 - Eclipse Fails to start if the mtime of the bundles.info file is ↵Y20181030-1100Y20181030-0940I20181031-0550I20181031-0540I20181030-1800Mat Booth5-6/+58
zero If the mtime of bundles.info is zero, use the ctime instead on platforms that support it Change-Id: I7c07f12433f38a6bbaf0b8b8dd23fa8c794f438d Signed-off-by: Mat Booth <mat.booth@redhat.com>
2018-10-24Bug 540363 - An error in the p2 test suiteMat Booth3-15/+22
Have SimpleConfiguratorUtilsExtendedTest extend the correct class and remove a superfluous test added to the wrong test class. The removed test is completely duplicated by "testExtensionAdded" in the SimpleConfiguratorTestExtendedConfigured class. Change-Id: I0f416d865ccadcae0eeb093f8e4375604b9d055d Signed-off-by: Mat Booth <mat.booth@redhat.com>
2018-10-23Bug 540319 - Version warning for o.e.equinox.p2.reconciler.dropinsY20181026-0120Y20181025-0550Y20181025-0530I20181029-1800I20181028-1800I20181027-1800I20181026-1800I20181025-1800I20181024-1800Mickael Istria1-0/+11
Change-Id: I7af0dcb6f983ab7b25cc7e2c8cecaac994945ea0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-10-18Mark test sources as such.I20181023-1800I20181023-1200I20181023-0800I20181022-2040I20181022-1800I20181021-1800I20181020-1800I20181019-1800I20181019-0450I20181019-0330I20181018-1800Alexander Kurtakov2-2/+10
Fixes workbench issues due to some plugins marking some not. Change-Id: I82c580bc2badf85ac259670a61ed9029ed54a4f8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-10-13Revert "[RFC] Bug 536282 - Check whether processing step is available"I20181017-1800I20181016-1800I20181015-1800I20181015-0255I20181014-2350I20181014-1800I20181013-1800Mickael Istria3-22/+3
This reverts commit 7f2938951c1f39a7707a06259116aee3d9339f58. Change-Id: I93f8f1f8ce2583a8d241ea7ed7201286bfeea9bb
2018-10-12[RFC] Bug 536282 - Check whether processing step is availableI20181012-1800Mykola Nikishov3-3/+22
Change-Id: I6a625d3fe89ca63a4b176f4fef18f07f9ba4d103 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-09Simplify ChecksumUtilities' getLegacyMd5Verifier(String)Mykola Nikishov1-14/+2
In ChecksumUtilities' getChecksumVerifiers, if artifact descriptor has ARTIFACT_MD5 or DOWNLOAD_MD5 properties, ChecksumHelper's getChecksums will populate checksums map with MD5 checksum. It makes no sense to duplicate logic from ChecksumHelper's getLegacyMd5Checksum in getLegacyMd5Verifier method, let it operate on MD5 checksum value directly. Change-Id: I867c1d0e11ec245eb07708553f265bde422d07f8 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-09Bug 535897 - Run tests from org.eclipse.equinox.p2.tests.optimizersS4_10_0_M1I20181010-1800I20181010-0600I20181009-1800Mykola Nikishov3-1/+7
Disable failing tests in SarTest. Drop unused dependency on org.eclipse.equinox.p2.tests bundle to let Maven run org.eclipse.equinox.p2.tests.optimizers before org.eclipse.equinox.p2.tests. Change-Id: I7151cc48306873c57870bbab0e5d7708f6ae0da7 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-08Switch default target platform file to 4.10-I buildsI20181009-0600I20181008-1800Mykola Nikishov1-1/+1
Change-Id: Iac58ecb7f375ef01dca95e8d2cd959e369df0ebc Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-08Fix setup for ImportExportTestsMykola Nikishov3-5/+6
Closing service tracker in test's setup method unbinds agent in ImportExportImpl and is the cause of NPEs when calling P2ImportExport's exportP2F(OutputStream, IInstallableUnit[], boolean, IProgressMonitor). Just open service tracker before test, keep it open during the test and close it after the test. Change-Id: I61c1f8d4b37e0b490d61f4b2496343e6f0132591 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-05Reuse ChecksumHelper.MD5 constantI20181008-0600Mykola Nikishov3-8/+8
Change-Id: Ic011655240f2772e9356ab5a17e8a54eb3700236 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-04Remove ref to org.eclipse.equinox.dsI20181007-1800I20181007-0600I20181006-1800I20181006-0600I20181005-1800Mickael Istria2-10/+2
Change-Id: I5784844afcaa49e1293c381733ce0d49f515512b Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-10-04Bug 536326 - Bump versionMickael Istria2-2/+2
Change-Id: Icf815e4895dfdae0345b3a2cd19cd1a35d051929 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-10-03Bug 536326 - Add failing test w/mirrors into MirrorRequestTestI20181004-1800I20181003-2215I20181003-1800Mykola Nikishov2-0/+28
As MirrorRequest keeps re-trying more mirrors than OrderedMirrorSelector has: java.lang.ArrayIndexOutOfBoundsException: 3 at org.eclipse.equinox.p2.tests.artifact.repository.MirrorRequestTest$OrderedMirrorSelector.nextMirror(MirrorRequestTest.java:426) at org.eclipse.equinox.p2.tests.artifact.repository.MirrorRequestTest$OrderedMirrorSelector.getMirrorLocation(MirrorRequestTest.java:417) at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getMirror(SimpleArtifactRepository.java:742) at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.downloadArtifact(SimpleArtifactRepository.java:639) at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getArtifact(SimpleArtifactRepository.java:772) at org.eclipse.equinox.p2.tests.artifact.repository.MirrorRequestTest$RemoteRepo.getArtifact(MirrorRequestTest.java:319) at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.getArtifact(MirrorRequest.java:316) at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transferSingle(MirrorRequest.java:286) at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transfer(MirrorRequest.java:222) at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.perform(MirrorRequest.java:176) at org.eclipse.equinox.p2.tests.artifact.repository.MirrorRequestTest.testFailToCanonicalWithMirrors(MirrorRequestTest.java:120) Change-Id: I76888490a4fa76b02bd7e037247f07a6e8cfb616 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-03Bug 536326 - Report ARTIFACT_PROCESSING_ERROR from pack200 processing stepMykola Nikishov1-3/+7
When Pack200ProcessorStep fails to unpack artifact, it reports MirrorRequest.ARTIFACT_PROCESSING_ERROR. Since b26ae58972e96118b4f9e4496438fc218e5ab2d0, processing step must return MirrorRequest.ARTIFACT_PROCESSING_ERROR to report non-transport artifact errors and instruct SimpleArtifactRepository's downloadArtifact(IArtifactDescriptor, OutputStream, IProgressMonitor) via artifactError(IStatus) method to stop retrying. This fixes failing MirrorRequestTest's testFailToCanonicalWithMirrors() from the previous commit. Bug: 377976 Change-Id: Ib0c3316915044d115408a91a45a590266a63e8b6 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-03Bug 536326 - Improve messages in MirrorRequestTest's testFailToCanonicalMykola Nikishov1-2/+2
Message junit.framework.AssertionFailedError: Exact number of downloads expected:<12> but was:<2> is more specific than original one: junit.framework.AssertionFailedError: Number of downloads differs from expected attempts. Also print artifact's key. Change-Id: Idcebd80c9b94161d895e1ba56b50f90518630b16 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-03Fix typo in IArtifactDescriptor.*_CHECKSUM javadocsMykola Nikishov3-4/+4
Change-Id: I41c5af886d3cb354aa61a77a39e852adfbe6160b Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-10-02[javadoc] Corrected link & version bump for 4.10Karsten Thoms3-3/+3
Missing arg raised validation error Change-Id: Ifb82822a6122e5927b9e8162e2296d4a04872a3e Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-09-28Fix PlanAnalyzer_NoUpdates messageI20181002-1800I20181002-0205I20181001-1800I20181001-0920Mickael Istria1-1/+1
Change-Id: I140ad7875d14cff9f81792f10905f3b186150452 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-21Bug 536766 - Bump versionsI20181001-0235I20180930-1800I20180929-1800I20180928-1800I20180927-1800I20180927-0135I20180927-0040I20180926-1800I20180926-0830I20180925-1800I20180924-1800I20180923-1800I20180922-1800I20180922-0245I20180922-0005I20180921-1800Mickael Istria36-56/+67
Change-Id: I2d65ee3c1cb2566dfae0bbcf3a379f73b4fb6900 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-21Bug 537376 - Bump versionMickael Istria2-2/+2
Change-Id: Ic49e58b283fa25ea5479e1057779be385532d450 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-21Bug 537757 - Bump versionMickael Istria3-5/+9
Change-Id: Ic06c717e5640968b4f0e082a639880be95aaeecc Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-21Improve No Updates Found messageMickael Istria3-3/+4
Make users more interested in going to the preference page. Change-Id: I962e19afbc58bc8ee17ef053dcc50ae17f751762 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-21Bug 533297 - Bump bundle versionMickael Istria6-6/+6
The .externalToolBuilder and .project are not marked as ignored in the build-qualifier configuration updating them requires version bump compared to previous release. Change-Id: I7ee60bdb451ee7fc950a5047a0bf89f1513a2ac6 Signed-off-by: Mickael Istria <mistria@redhat.com>

Back to the top