Bug 514885 Pooling Version and VersionRange

- Introduce weak object pool for Verson and VersionRange
- Use VersionRange.create() for getting pooled instances
- JavaDoc & check input for empty string

Change-Id: Ie42bdc1059d8c667af312038c26c035a6ef674af
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

1 files changed, 3 insertions, 3 deletions

diff --git a/bundles/org.eclipse.equinox.p2.publisher/src/org/eclipse/equinox/p2/publisher/AdviceFileParser.java b/bundles/org.eclipse.equinox.p2.publisher/src/org/eclipse/equinox/p2/publisher/AdviceFileParser.java
index ad445e9e6..652367d36 100644
--- a/bundles/org.eclipse.equinox.p2.publisher/src/org/eclipse/equinox/p2/publisher/AdviceFileParser.java
+++ b/bundles/org.eclipse.equinox.p2.publisher/src/org/eclipse/equinox/p2/publisher/AdviceFileParser.java
@@ -199,7 +199,7 @@ public class AdviceFileParser {
 			return MetadataFactory.createUpdateDescriptor(descriptors, Integer.valueOf(severity), description, (URI) null);
 		}
 		range = substituteVersionAndQualifier(range);
-		VersionRange versionRange = new VersionRange(range);
+		VersionRange versionRange = VersionRange.create(range);
 		return MetadataFactory.createUpdateDescriptor(name, versionRange, Integer.valueOf(severity), description);
 	}
 
@@ -274,7 +274,7 @@ public class AdviceFileParser {
 			} else if (token.equals(NAMESPACE)) {
 				namespace = currentValue();
 			} else if (token.equals(RANGE)) {
-				range = new VersionRange(substituteVersionAndQualifier(currentValue()));
+				range = VersionRange.create(substituteVersionAndQualifier(currentValue()));
 			} else if (token.equals(MIN)) {
 				min = Integer.valueOf(currentValue()).intValue();
 			} else if (token.equals(MAX)) {
@@ -416,7 +416,7 @@ public class AdviceFileParser {
 				unitUpdateId = currentValue();
 				next();
 			} else if (token.equals(UPDATE_RANGE)) {
-				unitUpdateRange = new VersionRange(substituteVersionAndQualifier(currentValue()));
+				unitUpdateRange = VersionRange.create(substituteVersionAndQualifier(currentValue()));
 				next();
 			} else if (token.equals(UPDATE_SEVERITY)) {
 				unitUpdateSeverity = Integer.parseInt(currentValue());