Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Rapicault2010-03-08 18:40:06 +0000
committerPascal Rapicault2010-03-08 18:40:06 +0000
commit0ad884af4592f26894833393b189059827e7f3dd (patch)
tree91b5bb98ddad17a9d53d2d94800548ed970c1f8e /bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata
parentd9cdee703e22ad33228f67793ba8a5c3c8a77f50 (diff)
downloadrt.equinox.p2-0ad884af4592f26894833393b189059827e7f3dd.tar.gz
rt.equinox.p2-0ad884af4592f26894833393b189059827e7f3dd.tar.xz
rt.equinox.p2-0ad884af4592f26894833393b189059827e7f3dd.zip
Bug 305031 - Remove reference to the org.osgi.Version type from the Version class
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata')
-rw-r--r--bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/Version.java32
-rw-r--r--bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/VersionRange.java13
2 files changed, 1 insertions, 44 deletions
diff --git a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/Version.java b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/Version.java
index d92b63630..d6ed8b7ac 100644
--- a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/Version.java
+++ b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/Version.java
@@ -120,19 +120,6 @@ public abstract class Version implements Comparable<Version>, Serializable {
}
/**
- * Create an omni version from an OSGi <code>version</code>.
- * @param version The OSGi version. Can be <code>null</code>.
- * @return The created omni version
- */
- public static Version fromOSGiVersion(org.osgi.framework.Version version) {
- if (version == null)
- return null;
- if (version.getMajor() == Integer.MAX_VALUE && version.getMicro() == Integer.MAX_VALUE && version.getMicro() == Integer.MAX_VALUE)
- return MAX_VERSION;
- return createOSGi(version.getMajor(), version.getMinor(), version.getMicro(), version.getQualifier());
- }
-
- /**
* Parses a version identifier from the specified string. This method is for backward
* compatibility with OSGi and will return the OSGi &quot;0.0.0&quot; version when
* the provided string is empty or <code>null</code>.
@@ -155,25 +142,6 @@ public abstract class Version implements Comparable<Version>, Serializable {
}
/**
- * Convert <code>version</code> into its OSGi equivalent if possible.
- *
- * @param version The version to convert. Can be <code>null</code>
- * @return The converted version or <code>null</code> if the argument was <code>null</code>
- * @throws UnsupportedOperationException if the version could not be converted into an OSGi version
- */
- public static org.osgi.framework.Version toOSGiVersion(Version version) {
- if (version == null)
- return null;
- if (version == emptyVersion)
- return org.osgi.framework.Version.emptyVersion;
- if (version == MAX_VERSION)
- return new org.osgi.framework.Version(Integer.MAX_VALUE, Integer.MAX_VALUE, Integer.MAX_VALUE);
-
- BasicVersion bv = (BasicVersion) version;
- return new org.osgi.framework.Version(bv.getMajor(), bv.getMinor(), bv.getMicro(), bv.getQualifier());
- }
-
- /**
* Returns the optional format.
*/
public abstract IVersionFormat getFormat();
diff --git a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/VersionRange.java b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/VersionRange.java
index 6d93d42a7..5fde149f0 100644
--- a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/VersionRange.java
+++ b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/metadata/VersionRange.java
@@ -17,7 +17,7 @@ import org.eclipse.osgi.util.NLS;
/**
* This class represents a version range with Omni Version bounds. It is signature
- * equivalent with the OSGi {@link org.eclipse.osgi.service.resolver.VersionRange VersionRange}
+ * equivalent with the OSGi org.eclipse.osgi.service.resolver.VersionRange
*
* @Immutable
* @noextend This class is not intended to be subclassed by clients.
@@ -467,15 +467,4 @@ public class VersionRange implements Serializable {
throw new IllegalArgumentException(NLS.bind(Messages.range_min_0_is_not_less_then_range_max_1, minVersion, maxVersion));
}
- public static org.eclipse.osgi.service.resolver.VersionRange toOSGiVersionRange(VersionRange range) {
- if (range.equals(emptyRange))
- return org.eclipse.osgi.service.resolver.VersionRange.emptyRange;
- return new org.eclipse.osgi.service.resolver.VersionRange(Version.toOSGiVersion(range.getMinimum()), range.getIncludeMinimum(), Version.toOSGiVersion(range.getMaximum()), range.getIncludeMinimum());
- }
-
- public static VersionRange fromOSGiVersionRange(org.eclipse.osgi.service.resolver.VersionRange range) {
- if (range.equals(org.eclipse.osgi.service.resolver.VersionRange.emptyRange))
- return emptyRange;
- return new VersionRange(Version.fromOSGiVersion(range.getMinimum()), range.getIncludeMinimum(), Version.fromOSGiVersion(range.getMaximum()), range.getIncludeMaximum());
- }
}

Back to the top