Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrzysztof Daniel2013-12-10 05:27:39 -0500
committerKrzysztof Daniel2013-12-10 05:27:39 -0500
commitac04b8c07dd5eab87eeb337bdbea929d6e1dd247 (patch)
tree52f588b1eba9b9203b9bf539b6d52ed861810723 /bundles/org.eclipse.equinox.p2.artifact.repository
parenta2344e5ad39e041ee5e822d8bddc4a71bdcd3c03 (diff)
downloadrt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.tar.gz
rt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.tar.xz
rt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.zip
bug 423628 - False positives warnings in the official build.I20131211-0800I20131210-2000I20131210-0800
False positives are caused by projects settings being different than build settings. Typical example is that project is configured to warn about local variable hiding a field, and suppression is added, but the regular releng build is not configured to warn, and it finds unnecessary suppression. I have did following things: * fixed warnings that I was able to fix (renamed variables, added generics, comments, etc, etc). * reduced the number of warnings in tests * commented warnings that must not be suppresed in the workspace unless we want "Unnecessary @SuppressWarnings" at build time. Change-Id: Iab2c962e5c331eab170b5f6e08d9bb29d05f0cc4
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.artifact.repository')
-rw-r--r--bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/repository/simple/SimpleArtifactRepository.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/repository/simple/SimpleArtifactRepository.java b/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/repository/simple/SimpleArtifactRepository.java
index 0953cdea9..359b5c47e 100644
--- a/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/repository/simple/SimpleArtifactRepository.java
+++ b/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/repository/simple/SimpleArtifactRepository.java
@@ -694,7 +694,8 @@ public class SimpleArtifactRepository extends AbstractArtifactRepository impleme
return mirrors.getMirrorLocation(baseLocation, monitor);
}
- @SuppressWarnings("rawtypes")
+ // don't suppress the warning as it will cause warnings in the official build
+ // see bug 423628. Entire hierarchy should be refactored to use generics.
public Object getAdapter(Class adapter) {
// if we are adapting to file or writable repositories then make sure we have a file location
if (adapter == IFileArtifactRepository.class)

Back to the top