diff options
| author | Krzysztof Daniel | 2013-12-10 10:27:39 +0000 |
|---|---|---|
| committer | Krzysztof Daniel | 2013-12-10 10:27:39 +0000 |
| commit | ac04b8c07dd5eab87eeb337bdbea929d6e1dd247 (patch) | |
| tree | 52f588b1eba9b9203b9bf539b6d52ed861810723 /bundles/org.eclipse.equinox.frameworkadmin.equinox | |
| parent | a2344e5ad39e041ee5e822d8bddc4a71bdcd3c03 (diff) | |
| download | rt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.tar.gz rt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.tar.xz rt.equinox.p2-ac04b8c07dd5eab87eeb337bdbea929d6e1dd247.zip | |
bug 423628 - False positives warnings in the official build.I20131211-0800I20131210-2000I20131210-0800
False positives are caused by projects settings being different than
build settings. Typical example is that project is configured to warn
about local variable hiding a field, and suppression is added, but the
regular releng build is not configured to warn, and it finds unnecessary
suppression.
I have did following things:
* fixed warnings that I was able to fix (renamed variables, added
generics, comments, etc, etc).
* reduced the number of warnings in tests
* commented warnings that must not be suppresed in the workspace unless
we want "Unnecessary @SuppressWarnings" at build time.
Change-Id: Iab2c962e5c331eab170b5f6e08d9bb29d05f0cc4
Diffstat (limited to 'bundles/org.eclipse.equinox.frameworkadmin.equinox')
| -rw-r--r-- | bundles/org.eclipse.equinox.frameworkadmin.equinox/src/org/eclipse/equinox/internal/frameworkadmin/equinox/EquinoxBundlesState.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/bundles/org.eclipse.equinox.frameworkadmin.equinox/src/org/eclipse/equinox/internal/frameworkadmin/equinox/EquinoxBundlesState.java b/bundles/org.eclipse.equinox.frameworkadmin.equinox/src/org/eclipse/equinox/internal/frameworkadmin/equinox/EquinoxBundlesState.java index b7a886b6f..fbc204c32 100644 --- a/bundles/org.eclipse.equinox.frameworkadmin.equinox/src/org/eclipse/equinox/internal/frameworkadmin/equinox/EquinoxBundlesState.java +++ b/bundles/org.eclipse.equinox.frameworkadmin.equinox/src/org/eclipse/equinox/internal/frameworkadmin/equinox/EquinoxBundlesState.java @@ -663,8 +663,9 @@ public class EquinoxBundlesState implements BundlesState { @SuppressWarnings("rawtypes") Dictionary[] dics = state.getPlatformProperties(); for (int i = 0; i < dics.length; i++) { - for (@SuppressWarnings("unchecked") - Enumeration<String> enumeration = dics[i].keys(); enumeration.hasMoreElements();) { + // don't disable this warning because it will cause build-time warning. + // see bug 423628 and 423625. + for (Enumeration<String> enumeration = dics[i].keys(); enumeration.hasMoreElements();) { String key = enumeration.nextElement(); String value = (String) dics[i].get(key); sb.append(" (" + key + "," + value + ")\n"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ |