diff options
author | Mykola Nikishov | 2019-01-21 14:00:05 +0000 |
---|---|---|
committer | Mickael Istria | 2019-01-21 14:34:29 +0000 |
commit | 251f96d8957e6ce12baa79c62b5f44205a5dbf80 (patch) | |
tree | 1f3e466d6a340ab8a045f2529142ad3e3a5927da | |
parent | 7a105c5a0b087521787a2737922682137e13d0a3 (diff) | |
download | rt.equinox.p2-251f96d8957e6ce12baa79c62b5f44205a5dbf80.tar.gz rt.equinox.p2-251f96d8957e6ce12baa79c62b5f44205a5dbf80.tar.xz rt.equinox.p2-251f96d8957e6ce12baa79c62b5f44205a5dbf80.zip |
Remove unused parameters from Engine's checkArguments private methodI20190122-1800I20190121-1800I20190121-1415
checkArguments should not pretend it validates context and monitor
parameters because it does not, they are nullable and both callers set
them to default values.
Change-Id: I3dfbebdef5cda9fa2f15bfd3047f479fc67a3c72
Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
-rw-r--r-- | bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/Engine.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/Engine.java b/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/Engine.java index 3cb3b4636..49b781965 100644 --- a/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/Engine.java +++ b/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/Engine.java @@ -32,7 +32,7 @@ public class Engine implements IEngine { agent.registerService(ActionManager.SERVICE_NAME, new ActionManager()); } - private void checkArguments(IProfile iprofile, PhaseSet phaseSet, Operand[] operands, ProvisioningContext context, IProgressMonitor monitor) { + private void checkArguments(IProfile iprofile, PhaseSet phaseSet, Operand[] operands) { if (iprofile == null) throw new IllegalArgumentException(Messages.null_profile); @@ -55,7 +55,7 @@ public class Engine implements IEngine { public IStatus perform(IProfile iprofile, IPhaseSet phases, Operand[] operands, ProvisioningContext context, IProgressMonitor monitor) { PhaseSet phaseSet = (PhaseSet) phases; - checkArguments(iprofile, phaseSet, operands, context, monitor); + checkArguments(iprofile, phaseSet, operands); if (operands.length == 0) return Status.OK_STATUS; SimpleProfileRegistry profileRegistry = (SimpleProfileRegistry) agent.getService(IProfileRegistry.SERVICE_NAME); @@ -110,7 +110,7 @@ public class Engine implements IEngine { } protected IStatus validate(IProfile iprofile, PhaseSet phaseSet, Operand[] operands, ProvisioningContext context, IProgressMonitor monitor) { - checkArguments(iprofile, phaseSet, operands, context, monitor); + checkArguments(iprofile, phaseSet, operands); if (context == null) context = new ProvisioningContext(agent); |