Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2018-11-13 09:32:18 -0500
committerAlexander Kurtakov2018-11-13 09:32:18 -0500
commit78c09dbb55376b818fcf19d568cca24a4c4dcec8 (patch)
tree32c3ecc9c36d7734472aa233b496a406c16fff8d
parentd9c2bbaa7a889d60dec1e52eb376b7a238654c39 (diff)
downloadrt.equinox.p2-78c09dbb55376b818fcf19d568cca24a4c4dcec8.tar.gz
rt.equinox.p2-78c09dbb55376b818fcf19d568cca24a4c4dcec8.tar.xz
rt.equinox.p2-78c09dbb55376b818fcf19d568cca24a4c4dcec8.zip
Make test variables constants to silence synthetic warnings.I20181114-0925I20181114-0355I20181114-0200
Change-Id: Id9e59cef3c13adb44d0ba7e8a0ca557af252e5c2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/ProfileTest.java6
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPatchPersistenceTest.java6
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPersistenceTest.java6
3 files changed, 9 insertions, 9 deletions
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/ProfileTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/ProfileTest.java
index cf34e35fb..4114955c9 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/ProfileTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/ProfileTest.java
@@ -168,10 +168,10 @@ public class ProfileTest extends AbstractProvisioningTest {
assertNull(registry.getProfile(PROFILE_NAME));
}
- private static String PROFILE_TEST_TARGET = "profileTest";
- private static Version PROFILE_TEST_VERSION = Version.create("0.0.1");
+ private final static String PROFILE_TEST_TARGET = "profileTest";
+ private final static Version PROFILE_TEST_VERSION = Version.create("0.0.1");
- private static String PROFILE_TEST_ELEMENT = "test";
+ private final static String PROFILE_TEST_ELEMENT = "test";
public static final String PROFILES_ELEMENT = "profiles"; //$NON-NLS-1$
class ProfileStringWriter extends ProfileWriter {
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPatchPersistenceTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPatchPersistenceTest.java
index fc86d5737..0c2e0987f 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPatchPersistenceTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPatchPersistenceTest.java
@@ -140,10 +140,10 @@ public class IUPatchPersistenceTest extends AbstractProvisioningTest {
return MetadataFactory.createTouchpointData(map);
}
- private static String IU_TEST_TARGET = "installableUnitTest";
- private static Version IU_TEST_VERSION = Version.create("0.0.1");
+ private final static String IU_TEST_TARGET = "installableUnitTest";
+ private final static Version IU_TEST_VERSION = Version.create("0.0.1");
- private static String IU_TEST_ELEMENT = "test";
+ private final static String IU_TEST_ELEMENT = "test";
class IUStringWriter extends MetadataWriter {
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPersistenceTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPersistenceTest.java
index 4b774d34c..09df59967 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPersistenceTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/metadata/IUPersistenceTest.java
@@ -171,11 +171,11 @@ public class IUPersistenceTest extends AbstractProvisioningTest {
private static String[][] instructions = new String[][] {new String[] {"manifest", "Manifest-Version: 1.0\\Bundle-Vendor: Eclipse.org\\Bundle-ContactAddress: www.eclipse.org\\...a whole bunch of other manifest content..."}, new String[] {"zipped", "true"}, //
new String[] {"configure", "addProgramArg(programArg:-startup);addProgramArg(programArg:@artifact);"}}; //
- private static String IU_TEST_ELEMENT = "test";
+ private final static String IU_TEST_ELEMENT = "test";
- private static String IU_TEST_TARGET = "installableUnitTest";
+ private final static String IU_TEST_TARGET = "installableUnitTest";
- private static Version IU_TEST_VERSION = Version.create("0.0.1");
+ private final static Version IU_TEST_VERSION = Version.create("0.0.1");
// Randomly chose org.eclipse.osgi.services as the IU for testing persistence
// but 'enhanced' it for better coverage.

Back to the top