Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2017-09-27 08:28:51 -0400
committerAlexander Kurtakov2017-09-27 08:28:51 -0400
commit4968320f7c29a819dfa8910c073ee28bd87e214f (patch)
tree6796c73b82f0a2ed46bb572686a85e3b5c3d4a92
parenteaca4871a4010595e9990def02c0302429a0f5a8 (diff)
downloadrt.equinox.p2-4968320f7c29a819dfa8910c073ee28bd87e214f.tar.gz
rt.equinox.p2-4968320f7c29a819dfa8910c073ee28bd87e214f.tar.xz
rt.equinox.p2-4968320f7c29a819dfa8910c073ee28bd87e214f.zip
Remove empty methods and useless overrides in p2.tests andI20170927-2000
suppresswarnings. Change-Id: Ia0b139c029a84b054ee741bf97606fbeea7b2576 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/TestMetadataRepository.java1
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/directorywatcher/DirectoryWatcherTest.java9
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/MetadataRepositoryPerformanceTest.java4
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/PublisherPerformanceTest.java8
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/UpdateQueryTest.java4
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionCapturingTest.java1
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionTestMac.java1
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/updatechecker/TestUpdateListener.java1
8 files changed, 2 insertions, 27 deletions
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/TestMetadataRepository.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/TestMetadataRepository.java
index 0285c8d58..3c7e3e7b4 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/TestMetadataRepository.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/TestMetadataRepository.java
@@ -123,5 +123,6 @@ public class TestMetadataRepository extends AbstractMetadataRepository {
*/
@Override
protected void assertModifiable() {
+ //do nothing
}
}
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/directorywatcher/DirectoryWatcherTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/directorywatcher/DirectoryWatcherTest.java
index 5482012ec..a7fd37a10 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/directorywatcher/DirectoryWatcherTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/directorywatcher/DirectoryWatcherTest.java
@@ -96,15 +96,6 @@ public class DirectoryWatcherTest extends AbstractProvisioningTest {
return null;
}
- @Override
- public void startPoll() {
-
- }
-
- @Override
- public void stopPoll() {
- }
-
};
watcher.addListener(listener);
watcher.poll();
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/MetadataRepositoryPerformanceTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/MetadataRepositoryPerformanceTest.java
index 862b7b600..45bf65862 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/MetadataRepositoryPerformanceTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/MetadataRepositoryPerformanceTest.java
@@ -64,10 +64,6 @@ public class MetadataRepositoryPerformanceTest extends ProvisioningPerformanceTe
}
@Override
- protected void tearDown() {
- }
-
- @Override
protected void test() {
for (int i = 0; i < queries.length; i++) {
repository.query(queries[i], null);
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/PublisherPerformanceTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/PublisherPerformanceTest.java
index 3ace0eeec..b29631b17 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/PublisherPerformanceTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/perf/PublisherPerformanceTest.java
@@ -42,10 +42,6 @@ public class PublisherPerformanceTest extends ProvisioningPerformanceTest {
}
@Override
- protected void tearDown() {
- }
-
- @Override
protected void test() {
for (int i = 0; i < queries.length; i++) {
result.query(queries[i], null);
@@ -73,10 +69,6 @@ public class PublisherPerformanceTest extends ProvisioningPerformanceTest {
}
@Override
- protected void tearDown() {
- }
-
- @Override
protected void test() {
for (int i = 0; i < queries.length; i++) {
result.query(queries[i], null);
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/UpdateQueryTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/UpdateQueryTest.java
index c259daf7d..566015b85 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/UpdateQueryTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/UpdateQueryTest.java
@@ -45,10 +45,6 @@ public class UpdateQueryTest extends AbstractProvisioningTest {
assertEquals(a11, c2.iterator().next());
}
- public void testUpdateWithSameId() {
-
- }
-
private IInstallableUnit createIUUpdate() {
return createIU("A", Version.create("2.1.0"), null, NO_REQUIRES, NO_PROVIDES, NO_PROPERTIES, ITouchpointType.NONE, NO_TP_DATA, false, MetadataFactory.createUpdateDescriptor("A", new VersionRange("[2.0.0, 2.1.0]"), 0, "update description"), null);
}
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionCapturingTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionCapturingTest.java
index 1b8e83cd2..08fea581f 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionCapturingTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionCapturingTest.java
@@ -31,7 +31,6 @@ import org.eclipse.equinox.p2.publisher.eclipse.*;
import org.eclipse.equinox.p2.tests.TestData;
import org.eclipse.equinox.p2.tests.publisher.TestArtifactRepository;
-@SuppressWarnings({"unchecked"})
public class ProductActionCapturingTest extends ActionTest {
File executablesFeatureLocation = null;
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionTestMac.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionTestMac.java
index 910c4a982..494550201 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionTestMac.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/publisher/actions/ProductActionTestMac.java
@@ -30,7 +30,6 @@ import org.eclipse.equinox.p2.tests.TestData;
/**
* Tests for {@link ProductAction} specific to Mac.
*/
-@SuppressWarnings({"unchecked"})
public class ProductActionTestMac extends ActionTest {
private File executablesFeatureLocation = null;
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/updatechecker/TestUpdateListener.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/updatechecker/TestUpdateListener.java
index f07c74d14..0d0c26c24 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/updatechecker/TestUpdateListener.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/updatechecker/TestUpdateListener.java
@@ -71,5 +71,6 @@ public class TestUpdateListener implements IUpdateListener {
@Override
public void checkingForUpdates() {
+ //do nothing
}
}

Back to the top