Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-08Revert "Using indexOf char instead of indexOf String"Y20190711-2335Y20190711-0900Y20190708-0900S4_13_0_M1I20190714-1800I20190713-1800I20190713-1105I20190713-0230I20190712-1800I20190712-0625I20190711-1805I20190711-1120I20190711-0825I20190710-1800I20190710-0610I20190709-1800I20190709-0610I20190708-1800I20190708-1035Thomas Watson1-1/+1
This reverts commit 272463c9791dd8cb7a814e44b262f7a4a5c7f863. Change-Id: Ifbf82e46bbefc6ad41f57f5d4fb3a21c6b0f1b2f
2019-07-05Using StringBuilder instead of StringBufferI20190708-0800I20190707-1800I20190707-0110I20190706-1800I20190705-1800Lars Vogel7-23/+54
Change-Id: Iae0de48f8bb658e7f68e7c6f88ce7c0f275dfc03 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-05Using indexOf char instead of indexOf StringLars Vogel1-1/+1
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a performance related discussion Change-Id: I949b723c4348b95d4d9c4802230ebf57e0b25f41 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-05Using indexOf char instead of indexOf StringLars Vogel1-5/+17
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a performance related discussion
2019-07-054.13 update for org.eclipse.osgi.utilLars Vogel2-2/+2
Change-Id: Ie92881d0c90c516a41427a6185ca412a7b1f1f84 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-05Bug 548432 - Remove launcher bundles for unsupported platformsY20190705-0620Lars Vogel25-873/+1
Also increases version for org.eclipse.equinox.launcher.cocoa.macosx.x86_64 Change-Id: I47ae42705ce07dad38f979d31713ffb570d8f465 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-02Bug 548780 - Add handleContentConnection method to StorageHookFactoryY20190704-0900I20190704-1800I20190704-0245I20190703-1800I20190703-0640I20190702-1800Thomas Watson4-24/+149
Make StorageHook not abstract to make it easier to implement StorageHookFactory and allow the storage hook factory to return null from createStorageHook Change-Id: I654f1d9f051df8e8f6c9c3912d0814588e58280d Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-28Bug 548723 - Add event info to bundleStartTime trace messageY20190701-0635Y20190628-1440I20190702-0930I20190702-0610I20190701-1805I20190630-1800I20190629-1800I20190628-1800Thomas Watson2-3/+3
Change-Id: I6237f09b6509cf67311af0929c2bd77b17eeaf06 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-27Bug 548727 - Using Collection.removeAll is not always the bestThomas Watson1-2/+6
Change-Id: I71c48a74d00a3a57c9f838f22a4f6cfdd3a27f01 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-27Binaries v20190627-0234Y20190627-0630I20190627-1800genie.releng11-11/+11
2019-06-27Bug 548431 - Produce signed windows launcher bundles in the platform repoY20190627-0200I20190627-0135Sravan Kumar Lakkimsetti20-20/+20
Change-Id: I2a81b0fe5d1f265f35bcd8aa5e35265c0b1cef2a Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2019-06-26Binaries v20190626-0658Y20190627-0045I20190626-1800I20190626-0720genie.releng10-10/+10
2019-06-21Bug 474156 - Run API Tools builder in the Gerrit verification buildI20190625-1800I20190625-0535I20190624-1800I20190623-1800I20190621-1800Mickael Istria13-0/+13
Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-21Use addAll, deleteAll instead of looping through a collectionLars Vogel13-47/+22
Simplifies reading the code. Change-Id: I3858fbb5778df3d50bbd61d37ba26a66107e5650
2019-06-214.13 update for org.eclipse.osgi.compatibility.stateLars Vogel2-2/+2
Change-Id: Id7ae44b6492f0ccf4cedd40c9fc8be79a2b446ba Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-20Small String optimizationI20190620-1800Lars Vogel3-8/+8
Useless toString call in String concatination Using String.valueOf instead of ""+ Use faster indexof('') version Use appends(string, startI,EndI) directly Change-Id: I937843410a4abc47803119e26073803fb1c1b115 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-20Use StringBuider instead of StringBufferLars Vogel4-5/+5
Change-Id: I3fc552dc792c306798bd2071e47c6fd36b47ea17 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-20Use contains instead of indexOf in JNIBridgeLars Vogel1-2/+2
Change-Id: I5b2af82a7abbf295df2de40f7f1870c0af269f29 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-204.13 update for org.eclipse.equinox.launcherLars Vogel2-2/+2
For https://git.eclipse.org/r/c/144444/ Change-Id: I052627e214260b870cf66df5835ea78e7040bd52 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-194.13 update of org.eclipse.equinox.supplementLars Vogel2-2/+2
Required for https://git.eclipse.org/r/144462 Change-Id: Id953db663c1c167dccbf14e15d5b08faaf7a3937 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-18Bug 548394 - Extract useful functions of ZipBundleFile to an abstract classI20190620-0130I20190619-1820I20190619-1800I20190618-1805Thomas Watson2-465/+590
Change-Id: Iba32ba31f3f80f6db2ab33d959c54deeb8156dee Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-11Cleanup resolver code to match latest Apache FelixI20190618-0225I20190617-1800I20190616-1800I20190615-1800I20190614-1800I20190614-0330I20190613-1800I20190613-0210I20190612-1800I20190612-0115Thomas Watson1-5/+7
Change-Id: I25b526a546bcfbaedef6368104b561fdce7ce09e Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-11Bug 284498 - [log] LogEntry topic required to log eventsThomas Watson1-17/+28
Change-Id: I3868cffc0f978f36264bb2b9f9fd3ccb0dbe90a0 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-11Bug 474156 - Turn missing ext point to warningMickael Istria1-0/+1
Loading the bundle in a workspace with only its dependencies as target platform currently shows an error, turn it into a warning. Change-Id: I9966ddf830961d5ad47f2337b6f499a0eead9773 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-10Bug 548075 - Ability to control if bundles are activated in parallelI20190610-1800Thomas Watson10-31/+212
Add a new option equinox.start.level.restrict.parallel which is false by default. Setting this value to true requires that the method Module.setParallelActivation must be called with true to enable parallel activation for the Module. The parallel activation setting is persistent across restarts. Tests have been added to test for persistence of the setting and that the setting is applied correctly when activating bundles from the start-level implementation. Change-Id: I20ea5807edfd10762fc5758317d946946299d5a7 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-10Bug 548017 - Reduce contention in BundleLoaderSources.getPackageSource()Anjum Fatima1-13/+12
Change-Id: Idcfb5d02d66f1be20c627e362148439f43733408 Signed-off-by: Anjum Fatima <anjum.eclipse@gmail.com>
2019-06-10Bug 547830 - fix possible deadlock in EnhancedExecutor.await()Thomas Watson6-43/+45
The count used in EnhancedExecutor is dangerous because it increments before dispatching work to the executor. If any exception happens while dispatching the task then the count will not be decremented. This changes the code to use futures instead to see when the work is done. Change-Id: Ie042d0c269cffa95dc61d917f0c1a873ba448294 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-07Bug 547928 - Version bumps for 4.13 streamI20190610-0135Thomas Watson2-2/+2
Change-Id: Ie0c4d5648bc8a4fa8bac98d73289e0d1db401fa3 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-06-07Bug 547924 - Update version number in mac's Eclipse.app for 4.13I20190608-0140I20190607-1345I20190607-1000I20190607-0725Sravan Kumar Lakkimsetti1-3/+3
Change-Id: If168dfaeef31001357b39e53800d23c2eb9d4730 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2019-06-07Bug 547907 - POM and product version change for 4.13 releaseNiraj Modi20-21/+21
Change-Id: Id7e4cd8f5f9780d2ea551f4a5d5b2280916b0d77 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-05-17Bug 547431 - PackageAdminImpl doesn't use the new FrameworkUtilHelperS4_12_0_RC2S4_12_0_RC1aS4_12_0_RC1S4_12_0_M3R4_12I20190605-1800I20190605-0600I20190604-1800I20190604-0600I20190603-1800I20190603-0600I20190602-1800I20190602-0600I20190601-1800I20190531-1800I20190531-0245I20190529-2005I20190529-1800I20190529-0600I20190528-1800I20190528-0915I20190528-0850I20190528-0600I20190527-1805I20190527-0600I20190526-1800I20190526-0600I20190525-1800I20190525-0600I20190524-1800I20190524-0135I20190522-1800I20190522-0600I20190521-1800I20190521-0600I20190520-1805I20190520-0600I20190519-1800I20190518-1800I20190517-1800R4_12_maintenanceThomas Watson2-9/+10
Change-Id: I98ab87486d3c8066f86609fc4d2959d5df1325c0 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-05-17Suppress deprecation warnings.Thomas Watson4-7/+36
Change-Id: I9df1251893c3052e18681b9a4c0beeb23b3bab90 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-05-17Fix up .api_filters to remove unused filtes.Thomas Watson1-281/+0
Change-Id: Iabff703b72a90538141fd783ef00ec00861877ae Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-05-16Add @Override AnnotationI20190516-1800I20190516-1405I20190516-1335I20190516-1250I20190516-1200I20190516-1055Carsten Hammer239-3/+1084
Change-Id: I4ef764e744192dc3564ad053e8984e891aadfe44 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-05-15Main's searchFor returns null instead of throwing an exceptionMykola Nikishov1-3/+2
Change-Id: I1e17c13829d2f25df708ebbec91e9173af8a50ca Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2019-05-15Inline single invocation of Main's searchFor(String, String, String)I20190515-1800Mykola Nikishov1-4/+0
It's 2nd parameter is not used and it makes the method an equivalent of searchFor(String, String), which remains. Change-Id: I306b26aec267436429e95ceff7f312b237783f5b Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2019-05-15Join catch sections using multicatchCarsten Hammer17-82/+27
Change-Id: Id35c9d1f3d70f1ff4c683b88cc054213b1291a17 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-05-14Bug 547265 - Fine-grained merging properties in launcher's MainI20190515-0205Mykola Nikishov1-13/+13
Merging configuration and extension properties with system properties in mergeProperties uses System's getProperties and requires ("java.util.PropertyPermission" "*" "read,write") permission even if we are not actually going to modify any of these. Instead, use more fine-grained approach and set individual properties explicitly with System's setProperty. If/when AccessControlException occurs, it would provide more specific error message like: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "eclipse.exitcode" "write") Also rename mergeProperties to mergeWithSystemProperties. Change-Id: I46bb6d539c58cc3dcff3a70dc2dc8544fc0ea7db Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2019-05-14Bug 547265 - Fine-grained access to system properties in launcher's MainMykola Nikishov3-47/+47
Running with SecurityManager enabled, System.getProperties() requires full access to all properties, including write permission, even if we are not going to modify any of them. Instead, replace System.getProperties().xxx() chained calls with their direct counterparts: - System.getProperties().getProperty() with System.getProperty() - System.getProperties().put() with System.setProperty() - System.getProperties().remove() with System.clearProperty() This would allow to use minimal security policy regarding system properties like: grant { permission java.util.PropertyPermission "*", "read"; permission java.util.PropertyPermission "osgi.*", "write"; permission java.util.PropertyPermission "eclipse.*", "write"; }; and would provide more specific error message if/when AccessControlException occurs: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "eclipse.exitcode" "read") Change-Id: If5d4cb0dc8ad795d1a9c85932222072bd58121ce Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2019-05-06Bug 547014 - Improve executors for start-level and resolutionI20190513-1800I20190512-1800I20190511-1800I20190510-1800I20190509-1800I20190508-1800I20190508-0450I20190508-0150I20190507-1800I20190507-0155I20190506-1800Thomas Watson1-33/+30
Change-Id: Idf2bf7e74394529f856a9b44e1040de0cce24805 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-29Code cleanup - get rid of unused method param configI20190505-1800I20190504-1800I20190503-1800I20190502-1800I20190501-1800I20190501-0525I20190430-1800I20190429-1800Thomas Watson1-4/+4
Change-Id: I0dac3067720a64cc9e889b55e17211271c5b8fec Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-23Bug 546658 - "Windows Server 2019" to osname.aliasesI20190429-0240I20190428-1800I20190427-1800I20190426-1800I20190425-1800I20190425-0030I20190424-1800I20190423-1800Thomas Watson1-0/+1
Change-Id: Ib70aaf1c0c086db9c80f8ee8cd3c866c4a13a8e7 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-23Remove usage of deprecated constructors and replace StringBuffer withLars Vogel13-96/+107
StringBuilder Change-Id: I2c11ad3301c7f5a7c1397804c45b0c9004d75fbd Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-04-20Bug 546606 - Optimize population of objectTableI20190422-1800I20190421-1800I20190420-1800Thomas Watson1-18/+28
Using an ArrayList here is much faster than populating a large Map keyed by Integer. Change-Id: Ic92bdef9f8d2adeca60d7390cca5d2f0cd19e092 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-20Bug 546606 - Optimize extension fragment checkThomas Watson1-21/+40
Change-Id: I227eea135bf7448985e1934c7fde9789e4b888f6 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-18Bug 540507 - Improve tests for parallel bundle startI20190419-1800I20190418-1800Thomas Watson1-5/+21
Change-Id: I284c75fad586647b67d616eed2d8690ae902608b Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-18Bug 540507 - correctly determine pool sizeThomas Watson2-6/+9
Change-Id: Ic340f4d7b9f8c53065397f64d54d4cd141c3bfa1
2019-04-18Bug 540507 - Use same executor when resolver and start-level count < 1Thomas Watson1-1/+1
Change-Id: Id90de02b27a55629ee85d2a0713cb604460ddec2 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-12Bug 546380 - Add bundleStartTime trace optionI20190417-1800I20190416-1800I20190415-1800I20190415-0300I20190414-1800I20190414-0210I20190413-1800I20190412-1800Thomas Watson4-4/+24
This new option not only records the time to load and call BundleActivator.start but also the complete time to start a bundle including resolving and firing bundle events Change-Id: I70bc48ca3bfbe08d33a159d7add0164df8bcfa76 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
2019-04-12Bug 540507 - parallel activation of bundles from framework start-levelThomas Watson8-47/+284
By default the framework start-level implementation activates all bundles that have the same start-level in sequential order using the bundle ID (install order) to determine the order the bundles are started from a single thread. A new configuration option is added equinox.start.level.thread.count that is set to 1 by default. This will cause the framework to continue with the behavior of activating all bundles with a single thread. If equinox.start.level.thread.count is set to -1 then the framework will use an executor with the number of threads == to java.lang.Runtime.availableProcessors() to activate the bundles in parallel. This means that the order the bundles with the same start-level are activated becomes random. The equinox.start.level.thread.count config setting can also be set to a value > 1 to give an explicit value for the number of threads to use (instead of using java.lang.Runtime.availableProcessors() to determine the number) Change-Id: Ifcf6f18b762bcb114f8f8c75630fdca0cb79a24c Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>

Back to the top