Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Blewitt2015-06-18 18:55:01 +0000
committerAlex Blewitt2015-07-06 07:46:20 +0000
commit9ee96387c3c9b80f76fa76476f4d0fa5764f4919 (patch)
tree20a3db893b2db4503ac53222599a72ca3ef7d210 /bundles/org.eclipse.equinox.metatype
parentbde007b013512c536e1e8c5b616961a6a0140347 (diff)
downloadrt.equinox.bundles-9ee96387c3c9b80f76fa76476f4d0fa5764f4919.tar.gz
rt.equinox.bundles-9ee96387c3c9b80f76fa76476f4d0fa5764f4919.tar.xz
rt.equinox.bundles-9ee96387c3c9b80f76fa76476f4d0fa5764f4919.zip
Bug 470518 - Replace `new Boolean` with `Boolean.valueOf`
Using `new Boolean()` results in the creation of a new object on the heap, when the flyweight `Boolean.TRUE` and `Boolean.FALSE` are available. Java 1.4 added a `Boolean.valueOf()` which can be used in place of `new Boolean()` but which will use the existing flyweight values instead. Globally change `new Boolean(...)` to `Boolean.valueOf(...)` and replace constant valued expressions with their flyweight counterparts. Bug: 470518 Change-Id: I25742c65162e57fd553dd1284ec057cd4b333dbb Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Diffstat (limited to 'bundles/org.eclipse.equinox.metatype')
-rw-r--r--bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/DataParser.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/DataParser.java b/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/DataParser.java
index 9f8b7c1ea..5fec8b215 100644
--- a/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/DataParser.java
+++ b/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/DataParser.java
@@ -144,7 +144,7 @@ public class DataParser {
case AttributeDefinition.BIGDECIMAL :
return new BigDecimal(value);
case AttributeDefinition.BOOLEAN :
- return new Boolean(value);
+ return Boolean.valueOf(value);
default :
// Unknown data type
return null;

Back to the top