aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Thun2011-03-28 09:26:17 (EDT)
committerMathias Kinzler2011-03-28 11:27:39 (EDT)
commit833d162cfc8af3bcdf93cb1627d63127b84cc016 (patch)
tree1abfc0c8c72760bfb1fe64ba2f4f91074203d918
parent5ec25800330b36b803e46c0f431e9cb5e5345f8f (diff)
downloadegit-833d162cfc8af3bcdf93cb1627d63127b84cc016.zip
egit-833d162cfc8af3bcdf93cb1627d63127b84cc016.tar.gz
egit-833d162cfc8af3bcdf93cb1627d63127b84cc016.tar.bz2
Prevent flickering in history viewrefs/changes/46/2946/2
When the history view is showing an error message, the user can produce flickering by constantly clicking on the refresh button. This was caused by the fact that setErrorMessage was called twice internally. By simply moving one of the statements to another place, this flickering is avoided. Change-Id: I3ac272146984f94ff0bcb850e8279645985a39ac Signed-off-by: Philipp Thun <philipp.thun@sap.com>
-rw-r--r--org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java
index cb4f653..e57fee4 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java
@@ -915,7 +915,6 @@ public class GitHistoryPage extends HistoryPage implements RefsChangedListener {
return true;
cancelRefreshJob();
- setErrorMessage(null);
Object o = super.getInput();
if (o == null) {
setErrorMessage(UIText.GitHistoryPage_NoInputMessage);
@@ -1005,6 +1004,7 @@ public class GitHistoryPage extends HistoryPage implements RefsChangedListener {
actions.showAllFolderVersionsAction.setEnabled(inResources != null);
actions.showAllResourceVersionsAction.setEnabled(filtersActive);
+ setErrorMessage(null);
try {
initAndStartRevWalk(false);
} catch (IllegalStateException e) {