summaryrefslogtreecommitdiffstatsabout
diff options
context:
space:
mode:
authorTomasz Zarna2011-12-14 07:44:58 (EST)
committer Tomasz Zarna2011-12-14 07:44:58 (EST)
commit2e8e208d7123448b6443ed63d58cc92c03e3f155 (patch)
treeff4f578cee7c4f9ea0b2617008b913b06819541e
parent8672f0d5ddbea6f0f4c1fd9f516daa8c75cc6175 (diff)
downloadegit-2e8e208d7123448b6443ed63d58cc92c03e3f155.zip
egit-2e8e208d7123448b6443ed63d58cc92c03e3f155.tar.gz
egit-2e8e208d7123448b6443ed63d58cc92c03e3f155.tar.bz2
An internal error occurred during: "Pulling from Multiple Repositories".refs/changes/15/4815/1
The URIish that caused me the pain in bug 366389 was "tzarna@git.eclipse.org...". Inverting equals helped. Bug: 366389 Change-Id: I2e0a049f8231fbae98c4b5ec2112184ff034037c
-rw-r--r--org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java b/org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java
index 355b754..3c71cc8 100644
--- a/org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java
+++ b/org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java
@@ -83,13 +83,13 @@ public class EGitSecureStore {
URIish storedURI = uri.setUser(null).setPass(null).setPath(null);
if (uri.getPort() == -1) {
String s = uri.getScheme();
- if (s.equals("http")) //$NON-NLS-1$
+ if ("http".equals(s)) //$NON-NLS-1$
storedURI = storedURI.setPort(80);
- else if (s.equals("https")) //$NON-NLS-1$
+ else if ("https".equals(s)) //$NON-NLS-1$
storedURI = storedURI.setPort(443);
- else if (s.equals("ssh") || s.equals("sftp")) //$NON-NLS-1$ //$NON-NLS-2$
+ else if ("ssh".equals(s) || "sftp".equals(s)) //$NON-NLS-1$ //$NON-NLS-2$
storedURI = storedURI.setPort(22);
- else if (s.equals("ftp")) //$NON-NLS-1$
+ else if ("ftp".equals(s)) //$NON-NLS-1$
storedURI = storedURI.setPort(21);
}
String pathName = GIT_PATH_PREFIX