Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Wolf2018-11-22 16:20:00 -0500
committerMatthias Sohn2018-11-25 06:36:56 -0500
commit132a185e62587c43df41a5bb2b05d8992eae2c94 (patch)
tree47b144623b5b53e9c0f6975d3132f24b305abe15 /org.eclipse.egit.ui.test/src
parenta6c390df5a301b6cd63e6e3a41884e45a0bddd61 (diff)
downloadegit-132a185e62587c43df41a5bb2b05d8992eae2c94.tar.gz
egit-132a185e62587c43df41a5bb2b05d8992eae2c94.tar.xz
egit-132a185e62587c43df41a5bb2b05d8992eae2c94.zip
Change LoginDialog default button label
The login dialog's default button always had the label "Save". This feels unnatural when the dialog is used for logging in; it may be fine when the dialog is used to change an existing password. Change the label to "Log in" in changeCredentials == false. To ensure this flag is always set properly when we create the buttons, remove the setter for that field and pass the value as a parameter in the constructor. Bug: 541312 Change-Id: I6df0b8f592ba3f91dbb89a83e8a0be30d5738501 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.ui.test/src')
-rw-r--r--org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java
index 70483c160..717f334d3 100644
--- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java
+++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java
@@ -21,7 +21,7 @@ public class LoginDialogTester {
bot.textWithLabel(UIText.LoginDialog_user).setText(user);
bot.textWithLabel(UIText.LoginDialog_password).setText(password);
bot.checkBoxWithLabel(UIText.LoginDialog_storeInSecureStore).deselect();
- bot.button(UIText.LoginDialog_ButtonOK).click();
+ bot.button(UIText.LoginDialog_ButtonLogin).click();
}
}

Back to the top