diff options
author | Thomas Wolf | 2017-07-14 14:21:19 +0000 |
---|---|---|
committer | Thomas Wolf | 2017-10-16 21:10:51 +0000 |
commit | a0e6c966acaa71713e0557a7a172c75b2197c9f6 (patch) | |
tree | f3ef0d4948a40d6b8d8df83e86ac6b44f0b63ab3 /org.eclipse.egit.ui.test/src/org/eclipse/egit | |
parent | ee5336775acf9efa647ba8e0f5a9009ac90da77e (diff) | |
download | egit-a0e6c966acaa71713e0557a7a172c75b2197c9f6.tar.gz egit-a0e6c966acaa71713e0557a7a172c75b2197c9f6.tar.xz egit-a0e6c966acaa71713e0557a7a172c75b2197c9f6.zip |
Move history page actions into plugin.xml and remove default handlers
The history view's main context menu was built programmatically,
apparently because of bug 322751, which undid an earlier attempt
to do this (bug 321516).
Move the context menu back to plugin.xml. Remove the menu items from
CommitGraphTable and add a new section in the menu ("history.group")
so that we can add our built-in commands in our own group, not just
under "additions".
Basically all the history view commands had defaultHandlers. To
remove them, we need quite a lot of new dedicated handlers.
Verified that the error described in bug 322751 did not re-appear.
There should be only minor visual changes in the context menu of the
history view. We only show applicable operations, and I have slightly
re-arranged a few separators.
There is quite some duplication between handlers. With the new
IRepositoryCommit interface, it should be possible to unify many
commands, but this is postponed to future commits.
Bug: 495064
Change-Id: I73951763904f61ec1b116dc1781cbcc6b0fdb65f
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.ui.test/src/org/eclipse/egit')
-rw-r--r-- | org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java index dc2fbb0c0c..e03d0861aa 100644 --- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java +++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java @@ -275,7 +275,7 @@ public class HistoryViewTest extends LocalRepositoryTestCase { SWTBotTableItem item = table.getTableItem(0); item.select(); ContextMenuHelper.clickContextMenu(table, - UIText.GitHistoryPage_CreateBranchMenuLabel); + util.getPluginLocalizedValue("HistoryCreateBranch.label")); SWTBotShell dialog = bot .shell(UIText.CreateBranchWizard_NewBranchTitle); dialog.bot().textWithId("BranchName").setText("NewBranch"); @@ -305,7 +305,7 @@ public class HistoryViewTest extends LocalRepositoryTestCase { }); ContextMenuHelper.clickContextMenu(table, - UIText.GitHistoryPage_CreateTagMenuLabel); + util.getPluginLocalizedValue("HistoryCreateTag.label")); SWTBotShell dialog = bot.shell(UIText.CreateTagDialog_NewTag); dialog.bot().textWithLabel(UIText.CreateTagDialog_tagName) .setText("NewTag"); |