diff options
| author | Thomas Wolf | 2018-11-22 21:20:00 +0000 |
|---|---|---|
| committer | Matthias Sohn | 2018-11-25 11:36:56 +0000 |
| commit | 132a185e62587c43df41a5bb2b05d8992eae2c94 (patch) | |
| tree | 47b144623b5b53e9c0f6975d3132f24b305abe15 /org.eclipse.egit.ui.test/src/org/eclipse/egit | |
| parent | a6c390df5a301b6cd63e6e3a41884e45a0bddd61 (diff) | |
| download | egit-132a185e62587c43df41a5bb2b05d8992eae2c94.tar.gz egit-132a185e62587c43df41a5bb2b05d8992eae2c94.tar.xz egit-132a185e62587c43df41a5bb2b05d8992eae2c94.zip | |
Change LoginDialog default button label
The login dialog's default button always had the label "Save". This
feels unnatural when the dialog is used for logging in; it may be
fine when the dialog is used to change an existing password.
Change the label to "Log in" in changeCredentials == false. To ensure
this flag is always set properly when we create the buttons, remove
the setter for that field and pass the value as a parameter in the
constructor.
Bug: 541312
Change-Id: I6df0b8f592ba3f91dbb89a83e8a0be30d5738501
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.ui.test/src/org/eclipse/egit')
| -rw-r--r-- | org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java index 70483c1606..717f334d35 100644 --- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java +++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LoginDialogTester.java @@ -21,7 +21,7 @@ public class LoginDialogTester { bot.textWithLabel(UIText.LoginDialog_user).setText(user); bot.textWithLabel(UIText.LoginDialog_password).setText(password); bot.checkBoxWithLabel(UIText.LoginDialog_storeInSecureStore).deselect(); - bot.button(UIText.LoginDialog_ButtonOK).click(); + bot.button(UIText.LoginDialog_ButtonLogin).click(); } } |