Skip to main content
diff options
authorThomas Wolf2015-09-01 16:22:03 -0400
committerAndrey Loskutov2015-09-02 15:57:09 -0400
commit8a28d7ab199da0ba51a1d53bd777ccaedbf194d9 (patch)
treeb2a785b3b3e04bd84a72f5d8eb8275878df7838e /org.eclipse.egit.ui.test/META-INF
parentd37c07fac7a92a026b60ca40f3f0d1b7ae57fbd1 (diff)
Fix hyperlink display in SpellcheckableMessageArea
This is first and foremost a syntax coloring problem, and should be handled as such. This change implements that: * Adds a token scanner that recognizes hyperlinks using the configured hyperlink detectors. * Adds a presentation reconciler with a damager/repairer that uses this token scanner. * Gets rid of the overridden hideHyperlinks() method -- if we do proper syntax coloring, this can wreck havoc when the text is edited (the super implementation does some StyleRange cleanup; if that is omitted, a stale and possibly out-of-bounds range remains). * Uses SWT.UNDERLINE_LINK to style hyperlink partitions. * Adds a few unit tests for the tokenizing. * Adds org.objenesis to required bundles in org.eclipse.egit.ui.test to enable mocking. In my manual UI tests, this syntax-colors hyperlinks nicely in the staging view, spell-checking works, auto-wrap works, whitespace display works, the "hand" pointer appears only over hyperlinks, and bug 471355 is solved. It also has no adverse effects on the commit viewer or the git history view. Bug: 471355 Change-Id: I623ead62d9600028973353cf63183638a1e06a3e Signed-off-by: Thomas Wolf <>
Diffstat (limited to 'org.eclipse.egit.ui.test/META-INF')
1 files changed, 2 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui.test/META-INF/MANIFEST.MF b/org.eclipse.egit.ui.test/META-INF/MANIFEST.MF
index e728da89d..ce28cd1ef 100644
--- a/org.eclipse.egit.ui.test/META-INF/MANIFEST.MF
+++ b/org.eclipse.egit.ui.test/META-INF/MANIFEST.MF
@@ -14,7 +14,8 @@ Require-Bundle: org.apache.log4j;bundle-version="[1.0.0,2.0.0)",;bundle-version="[3.4.0,4.0.0)";resolution:=optional,
- org.mockito;bundle-version="[1.8.0,1.9.0)"
+ org.mockito;bundle-version="[1.8.0,1.9.0)",
+ org.objenesis;bundle-version="[1.0.0,2.0.0)"
Import-Package: org.eclipse.egit.core.test;version="[4.1.0,4.2.0)",

Back to the top