Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDariusz Luksza2011-05-14 10:04:50 -0400
committerCode Review2011-05-14 10:04:50 -0400
commitf530556c54ae2f118782b39fa287972f0c4f9870 (patch)
tree649e00b3d0f727a88284d478c791e5471248c281
parentd26c347ca11c24706c15e9f2ca55421cbba6cca5 (diff)
parent51089ecd6eb9caa4af4024157873c1895923fade (diff)
downloadegit-f530556c54ae2f118782b39fa287972f0c4f9870.tar.gz
egit-f530556c54ae2f118782b39fa287972f0c4f9870.tar.xz
egit-f530556c54ae2f118782b39fa287972f0c4f9870.zip
Merge "[findBugs] Do not ignore return value of File methods"
-rw-r--r--org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CloneOperationTest.java3
-rw-r--r--org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java1
2 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CloneOperationTest.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CloneOperationTest.java
index 28dc50f0b..f9e7245a3 100644
--- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CloneOperationTest.java
+++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CloneOperationTest.java
@@ -27,6 +27,7 @@ import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.storage.file.FileRepository;
import org.eclipse.jgit.transport.URIish;
+import org.eclipse.jgit.util.FileUtils;
import org.junit.Before;
import org.junit.Test;
@@ -44,7 +45,7 @@ public class CloneOperationTest extends DualRepositoryTestCase {
repository1 = new TestRepository(new File(workdir, Constants.DOT_GIT));
File file = new File(workdir, "file1.txt");
- file.createNewFile();
+ FileUtils.createNewFile(file);
Git git = new Git(repository1.getRepository());
git.add().addFilepattern("file1.txt").call();
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java
index 56b7ca041..656f390cb 100644
--- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java
+++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java
@@ -207,7 +207,6 @@ public abstract class AbstractSynchronizeViewTest extends
protected void createEmptyRepository() throws Exception {
File gitDir = new File(new File(getTestDirectory(), EMPTY_REPOSITORY),
Constants.DOT_GIT);
- gitDir.mkdir();
Repository myRepository = new FileRepository(gitDir);
myRepository.create();

Back to the top