Remove help button (? icon) from wizards

Most EGit wizards showed a help button that was unusable, i.e. did
not link to documentation. This patch removes the help buttons.

Change-Id: I425b1698b48dcc180e0e3967038543c2981e3394
Signed-off-by: Philipp Thun <philipp.thun@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

17 files changed, 44 insertions, 15 deletions

diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/FetchActionHandler.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/FetchActionHandler.java
index a4537f8d3f..d712d582d5 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/FetchActionHandler.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/FetchActionHandler.java
@@ -43,7 +43,9 @@ public class FetchActionHandler extends RepositoryActionHandler {
 									.getMessage(), x));
 			return null;
 		}
-		new WizardDialog(getShell(event), fetchWizard).open();
+		WizardDialog dlg = new WizardDialog(getShell(event), fetchWizard);
+		dlg.setHelpAvailable(false);
+		dlg.open();
 		return null;
 	}
 
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PushActionHandler.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PushActionHandler.java
index 5133457360..72963c05d8 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PushActionHandler.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PushActionHandler.java
@@ -43,7 +43,9 @@ public class PushActionHandler extends RepositoryActionHandler {
 									.getMessage(), x));
 			return null;
 		}
-		new WizardDialog(getShell(event), pushWizard).open();
+		WizardDialog dlg = new WizardDialog(getShell(event), pushWizard);
+		dlg.setHelpAvailable(false);
+		dlg.open();
 		return null;
 	}
 
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java
index b86eb6004f..f976b14334 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java
@@ -114,6 +114,7 @@ public class GitSelectRepositoryPage extends WizardPage {
 				GitCloneWizard cloneWizard = new GitCloneWizard();
 				cloneWizard.setCallerRunsCloneOperation(true);
 				WizardDialog dlg = new WizardDialog(getShell(), cloneWizard);
+				dlg.setHelpAvailable(false);
 				if (dlg.open() == Window.OK)
 					cloneWizard.runCloneOperation(getContainer());
 				checkPage();
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/ShareSingleProjectCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/ShareSingleProjectCommand.java
index 21f1d2e3eb..3d9468dd31 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/ShareSingleProjectCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/ShareSingleProjectCommand.java
@@ -45,6 +45,7 @@ public class ShareSingleProjectCommand extends AbstractHandler {
 		wizard.init(workbench, projectToShare);
 		final Shell shell = HandlerUtil.getActiveShell(event);
 		WizardDialog wizardDialog = new WizardDialog(shell, wizard);
+		wizardDialog.setHelpAvailable(false);
 		wizardDialog.open();
 		return null;
 	}
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
index c03a635e87..94e2f059b1 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
@@ -97,6 +97,7 @@ public class GitCreatePatchWizard extends Wizard {
 		WizardDialog dialog = new WizardDialog(part.getSite().getShell(),
 				wizard);
 		dialog.setMinimumPageSize(INITIAL_WIDTH, INITIAL_HEIGHT);
+		dialog.setHelpAvailable(false);
 		dialog.open();
 	}
 
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CreateBranchOnCommitHandler.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CreateBranchOnCommitHandler.java
index be47c4bb7a..fa924a1686 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CreateBranchOnCommitHandler.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CreateBranchOnCommitHandler.java
@@ -27,8 +27,11 @@ public class CreateBranchOnCommitHandler extends AbstractHistoryCommanndHandler
 		PlotCommit commit = (PlotCommit) getSelection(getPage()).getFirstElement();
 		Repository repo = getRepository(event);
 
-		new WizardDialog(HandlerUtil.getActiveShellChecked(event),
-				new CreateBranchWizard(repo, commit)).open();
+		WizardDialog dlg = new WizardDialog(
+				HandlerUtil.getActiveShellChecked(event),
+				new CreateBranchWizard(repo, commit));
+		dlg.setHelpAvailable(false);
+		dlg.open();
 		return null;
 	}
 
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/ConfigureUriPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/ConfigureUriPage.java
index 561cf78002..3816635e24 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/ConfigureUriPage.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/ConfigureUriPage.java
@@ -118,6 +118,7 @@ public class ConfigureUriPage extends WizardPage {
 					SelectUriWizard slwz = new SelectUriWizard(false, uriText
 							.getText());
 					WizardDialog dlg = new WizardDialog(getShell(), slwz);
+					dlg.setHelpAvailable(false);
 					if (dlg.open() == Window.OK) {
 						URIish uri = slwz.getUri();
 						credentials = slwz.getCredentials();
@@ -174,6 +175,7 @@ public class ConfigureUriPage extends WizardPage {
 					SelectUriWizard selectWizard = new SelectUriWizard(false);
 					WizardDialog dlg = new WizardDialog(getShell(),
 							selectWizard);
+					dlg.setHelpAvailable(false);
 					if (dlg.open() == Window.OK) {
 						URIish uri = selectWizard.getUri();
 						if (uri.equals(myUri) || myUris.contains(uri)) {
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CloneCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CloneCommand.java
index 9c9af893d6..dfd71e2f87 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CloneCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CloneCommand.java
@@ -22,9 +22,10 @@ import org.eclipse.jface.wizard.WizardDialog;
 public class CloneCommand extends
 		RepositoriesViewCommandHandler<RepositoryTreeNode> {
 	public Object execute(ExecutionEvent event) throws ExecutionException {
-		WizardDialog dlg = new WizardDialog(
-				getShell(event), new GitCloneWizard());
+		WizardDialog dlg = new WizardDialog(getShell(event),
+				new GitCloneWizard());
+		dlg.setHelpAvailable(false);
 		dlg.open();
 		return null;
 	}
-}
+}
\ No newline at end of file
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureFetchCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureFetchCommand.java
index b1669137d4..53720666d2 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureFetchCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureFetchCommand.java
@@ -37,6 +37,7 @@ public class ConfigureFetchCommand extends
 		WizardDialog dlg = new WizardDialog(
 				getShell(event), new ConfigureRemoteWizard(
 						selectedNode.getRepository(), configName, false));
+		dlg.setHelpAvailable(false);
 		dlg.open();
 
 		return null;
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigurePushCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigurePushCommand.java
index 46361b66a8..e98b99ea73 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigurePushCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigurePushCommand.java
@@ -37,6 +37,7 @@ public class ConfigurePushCommand extends
 		WizardDialog dlg = new WizardDialog(
 				getShell(event), new ConfigureRemoteWizard(
 						selectedNode.getRepository(), configName, true));
+		dlg.setHelpAvailable(false);
 		dlg.open();
 
 		return null;
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureRemoteCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureRemoteCommand.java
index 1eb0b403a1..e80f15ee75 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureRemoteCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ConfigureRemoteCommand.java
@@ -27,6 +27,7 @@ public class ConfigureRemoteCommand extends
 		WizardDialog dlg = new WizardDialog(
 				getShell(event), new NewRemoteWizard(node
 						.getRepository()));
+		dlg.setHelpAvailable(false);
 		dlg.open();
 
 		return null;
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateBranchCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateBranchCommand.java
index 5dec5e99ee..84067b4cb5 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateBranchCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateBranchCommand.java
@@ -41,8 +41,11 @@ public class CreateBranchCommand extends
 			try {
 				RevCommit baseCommit = new RevWalk(node.getRepository())
 						.parseCommit(ref.getLeaf().getObjectId());
-				new WizardDialog(getShell(event), new CreateBranchWizard(node
-						.getRepository(), baseCommit)).open();
+				WizardDialog dlg = new WizardDialog(
+						getShell(event),
+						new CreateBranchWizard(node.getRepository(), baseCommit));
+				dlg.setHelpAvailable(false);
+				dlg.open();
 			} catch (IOException e) {
 				Activator.handleError(e.getMessage(), e, true);
 			}
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateRepositoryCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateRepositoryCommand.java
index e3e7adb80c..081add8d78 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateRepositoryCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateRepositoryCommand.java
@@ -23,7 +23,10 @@ import org.eclipse.jface.wizard.WizardDialog;
 public class CreateRepositoryCommand extends
 		RepositoriesViewCommandHandler<RepositoryTreeNode> implements IHandler {
 	public Object execute(ExecutionEvent event) throws ExecutionException {
-		new WizardDialog(getShell(event), new NewRepositoryWizard()).open();
+		WizardDialog dlg = new WizardDialog(getShell(event),
+				new NewRepositoryWizard());
+		dlg.setHelpAvailable(false);
+		dlg.open();
 		return null;
 	}
 }
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/FetchCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/FetchCommand.java
index ca9473c691..9c13b011ea 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/FetchCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/FetchCommand.java
@@ -28,8 +28,10 @@ public class FetchCommand extends
 		RepositoryNode node = getSelectedNodes(event).get(0);
 
 		try {
-			new WizardDialog(getShell(event), new FetchWizard(
-					node.getRepository())).open();
+			WizardDialog dlg = new WizardDialog(getShell(event),
+					new FetchWizard(node.getRepository()));
+			dlg.setHelpAvailable(false);
+			dlg.open();
 		} catch (URISyntaxException e1) {
 			Activator.handleError(e1.getMessage(), e1, true);
 		}
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java
index e25ed619a2..9aad28b2d9 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java
@@ -42,6 +42,7 @@ public class ImportProjectsCommand extends
 		WizardDialog dlg = new WizardDialog(
 				getShell(event),
 				new GitCreateProjectViaWizardWizard(node.getRepository(), path));
+		dlg.setHelpAvailable(false);
 		dlg.open();
 
 		return null;
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/PushCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/PushCommand.java
index 7dafad2831..e580af1503 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/PushCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/PushCommand.java
@@ -27,8 +27,10 @@ public class PushCommand extends RepositoriesViewCommandHandler<RepositoryNode>
 		RepositoryNode node = getSelectedNodes(event).get(0);
 
 		try {
-			new WizardDialog(getShell(event),
-					new PushWizard(node.getRepository())).open();
+			WizardDialog dlg = new WizardDialog(getShell(event),
+					new PushWizard(node.getRepository()));
+			dlg.setHelpAvailable(false);
+			dlg.open();
 		} catch (URISyntaxException e1) {
 			Activator.handleError(e1.getMessage(), e1, true);
 		}
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ResetCommand.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ResetCommand.java
index c5a9d7eb23..d9bab13178 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ResetCommand.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ResetCommand.java
@@ -123,7 +123,9 @@ public class ResetCommand extends
 				return true;
 			}
 		};
-		new WizardDialog(getShell(event), wiz).open();
+		WizardDialog dlg = new WizardDialog(getShell(event), wiz);
+		dlg.setHelpAvailable(false);
+		dlg.open();
 
 		return null;
 	}