Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDani Megert2015-06-08 06:24:45 -0400
committerMatthias Sohn2015-06-08 09:22:43 -0400
commit293572df4bd82e4911ef9c0b1307658cee593f70 (patch)
tree7d73302f8ff8fae2830ba80754313551751c003a
parent8f7679df026b413b65dc51011fc3c8380c60fb02 (diff)
downloadegit-293572df4bd82e4911ef9c0b1307658cee593f70.tar.gz
egit-293572df4bd82e4911ef9c0b1307658cee593f70.tar.xz
egit-293572df4bd82e4911ef9c0b1307658cee593f70.zip
Fix that double click is needed to "Check/Uncheck All Repositories"
When using the add existing repository wizard it was necessary to double click "Check All Repositories"/"Uncheck All Repositories" to check/uncheck listed repositories. c62ffbf5 tried to fix this but made it worse for the user: while it unchecked all elements in the UI it then added all repositories on Finish. Bug: 450946 Change-Id: I268ff5c3ed2aae2aab0f3bc404410e2fb1ced4ae Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
-rw-r--r--org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java11
1 files changed, 4 insertions, 7 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java
index c91c9e620..d8de64c23 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java
@@ -62,7 +62,6 @@ import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Text;
import org.eclipse.swt.widgets.ToolBar;
import org.eclipse.swt.widgets.ToolItem;
-import org.eclipse.swt.widgets.TreeItem;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.dialogs.PatternFilter;
import org.osgi.service.prefs.BackingStoreException;
@@ -353,9 +352,8 @@ public class RepositorySearchDialog extends WizardPage {
@Override
public void widgetSelected(SelectionEvent e) {
- for (TreeItem item : fTreeViewer.getTree().getItems()) {
- fTreeViewer.setSubtreeChecked(item.getData(), true);
- }
+ isUserModifiedTreeSelection = true;
+ fTreeViewer.setAllChecked(true);
enableOk();
}
@@ -372,9 +370,8 @@ public class RepositorySearchDialog extends WizardPage {
@Override
public void widgetSelected(SelectionEvent e) {
- for (TreeItem item : fTreeViewer.getTree().getItems()) {
- fTreeViewer.setSubtreeChecked(item.getData(), false);
- }
+ isUserModifiedTreeSelection = true;
+ fTreeViewer.setAllChecked(false);
enableOk();
}

Back to the top