diff options
| author | Matthias Sohn | 2016-05-15 22:47:34 +0000 |
|---|---|---|
| committer | Matthias Sohn | 2016-05-17 07:37:12 +0000 |
| commit | ff9403fb412b0d3997348acf96dfdbf0503dea0b (patch) | |
| tree | 53baa8c9f7fda330d468234e28f5f5a75602ec90 | |
| parent | c3c9fad2b56d7cdbde8a4fc24a32863cec6361c2 (diff) | |
| download | egit-ff9403fb412b0d3997348acf96dfdbf0503dea0b.tar.gz egit-ff9403fb412b0d3997348acf96dfdbf0503dea0b.tar.xz egit-ff9403fb412b0d3997348acf96dfdbf0503dea0b.zip | |
[findBugs] Avoid unnecessary boxing when parsing int from String
Change-Id: I632e4a038444c2b89823a8830339daf4523ebc6a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| -rw-r--r-- | org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java | 6 | ||||
| -rw-r--r-- | org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java | 8 |
2 files changed, 6 insertions, 8 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java index e271dcfa29..57cc1848d5 100644 --- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java +++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java @@ -1157,11 +1157,10 @@ public class CommitDialog extends TitleAreaDialog { boolean ignoreErrorsValue = ignoreErrors == null ? true : !ignoreErrors.getSelection(); - @SuppressWarnings("boxing") boolean hasErrorsOrWarnings = getPreferenceStore() .getBoolean(UIPreferences.WARN_BEFORE_COMMITTING) ? (getProblemsSeverity() >= Integer - .valueOf(getPreferenceStore().getString( + .parseInt(getPreferenceStore().getString( UIPreferences.WARN_BEFORE_COMMITTING_LEVEL)) && ignoreErrorsValue) : false; @@ -1183,12 +1182,11 @@ public class CommitDialog extends TitleAreaDialog { } } setMessage(message, type); - @SuppressWarnings("boxing") boolean commitBlocked = getPreferenceStore() .getBoolean(UIPreferences.WARN_BEFORE_COMMITTING) && getPreferenceStore().getBoolean(UIPreferences.BLOCK_COMMIT) ? (getProblemsSeverity() >= Integer - .valueOf(getPreferenceStore().getString( + .parseInt(getPreferenceStore().getString( UIPreferences.BLOCK_COMMIT_LEVEL)) && ignoreErrorsValue) : false; diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java index 445d78fcc0..f26074599e 100644 --- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java +++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java @@ -1275,7 +1275,7 @@ public class StagingView extends ViewPart implements IShowInSource { String[] parts = s.split(","); //$NON-NLS-1$ int[] ints = new int[parts.length]; for (int i = 0; i < parts.length; i++) { - ints[i] = Integer.valueOf(parts[i]).intValue(); + ints[i] = Integer.parseInt(parts[i]); } return ints; } @@ -2970,18 +2970,18 @@ public class StagingView extends ViewPart implements IShowInSource { private boolean hasErrorsOrWarnings() { return getPreferenceStore() .getBoolean(UIPreferences.WARN_BEFORE_COMMITTING) - ? (getProblemsSeverity() >= Integer.valueOf(getPreferenceStore() + ? (getProblemsSeverity() >= Integer + .parseInt(getPreferenceStore() .getString(UIPreferences.WARN_BEFORE_COMMITTING_LEVEL)) && !ignoreErrors.getSelection()) : false; } - @SuppressWarnings("boxing") private boolean isCommitBlocked() { return getPreferenceStore() .getBoolean(UIPreferences.WARN_BEFORE_COMMITTING) && getPreferenceStore().getBoolean(UIPreferences.BLOCK_COMMIT) ? (getProblemsSeverity() >= Integer - .valueOf(getPreferenceStore().getString( + .parseInt(getPreferenceStore().getString( UIPreferences.BLOCK_COMMIT_LEVEL)) && !ignoreErrors.getSelection()) : false; |