diff options
| author | Matthias Sohn | 2010-12-05 22:04:47 +0000 |
|---|---|---|
| committer | Matthias Sohn | 2010-12-05 22:04:47 +0000 |
| commit | 64cb45e5d8b3b61346fedd3cbfed7fcf804eac55 (patch) | |
| tree | db9317c4afb9c5fe40c3b20a7acf409574c57aea | |
| parent | 3a832b97c65258b3cfe724bf3fec7bfcc1a35e0b (diff) | |
| download | egit-64cb45e5d8b3b61346fedd3cbfed7fcf804eac55.tar.gz egit-64cb45e5d8b3b61346fedd3cbfed7fcf804eac55.tar.xz egit-64cb45e5d8b3b61346fedd3cbfed7fcf804eac55.zip | |
[findbugs] Do not expose internal object representation
To prevent callers to modify the internal representation of field
modifiedContent return a copy of this data.
Change-Id: Ie6a3fe5e9cf999ea8c90088b10a463fbae2258c3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| -rw-r--r-- | org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EditableRevision.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EditableRevision.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EditableRevision.java index a7f6029c1a..8ec2f4beb6 100644 --- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EditableRevision.java +++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EditableRevision.java @@ -11,6 +11,7 @@ package org.eclipse.egit.ui.internal; import java.io.ByteArrayInputStream; import java.io.InputStream; +import java.util.Arrays; import org.eclipse.compare.IContentChangeListener; import org.eclipse.compare.IContentChangeNotifier; @@ -139,7 +140,7 @@ public class EditableRevision extends FileRevisionTypedElement implements * @return the modified content */ public byte[] getModifiedContent() { - return modifiedContent; + return Arrays.copyOf(modifiedContent, modifiedContent.length); } public Object getAdapter(Class adapter) { |