From c3be20c9ab85f074725c0defe6c349ae768f7661 Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Mon, 6 Aug 2018 14:10:45 +0200 Subject: refactor: simplify collection.toArray() On recent VMs, collection.toArray(new T[0]) is faster than collection.toArray(new T[collection.size()]). Since it is also more readable, it should now be the preferred way of collection to array conversion. https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Change-Id: Ie1a23d2a278ccd677b9c92da9677864d1ba09cde Signed-off-by: Michael Keppler --- .../org/eclipse/mylyn/internal/github/ui/issue/IssueConnectorUi.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueConnectorUi.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueConnectorUi.java index 75e3d998..99f0f491 100644 --- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueConnectorUi.java +++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueConnectorUi.java @@ -168,7 +168,7 @@ public class IssueConnectorUi extends AbstractRepositoryConnectorUi { } } } - return hyperlinks.toArray(new IHyperlink[hyperlinks.size()]); + return hyperlinks.toArray(new IHyperlink[0]); } private Region createRegion(int textOffset, Matcher matcher) { -- cgit v1.2.3