Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/org.eclipse.mylyn.github.ui
AgeCommit message (Collapse)AuthorFilesLines
2018-11-17Unify gitignore rules in a single top level fileMichael Keppler1-2/+0
Remove all project specific ignore rules and instead use a single top level gitignore. Change-Id: I5083985bba93c9db108f1930965f76a827927baf
2018-10-20[releng] Fix deprecated ViewerSorter usageMichael Keppler1-2/+2
Change-Id: Icecaec547384b6247adfde6ae28a9421b41a07f1 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-10-20[releng] Store all project properties explicitlyMichael Keppler2-2/+46
We use project specific properties in many projects. However, the files containing them are old, therefore they do not contain all the keys and values that have been added in newer Eclipse releases. This change makes all those missing settings explicit. All project properties have been opened in the UI and the "Apply" button has been used without changing any controls. We should therefore see only additions in the diff, no changes in values. The main intention of this change is to reduce the noise for actual changes of settings which are intended to be applied afterwards. The removal of JDT settings in org.eclipse.mylyn.github.doc is intentional. That is a PDE project without Java nature. Change-Id: I66b75fc8a64660615a0d2a8601f0b0cf3de82993 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-10-20[releng] Fix unused member/parameter warningsMichael Keppler1-3/+2
Change-Id: I0aa395f4e4075a24782df46607ef93c0d6d1c2dc Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-10-18[releng] Fix all boxing/unboxing warningsMichael Keppler5-6/+10
Make all type conversions with an Eclipse compiler warning explicit. Change-Id: I3eb1f57c1a556a17cc4dd15b58fa394ce641721c Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-10-08minor: fix all empty block warningsMichael Keppler4-2/+13
Comment all empty blocks to get rid of the many warnings. Either comment as empty or as visibility change. There is no functional change. Changes outside adding comments in empty blocks are all due to format on save. Change-Id: Ie42e97cfe1d418bdfb9a5293ff7d3a8d01dbdb82 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-09-30Remove outdated github launch fileMichael Keppler1-61/+0
This launch file is completely outdated and doesn't work at all. Even changes of the last years were basically always just because of mass updates. It references workspace projects which are not of the eclipse foundation and it lives in the .settings folder, which is not a good place for launch configs. Since egit developers use local launch configs, the same approach seems reasonable for egit-github, so delete this one. Change-Id: I36b6359d5398eb9a6d7a6cda54878e843205f74d Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-09-23Add Mylyn commit message templateMichael Keppler1-0/+3
This is only relevant for EGit contributors, not for EGit users. Change-Id: I828400fee88cbe77fbc31519684d1b004c69baa5 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-09-05Prepare 5.2.0-SNAPSHOT buildsMatthias Sohn2-29/+29
Change-Id: I5e0d278aeb48ccaf52894b70d7f6f2c8d99039df Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-08-14refactor: simplify collection.toArray()Michael Keppler1-1/+1
On recent VMs, collection.toArray(new T[0]) is faster than collection.toArray(new T[collection.size()]). Since it is also more readable, it should now be the preferred way of collection to array conversion. https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Change-Id: Ie1a23d2a278ccd677b9c92da9677864d1ba09cde Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-08-13Add missing blank in github wizard labelsMichael Keppler3-36/+7
Leading or trailing blanks in property files are hard to manage, therefore the concatenation of the existing strings doesn't produce a blank. Use plurals instead. Bug: 537469 Change-Id: Id83ebc1149069f9036f47facd711d75213719d48 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-05-30Replace deprecated ViewerSortersMichael Keppler2-4/+7
Replace ViewerSorters by signature compatible ViewerComparators. The setComparator() interface exists since 3.2, so there should not be a problem with compatibility. The remaining ViewerSorter depends on a super class in mylyn.commons.ui, which has no ViewerComparator replacement yet. Change-Id: I9a647998a58c6d64d84f61e5aab41fd2e63423ae Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-05-30More restrictive JDT settings for the projectsThomas Wolf15-115/+655
Use the settings from EGit, then fix all errors reported. (Mostly non-externalized strings and inconsistent or missing Javadoc.) The "organize imports" order has been adapted to the apparent convention used hitherto, which is "com,java,javax,org" (strictly alphabetical), whereas EGit uses "java,javax,org,com". Then make the tycho compiler plugin use those settings. Change-Id: Idda75e94b7c8d48f7ce3a1b6678728a4ec569781 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2018-05-30Merge branch 'stable-5.0'Matthias Sohn54-126/+238
* stable-5.0: Update license to EPL-2.0 Prepare 5.0.0-SNAPSHOT builds EGit Mylyn Github Connector v5.0.0.201805221745-rc1 Prepare 5.0.0-SNAPSHOT builds EGit Mylyn Github Connector v5.0.0.201805151920-m7 Change-Id: If036a88ae4b1ffb27750794f571087aeb251ad29
2018-05-30Update license to EPL-2.0Matthias Sohn54-126/+238
- use CBI license feature for EPL-2.0 - LICENSE with EPL-2.0 license text - update license headers - improve feature.properties - remove obsolete .eclipse_iplog Bug: 530393 Change-Id: I9f17457f70c5b1672e4c329dc389492c863fd838 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-23Prepare 5.1.0-SNAPSHOT buildsMatthias Sohn2-29/+29
Change-Id: I483b724b5203568dec0f24c1da3d9b68dcd14638 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-23Prepare 5.0.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: If4e8ef4e00f18494f54e7ad44b35b1e67e879264 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-22EGit Mylyn Github Connector v5.0.0.201805221745-rc1v5.0.0.201805221745-rc1Matthias Sohn2-2/+2
Change-Id: I014ba51283c399d61f26a69b44aeb9938dbf3f40 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-17Prepare 5.0.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: Iaa1bb384c6f7447c61a71a010fe8bb67cbdd077f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-16EGit Mylyn Github Connector v5.0.0.201805151920-m7v5.0.0.201805151920-m7Matthias Sohn2-2/+2
Change-Id: I1722c80ad6762c238215fee1e9e1db63a7ee6358 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-11Replace use of deprecated Repository#getRef methodMatthias Sohn3-3/+3
Change-Id: I5a4d904e6210fdff8f6c6c406f67e45503f640b4 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-09Prepare 5.0.0-SNAPSHOT buildsMatthias Sohn2-29/+29
Change-Id: I222824cf5f3601906d4193f8008860ce8c362331 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-08Prepare 4.11.1-SNAPSHOT buildsstable-4.11Matthias Sohn2-13/+13
Change-Id: Ia51eb0f6a5fcb7677b1609458332ac4fef01adc6 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-08EGit Mylyn Github Connector v4.11.0.201803080745-rv4.11.0.201803080745-rMatthias Sohn2-2/+2
Change-Id: I24ee25ce1d38060f7b79f624364a73b77823bdc1 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-01-02Replace FileInputStream and FileOutputStream with static Files methodsMatthias Sohn1-24/+14
FileInputStream and FileOutputStream rely on finalize() method to ensure resources are closed. This implies they are added to the finalizer queue which causes additional work for the JVM GC process. This is an open bug on the OpenJDK [1] and the recommended workaround is to use the Files.newInputStream and Files.newOutputStream static methods instead. [1] https://bugs.openjdk.java.net/browse/JDK-8080225 Change-Id: I2de6fc27d7fb593a946e9f6d9bb64873092e258c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-12-31Prepare 4.11.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I015129d796c625e6e0beda30009bcbd45a3a3114 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-12-30Remove references to org.eclipse.update.configuratorMatthias Sohn1-1/+1
Bug: 527379 Change-Id: Iffe0942e47096e732e9ca5116a31228d248e4b14 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-12-30Remove references to update.coreKarsten Thoms1-1/+1
Remove old prefs migration code and tracing options in launch configs. Bug: 527249 Change-Id: Id4b3218ea64b7ae5599766d915e15dcf824dd9fe Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-12-23Add header Automatic-Module-Name for Java 9Karsten Thoms1-0/+1
Bug: 529074 Change-Id: Ibe911d70b49759ecc445911b14a3cd2c64d76efa Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-10-08Prepare 4.10.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: Idb7d5db06c1cd154290a8315ea95b6756ee995ba Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-08-01Remove deprecated access to mylyn.tasksMichael Keppler6-17/+18
Now using new (redirected) values of several deprecated constants. Minimum version of mylyn.tasks.core has been increased to the version 3.9.0 where the new constants are declared. That minimum version is years behind the current version, so this does not really seem unfair to users of mylyn, as it does not enforce upgrading to a very recent version. Checked with egit-4.5 target platform. Change-Id: If49165fcaf4956079935a091887da6e5ad412316 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-07-09Have non empty title for all wizardsMichael Keppler4-3/+9
The GitHub related wizards did not set a window title, which at least on Windows looks not so nice. The usage of the Messages class had to be fully qualified in one wizard, because it already used another unrelated Messages class for creating a login form. Change-Id: I5e21dd33d57407555d0abf8cc4f95cf5831b6069 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2017-06-14Do not try to use EGit icons directlyThomas Wolf20-7/+7
These icon filenames are not public API; this will break when EGit decides to move to PNG. See bug 517169. Copy the PNGs from EGit instead (including the HiDPI versions), and reference them locally. SVG sources are _not_ included; those live in the EGit UI project. Adapt plugin.xml and GitHubImages accordingly. Bug: 472534 Change-Id: I6366b44e51c884f17aa8a9ef6aee7e6e4d014abe Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2017-05-30Prepare 4.9.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: Ic7e425c51c8f6788f0a6f2a143acf5c723e8a960 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-05-19Resolve compilation problem on OxygenThomas Wolf5-1/+251
org.eclipse.mylyn.internal.github.ui.gist makes use of many internal classes from org.eclipse.mylyn.tasks.ui. With version 3.23.0 of Mylyn Tasks, one of these classes changes in incompatible ways, so this part of egit-github no longer compiles. As a quick fix, take an slightly older version of this class from Mylyn Tasks, rename it, and minimally adapt it to get it to compile. Then use that copy. This will work with Mylyn Tasks versions 3.7 up to at least 3.23.0. This is a hack. For one, the class in question is a label provider, and the using class already fiddles with column indices to adjust that label provider to its particular use. So a more complete fix would be to write our own, dedicated label provider. And of course there's no guarantee that egit-github won't break again when other Mylyn-internal classes change. Bug: 516148 Change-Id: I03896c43f6876821ca5cc1f95d8fcebcb05e9812 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2017-04-05Prepare 4.8.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: Ib2894b94006a5c82ec43e8a75cd2c0a120f6dba8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-12-27Prepare 4.7.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I98bf43abb5acdf4a3ce2167509b30c2751f34fca Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-12-26Prepare 4.6.1-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I2401c8149efc4c05f1f77a62cb3cb080976482d2 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-12-24EGit Mylyn Github Connector v4.6.0.201612231935-rv4.6.0.201612231935-rMatthias Sohn2-2/+2
Change-Id: Ia2070aec86efb3f11b6e5a58ef8af6033298a59c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-09-20Change minimum execution environment to JavaSE-1.8Matthias Sohn4-6/+6
Change-Id: Id9ae44ede66f21edbae4c2cc192c68c1968622ee Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-09-19Prepare 4.6.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I73f99318418a7af2305868165667d48805344f52 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-06-01Prepare 4.5.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I3207590651c3aaf77a7afd3f41c10ca226ff5ef0 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-05-15Fix auto-filled issue task URLPatrick-Jeffrey Pollo Guilbert1-1/+1
Bug: 486345 Change-Id: I409878995f8cf4f55bcf823d5b898c27e52c0cb5 Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-04-08Prepare 4.4.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I5ae4b15b83cd571a7047aca223ba71fcca79d487 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-04-08Prepare 4.3.1-SNAPSHOT buildsstable-4.3Matthias Sohn2-13/+13
Change-Id: Ib4bb2bcb9047fd4e58f6f58cd1dc77833943d5ab Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-04-07EGit Mylyn Github Connector v4.3.0.201604071810-rv4.3.0.201604071810-rMatthias Sohn2-2/+2
Change-Id: I2bef635cf696377e670e4453d2faeeba53165182 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-04-07EGit Mylyn Github Connector v4.3.0.201604071045-rMatthias Sohn2-2/+2
Change-Id: Ia423a0210db4c9f78d5dbaaa35709a88711f1558 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-04-05Prepare 4.3.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I451cb8567886573b6df576d9cfd8574221e6beca Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-03-23EGit Mylyn Github Connector v4.3.0.201603230630-rc1v4.3.0.201603230630-rc1Matthias Sohn2-2/+2
Change-Id: I063421c3d5f3dbea91ed522f065f5056dac1214c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-01-21Prepare 4.3.0-SNAPSHOT buildsMatthias Sohn2-13/+13
Change-Id: I116fb6ef0b8ef1477b90bd5bfd8b88652785c527 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Back to the top