Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/org.eclipse.mylyn.github.ui/src
AgeCommit message (Collapse)AuthorFilesLines
2018-08-14refactor: simplify collection.toArray()Michael Keppler1-1/+1
On recent VMs, collection.toArray(new T[0]) is faster than collection.toArray(new T[collection.size()]). Since it is also more readable, it should now be the preferred way of collection to array conversion. https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Change-Id: Ie1a23d2a278ccd677b9c92da9677864d1ba09cde Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-08-13Add missing blank in github wizard labelsMichael Keppler3-36/+7
Leading or trailing blanks in property files are hard to manage, therefore the concatenation of the existing strings doesn't produce a blank. Use plurals instead. Bug: 537469 Change-Id: Id83ebc1149069f9036f47facd711d75213719d48 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-05-30Replace deprecated ViewerSortersMichael Keppler2-4/+7
Replace ViewerSorters by signature compatible ViewerComparators. The setComparator() interface exists since 3.2, so there should not be a problem with compatibility. The remaining ViewerSorter depends on a super class in mylyn.commons.ui, which has no ViewerComparator replacement yet. Change-Id: I9a647998a58c6d64d84f61e5aab41fd2e63423ae Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-05-30More restrictive JDT settings for the projectsThomas Wolf13-98/+231
Use the settings from EGit, then fix all errors reported. (Mostly non-externalized strings and inconsistent or missing Javadoc.) The "organize imports" order has been adapted to the apparent convention used hitherto, which is "com,java,javax,org" (strictly alphabetical), whereas EGit uses "java,javax,org,com". Then make the tycho compiler plugin use those settings. Change-Id: Idda75e94b7c8d48f7ce3a1b6678728a4ec569781 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2018-05-30Update license to EPL-2.0Matthias Sohn52-108/+210
- use CBI license feature for EPL-2.0 - LICENSE with EPL-2.0 license text - update license headers - improve feature.properties - remove obsolete .eclipse_iplog Bug: 530393 Change-Id: I9f17457f70c5b1672e4c329dc389492c863fd838 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-11Replace use of deprecated Repository#getRef methodMatthias Sohn3-3/+3
Change-Id: I5a4d904e6210fdff8f6c6c406f67e45503f640b4 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-01-02Replace FileInputStream and FileOutputStream with static Files methodsMatthias Sohn1-24/+14
FileInputStream and FileOutputStream rely on finalize() method to ensure resources are closed. This implies they are added to the finalizer queue which causes additional work for the JVM GC process. This is an open bug on the OpenJDK [1] and the recommended workaround is to use the Files.newInputStream and Files.newOutputStream static methods instead. [1] https://bugs.openjdk.java.net/browse/JDK-8080225 Change-Id: I2de6fc27d7fb593a946e9f6d9bb64873092e258c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-08-01Remove deprecated access to mylyn.tasksMichael Keppler5-8/+9
Now using new (redirected) values of several deprecated constants. Minimum version of mylyn.tasks.core has been increased to the version 3.9.0 where the new constants are declared. That minimum version is years behind the current version, so this does not really seem unfair to users of mylyn, as it does not enforce upgrading to a very recent version. Checked with egit-4.5 target platform. Change-Id: If49165fcaf4956079935a091887da6e5ad412316 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2017-07-09Have non empty title for all wizardsMichael Keppler4-3/+9
The GitHub related wizards did not set a window title, which at least on Windows looks not so nice. The usage of the Messages class had to be fully qualified in one wizard, because it already used another unrelated Messages class for creating a login form. Change-Id: I5e21dd33d57407555d0abf8cc4f95cf5831b6069 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2017-06-14Do not try to use EGit icons directlyThomas Wolf1-2/+2
These icon filenames are not public API; this will break when EGit decides to move to PNG. See bug 517169. Copy the PNGs from EGit instead (including the HiDPI versions), and reference them locally. SVG sources are _not_ included; those live in the EGit UI project. Adapt plugin.xml and GitHubImages accordingly. Bug: 472534 Change-Id: I6366b44e51c884f17aa8a9ef6aee7e6e4d014abe Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2017-05-19Resolve compilation problem on OxygenThomas Wolf3-1/+251
org.eclipse.mylyn.internal.github.ui.gist makes use of many internal classes from org.eclipse.mylyn.tasks.ui. With version 3.23.0 of Mylyn Tasks, one of these classes changes in incompatible ways, so this part of egit-github no longer compiles. As a quick fix, take an slightly older version of this class from Mylyn Tasks, rename it, and minimally adapt it to get it to compile. Then use that copy. This will work with Mylyn Tasks versions 3.7 up to at least 3.23.0. This is a hack. For one, the class in question is a label provider, and the using class already fiddles with column indices to adjust that label provider to its particular use. So a more complete fix would be to write our own, dedicated label provider. And of course there's no guarantee that egit-github won't break again when other Mylyn-internal classes change. Bug: 516148 Change-Id: I03896c43f6876821ca5cc1f95d8fcebcb05e9812 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2016-05-15Fix auto-filled issue task URLPatrick-Jeffrey Pollo Guilbert1-1/+1
Bug: 486345 Change-Id: I409878995f8cf4f55bcf823d5b898c27e52c0cb5 Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-09-02Fix maven buildAndrey Loskutov2-4/+3
- Follow up on moved EGit preferences: in EGit commit 1332a1fedf6a2f189eb90644946a7309423eccf3 we changed the way how to get the default repository directory - Update link to Orbit p2 repository, the S build we used so far isn't available anymore and didn't match the version we use in github.target. Now we use the orbit release for Mars for both. Change-Id: Iffe228baa753083b55ca62385bab61dd5d9f23ea Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-05-26Use try-with-resource to close JGit walksMatthias Sohn3-31/+22
JGit now supports AutoClosable on walks and no longer supports the old release() method. Change-Id: I82e1a788ad212ac067dd45d1bdf959feaf991174 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2014-07-08Fix dependency to FilteredCheckboxTreeMatthias Sohn1-1/+1
FilteredCheckboxTree was moved to another package in 7384f0318 EGit-Dependency: I3437704d644f6a6473626a3f19d7c6a235e11e22 Change-Id: I8fb2d42e3b9d981e30ec6f000d8e7c84911b956a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2014-02-13Remove duplicate URL encoding of repository search queryMichael Keppler1-6/+1
* URL encoding is done in repository service already * therefore not necessary in wizard page Bug: 420666 Change-Id: I10a2efc5a1423db48300c54a19694368b87ea976 Signed-off-by: Michael Keppler <michael.keppler@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2013-05-08Adapt github connector to compile against jgit/egit 3.0Matthias Sohn3-4/+4
Also flip github connectors own version to 3.0 since our simple release process isn't able to cope with different versions for jgit/egit and egit-github. Change-Id: If099a7a0f8176d6a3e2c09a5709d906dad8f2620 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2012-11-30Show info message that anonymous cannot submit tasksKaloyan Raev3-1/+55
When creating or refreshing the editor, it is checked if the github repository is configured with user credentials. In case, it is anonymous an info message is shown. When clicking on the info message, the repository configuration dialog is opened and the user can enter the credentials. If the repository is anonymous and the user insists to submit the issue, then the info message turns into error message. This solution is inspired by the Bugzilla task editor. Bug: 390757 Change-Id: I9f498acdec46a15156939e71bcc9bd40766cd65f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2012-06-06Use API v3 endpoint for repository search APIKevin Sawicki1-15/+12
API v2 is being removed and is now provided as a legacy v3 API. Change-Id: Id1dea03486893b25012ae72518910a7d1bb3f4b9
2012-05-08Consume Mylyn 3.7 APIsSteffen Pingel7-18/+13
Several internal classes were promoted to API in Mylyn 3.7 and deprecated. The GitHub connector should consume the new APIs since deprecated classes are going to be removed for Mylyn 3.8. Change-Id: Idab168d16247f00bb9d9ce6e4bbc64817b749380 Signed-off-by: Kevin Sawicki <kevin@github.com>
2012-01-30Add the RepositorySearchWizardPage to the EGit import wizardStefan Lay1-3/+23
In this first version we just clone the repository without further configuration. Change-Id: Ia1fb391dfc18771c51a9727d7946f53403c5a3bb Signed-off-by: Stefan Lay <stefan.lay@sap.com> Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-12-05Support creating Gist from files selected in Package ExplorerKevin Sawicki1-7/+12
This required updating the 'visibleWhen' to check for a selection that adapts to IResource but not to IContainer as a check for IFile does not match selected compilation units Change-Id: I26c5393ec23adb6108004510c640d5cd123663ce
2011-12-05Use correct task repository when opening a newly GistKevin Sawicki3-19/+22
Now that multiple Gist Task Repositories are supported the GistNotificationPopup needs to track which repository to use when the link is selected Change-Id: Ibd8c911d8396c6856aabec3fa93a708a3a977c24
2011-10-28Add support for creating Gists from Console viewKevin Sawicki1-19/+41
Change-Id: I882fbc5a50d2cb91f642c5166c5b0441dacc5900 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-10-28Use default sorter for gist repositoriesKevin Sawicki1-0/+2
Change-Id: I46acdc7a4791c70cfc981651a3c3e34494463a10 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-10-27Prompt on Gist creation when multiple repositories exist.Kevin Sawicki5-14/+123
The repository selected will be used to create the Gist. Change-Id: I734d4cb4985438309b71a04f2e01229591484372 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-22Set destination text to be read-onlyKevin Sawicki1-2/+2
Change-Id: I17063818a3c665dc6916d219eca3dcf0056e3c3e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-10Show dialog when opening commit fails due to missing repositoryKevin Sawicki5-31/+45
Change-Id: I16bbf217b22f82e252a5977a780219771c97058e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Show dialog when pull request does not resolve to Git repository.Kevin Sawicki3-1/+31
This message prompts the user to add or clone the repository using the Git Repositories view. Change-Id: I69983133baa0f9280276e7ccacb5fc2e0ef3960c Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Remove checkout, rebase, and merge actions from toolbar.Kevin Sawicki1-4/+5
The workflow for these actions requires more refining than time permits for the 1.1 release. Change-Id: Ic3cd5290a2c41565504acb6b5abe91b0e2d455a5 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-01Support more types of editor inputs when creating Gists.Kevin Sawicki1-18/+51
Adds explicit support for path and uri editor inputs as well as structured selections that can adapt to an IFile handle. Change-Id: I7f91be696e0def8a1c6c1bde8454662ee5b2acea Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-01Use pull URL when not Gist owner.Kevin Sawicki1-22/+0
This bypasses the need for a credentials provider configured on the clone operation. Cloning a Gist that you are not the owner of will no longer require a SSH key. Change-Id: Iccc527bf5e809b619041066093cfd0018bf484d3 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-01Only show language if non-null and non-emptyKevin Sawicki1-2/+4
Change-Id: I114e9ddcd3bc3ca53673cd3ba04259757b4633e3 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-08-31Add missing setters to model classesKevin Sawicki1-2/+2
Change-Id: Idb955166172a8ec7bcb98cedd0abc829f1fc0f9e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-08-17Forward query page completeness to search container.Kevin Sawicki4-42/+99
Corrects the enablement of the Search button when query pages are used in a search container. Change-Id: Ie9bd42d3b67ceda2dfa510a33c48752dd201dd06 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-08-16Add service support for repository commits API.Kevin Sawicki2-7/+7
Supports fetching commits and adding, editing, deleting, and fetching commit comments. Change-Id: Ife800440c07ee9c9a46c2037fdef777e2dd6e734 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-08-04Add support for rebasing and merging pull requests.Kevin Sawicki8-125/+338
Pull request editor now has actions to rebase pull request topic branch onto tip of destination branch and also merge topic branch into destination branch. Change-Id: I271e6b6f78d5706748f0eb844d73d9ae25347787 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-08-01Add task repository for pull requests.Kevin Sawicki20-66/+1554
Initially supports: * Editing summary & description * Browsing & adding comments * Browsing & opening associated commits * Closing & re-opening the pull request * Checking out the pull request's commits into a topic branch * Fetching pull request commits * Generating a context with the files modified in the pull request Change-Id: Iba75e999353dbc5d095dc95dd2977e9f21d694e6 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-07-15Remove code duplicated in Gist and Issue packages.Kevin Sawicki9-113/+139
Add base classes for attributes, connectors, and data handlers. These new base classes will also be used by the forthcoming Pull Request connector. Change-Id: I1812fede3752bb85ec65cdedcba8ad078767455b Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-07-10Enable clone repositories from GitHub wizard.Kevin Sawicki4-122/+366
Supports searching for repositories by language, cloning them, and adding them to the Git Repositories view. Change-Id: Id042ca49d9f0d1e6c09eb16bb4cff16d68ff09a8 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-07-08Remove use of WorkbenchLabelProvider as a IStyledLabelProvider.Kevin Sawicki1-4/+51
This supports 3.6 which doesn't have the IWorkbenchAdapter3 class. Change-Id: Id64d4b9c2097cf447024cfc03e83a5eb59d08ce9 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-07-06Show all of the user's repositories in import wizard.Kevin Sawicki1-3/+2
Previously only public repositories were shown. Change-Id: I5b491614e750bf87cb26e2ff94083c256b1903e9 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-29Open task by id when task is null.Kevin Sawicki2-1/+4
This fixes an issue where links on created gist popups would not open the gist in the task editor. Change-Id: I0448bdb4b7107d6bc26ea1250617b9a21444bf80 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-29Clone GitHub repository via EGit.Christian Trutz4-4/+95
GitHub repositories can be successfully be cloned (read-only) and are functional via EGit. Change-Id: I66f87acb61f3374730cc42fcac3174afb4953b4c Signed-off-by: Christian Trutz <christian.trutz@gmail.com> Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-20Migrate repository and pull request services to v3.Kevin Sawicki6-34/+161
Searching for repositories still uses the v2 API which is why the two repository models are now required. Change-Id: I18700446790337031be2faf9114ff2bb581fdeb3 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-15Merge branch 'stable-1.0'Kevin Sawicki4-0/+177
* stable-1.0: Use proxy route planner when configuring client. Update EGit/JGit dependencies and target for 1.0.0 Remove dependency to Indigo Conflicts: org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/client/GitHubClient.java Change-Id: Ib635d25ae47968a7e50a3529974bd2bc16768b53 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-14Remove dependency to IndigoMatthias Sohn1-1/+25
Removing dependency to new method getActiveEditorInput() which was added to HandlerUtil in Indigo enables usage on older platform releases. Also see bug 323528. Change-Id: Ie3cecd14e5a0cd4eed77f722421843b3273e840c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-06-12Import Wizard for Github repositories.Christian Trutz4-0/+177
Change-Id: I5d7d61e066a1bdb7b4f644cc75ff83418e955845 Signed-off-by: Christian Trutz <christian.trutz@gmail.com> Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-06-01Add support for error field in request error class.Kevin Sawicki1-3/+9
The error field is present in v2 API error messages which are still encountered when using the repository API. Change-Id: I8e4cffa4608696db056e7ee7b695da34061b103a Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-05-30Use wrapped exception when validating repo settings.Kevin Sawicki2-0/+4
RequestException thrown during repository validation needs to be wrapped in GitHubException to have properly formatted messages displayed in the wizard message area. This change migrates exception handling to always wrap RequestException inside a GitHubException when caught. Change-Id: I464948f7ca14e818e840bf482c301b7d96f5b2ba Signed-off-by: Kevin Sawicki <kevin@github.com>

Back to the top