diff options
| author | Thomas Wolf | 2017-05-19 09:01:52 +0000 |
|---|---|---|
| committer | Thomas Wolf | 2017-05-19 21:11:02 +0000 |
| commit | afa702f00581346a4265932f85cfce29d2db14b5 (patch) | |
| tree | dc1512465077b37be7533eb82dac5844b822db32 /org.eclipse.mylyn.github.ui/icons | |
| parent | 47cd0e4bddbdaf35b44898f360c87df7ba7ab734 (diff) | |
| download | egit-github-afa702f00581346a4265932f85cfce29d2db14b5.tar.gz egit-github-afa702f00581346a4265932f85cfce29d2db14b5.tar.xz egit-github-afa702f00581346a4265932f85cfce29d2db14b5.zip | |
Resolve compilation problem on Oxygen
org.eclipse.mylyn.internal.github.ui.gist makes use of many
internal classes from org.eclipse.mylyn.tasks.ui. With version
3.23.0 of Mylyn Tasks, one of these classes changes in incompatible
ways, so this part of egit-github no longer compiles.
As a quick fix, take an slightly older version of this class from
Mylyn Tasks, rename it, and minimally adapt it to get it to compile.
Then use that copy. This will work with Mylyn Tasks versions 3.7 up
to at least 3.23.0.
This is a hack. For one, the class in question is a label provider,
and the using class already fiddles with column indices to adjust
that label provider to its particular use. So a more complete fix
would be to write our own, dedicated label provider. And of course
there's no guarantee that egit-github won't break again when other
Mylyn-internal classes change.
Bug: 516148
Change-Id: I03896c43f6876821ca5cc1f95d8fcebcb05e9812
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.mylyn.github.ui/icons')
| -rw-r--r-- | org.eclipse.mylyn.github.ui/icons/etool16/person-me.gif | bin | 0 -> 307 bytes |
| -rw-r--r-- | org.eclipse.mylyn.github.ui/icons/etool16/person.gif | bin | 0 -> 308 bytes |
2 files changed, 0 insertions, 0 deletions
diff --git a/org.eclipse.mylyn.github.ui/icons/etool16/person-me.gif b/org.eclipse.mylyn.github.ui/icons/etool16/person-me.gif Binary files differnew file mode 100644 index 00000000..fa074fb8 --- /dev/null +++ b/org.eclipse.mylyn.github.ui/icons/etool16/person-me.gif diff --git a/org.eclipse.mylyn.github.ui/icons/etool16/person.gif b/org.eclipse.mylyn.github.ui/icons/etool16/person.gif Binary files differnew file mode 100644 index 00000000..dc5a1af8 --- /dev/null +++ b/org.eclipse.mylyn.github.ui/icons/etool16/person.gif |
