Only update Gists owned by currently authenticated user.

Mark description attribute as read only if not Gist owner.

Change-Id: I9881830f60c37b353e3e0b431ecb2e757206c4b0
Signed-off-by: Kevin Sawicki <kevin@github.com>

1 files changed, 37 insertions, 2 deletions

diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/gist/GistTaskDataHandler.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/gist/GistTaskDataHandler.java
index 0f837584..2e9f9565 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/gist/GistTaskDataHandler.java
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/gist/GistTaskDataHandler.java
@@ -91,6 +91,8 @@ public class GistTaskDataHandler extends GitHubTaskDataHandler {
 
 		TaskAttribute description = GistAttribute.DESCRIPTION.getMetadata()
 				.create(data);
+		description.getMetaData().setReadOnly(
+				!isOwner(repository, gist.getUser()));
 		String gistDescription = gist.getDescription();
 		if (gistDescription != null)
 			mapper.setValue(description, gistDescription);
@@ -251,8 +253,10 @@ public class GistTaskDataHandler extends GitHubTaskDataHandler {
 						.getValue();
 				if (newComment.length() > 0)
 					service.createComment(taskData.getTaskId(), newComment);
-
-				service.updateGist(gist);
+				String author = GistAttribute.AUTHOR.getMetadata().getValue(
+						taskData);
+				if (isOwner(repository, author))
+					service.updateGist(gist);
 			} catch (IOException e) {
 				throw new CoreException(GitHub.createWrappedStatus(e));
 			}
@@ -280,4 +284,35 @@ public class GistTaskDataHandler extends GitHubTaskDataHandler {
 
 		return true;
 	}
+
+	/**
+	 * Is the given Gist author the same user as configured via the task
+	 * repository's credentials?
+	 * 
+	 * @param repository
+	 * @param author
+	 * @return true if owner, false otherwise
+	 */
+	protected boolean isOwner(TaskRepository repository, User author) {
+		if (author == null)
+			return false;
+		return isOwner(repository, author.getLogin());
+	}
+
+	/**
+	 * Is the given Gist author the same user as configured via the task
+	 * repository's credentials?
+	 * 
+	 * @param repository
+	 * @param author
+	 * @return true if owner, false otherwise
+	 */
+	protected boolean isOwner(TaskRepository repository, String author) {
+		AuthenticationCredentials creds = repository
+				.getCredentials(AuthenticationType.REPOSITORY);
+		if (creds == null)
+			return false;
+		return author != null && author.length() > 0
+				&& author.equals(creds.getUserName());
+	}
 }