diff options
| author | Kevin Sawicki | 2011-09-13 06:04:11 +0000 |
|---|---|---|
| committer | Kevin Sawicki | 2011-09-13 06:04:11 +0000 |
| commit | e73eccb861ddbd1d341799d9eb9f7a34801ff533 (patch) | |
| tree | cc389e57bc55c5c6852cfd85c9637af99e82ff4b /org.eclipse.mylyn.github.core | |
| parent | 4ec01d53409de1344d35ee6d9da17a8d3023b81e (diff) | |
| download | egit-github-e73eccb861ddbd1d341799d9eb9f7a34801ff533.tar.gz egit-github-e73eccb861ddbd1d341799d9eb9f7a34801ff533.tar.xz egit-github-e73eccb861ddbd1d341799d9eb9f7a34801ff533.zip | |
Guard against null issue operation value.
This makes the operation checking more defensive in the case
that task operations are modified or removed between versions
and fail to resolve from task data.
Change-Id: I408dc213a89790a540491af7d961385e4db479d0
Signed-off-by: Kevin Sawicki <kevin@github.com>
Diffstat (limited to 'org.eclipse.mylyn.github.core')
| -rw-r--r-- | org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueTaskDataHandler.java | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueTaskDataHandler.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueTaskDataHandler.java index 83c883f8..5c2f4811 100644 --- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueTaskDataHandler.java +++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueTaskDataHandler.java @@ -350,17 +350,10 @@ public class IssueTaskDataHandler extends GitHubTaskDataHandler { if (operationAttribute != null) { IssueOperation operation = IssueOperation .fromId(operationAttribute.getValue()); - if (operation != IssueOperation.LEAVE) - switch (operation) { - case REOPEN: - issue.setState(IssueService.STATE_OPEN); - break; - case CLOSE: - issue.setState(IssueService.STATE_CLOSED); - break; - default: - break; - } + if (operation == IssueOperation.REOPEN) + issue.setState(IssueService.STATE_OPEN); + else if (operation == IssueOperation.CLOSE) + issue.setState(IssueService.STATE_CLOSED); } service.editIssue(repo.getOwner(), repo.getName(), issue); } |