Only allow collaborators or reporter to update pull requests

Change-Id: I72c059dc4834e6b066adac3ff761efb504d2513d
Signed-off-by: Kevin Sawicki <kevin@github.com>

1 files changed, 23 insertions, 18 deletions

diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
index d7f24620..a0dd2fa7 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
@@ -186,6 +186,7 @@ public class PullRequestTaskDataHandler extends GitHubTaskDataHandler {
 				.getRepositoryUrl());
 		try {
 			GitHubClient client = IssueConnector.createClient(repository);
+			boolean collaborator = isCollaborator(client, repo);
 			PullRequestService prService = new PullRequestService(client);
 			IssueService issueService = new IssueService(client);
 			if (taskData.isNew()) {
@@ -200,25 +201,29 @@ public class PullRequestTaskDataHandler extends GitHubTaskDataHandler {
 					issueService.createComment(repo.getOwner(), repo.getName(),
 							taskId, comment);
 
-				// Handle state change
-				TaskAttribute operationAttribute = taskData.getRoot()
-						.getAttribute(TaskAttribute.OPERATION);
-				if (operationAttribute != null) {
-					PullRequestOperation operation = PullRequestOperation
-							.fromId(operationAttribute.getValue());
-					if (operation != PullRequestOperation.LEAVE)
-						switch (operation) {
-						case REOPEN:
-							pr.setState(IssueService.STATE_OPEN);
-							break;
-						case CLOSE:
-							pr.setState(IssueService.STATE_CLOSED);
-							break;
-						default:
-							break;
-						}
+				boolean reporter = attributeMatchesUser(client,
+						PullRequestAttribute.REPORTER.getMetadata(), taskData);
+				if (collaborator || reporter) {
+					// Handle state change
+					TaskAttribute operationAttribute = taskData.getRoot()
+							.getAttribute(TaskAttribute.OPERATION);
+					if (operationAttribute != null) {
+						PullRequestOperation operation = PullRequestOperation
+								.fromId(operationAttribute.getValue());
+						if (operation != PullRequestOperation.LEAVE)
+							switch (operation) {
+							case REOPEN:
+								pr.setState(IssueService.STATE_OPEN);
+								break;
+							case CLOSE:
+								pr.setState(IssueService.STATE_CLOSED);
+								break;
+							default:
+								break;
+							}
+					}
+					prService.editPullRequest(repo, pr);
 				}
-				prService.editPullRequest(repo, pr);
 			}
 			return new RepositoryResponse(
 					taskData.isNew() ? ResponseKind.TASK_CREATED