diff options
| author | Thomas Wolf | 2018-11-09 18:29:51 +0000 |
|---|---|---|
| committer | Thomas Wolf | 2018-11-09 18:35:33 +0000 |
| commit | 6eb9134df7cf1d507e90928adfb1e828593b5d98 (patch) | |
| tree | 45df7ad13eb7262d17156c2fd16807ad7b2dca63 /org.eclipse.egit.github.core | |
| parent | 4334462bf7a0fb27ade3a06bcf6c82898921c043 (diff) | |
| download | egit-github-6eb9134df7cf1d507e90928adfb1e828593b5d98.tar.gz egit-github-6eb9134df7cf1d507e90928adfb1e828593b5d98.tar.xz egit-github-6eb9134df7cf1d507e90928adfb1e828593b5d98.zip | |
Fix editing issues: correct milestone attribute type
According to [1] and [2], the milestone attribute has type integer
when creating or editing issues, not string.
[1] https://developer.github.com/v3/issues/#create-an-issue
[2] https://developer.github.com/v3/issues/#edit-an-issue
Bug: 540754
Change-Id: I28553a42b6d86fd5ca1dca227ac16b23680d1ef3
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.github.core')
| -rw-r--r-- | org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java index cb59ce7b..280d86f3 100644 --- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java +++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java @@ -605,11 +605,10 @@ public class IssueService extends GitHubService { Milestone milestone = issue.getMilestone(); if (milestone != null) { int number = milestone.getNumber(); - if (number > 0) - params.put(FILTER_MILESTONE, Integer.toString(number)); - else { - if (!newIssue) - params.put(FILTER_MILESTONE, ""); //$NON-NLS-1$ + if (number > 0) { + params.put(FILTER_MILESTONE, Integer.valueOf(number)); + } else if (!newIssue) { + params.put(FILTER_MILESTONE, null); } } List<Label> labels = issue.getLabels(); |