Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Keppler2019-03-09 07:03:39 -0500
committerMichael Keppler2019-03-12 12:45:22 -0400
commita05ad984aa3bb6df1d2bcd417ba2c3ed7bf3b351 (patch)
treec67a48dcc79186f4794671e79aad54ca7cf7e092
parent512f7a8d5812cf70c7592d41d839714dc59a021d (diff)
downloadegit-github-a05ad984aa3bb6df1d2bcd417ba2c3ed7bf3b351.tar.gz
egit-github-a05ad984aa3bb6df1d2bcd417ba2c3ed7bf3b351.tar.xz
egit-github-a05ad984aa3bb6df1d2bcd417ba2c3ed7bf3b351.zip
Suppress unused warnings
Suppress unused warnings in all methods that want to evaluate a side effect of the object creation (i.e. where the unused object cannot just be removed). Change-Id: I9da8bac98fc4dcdc4353d8e257a610fb338dd38c Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java4
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistAttachmentPart.java1
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java1
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java1
4 files changed, 6 insertions, 1 deletions
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java
index d2f90dc5..4ada1930 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java
@@ -28,7 +28,7 @@ public abstract class HttpRepositorySettingsPage extends
/**
* Create repository settings page
- *
+ *
* @param title
* @param description
* @param taskRepository
@@ -44,6 +44,7 @@ public abstract class HttpRepositorySettingsPage extends
setNeedsHttpAuth(false);
}
+ @SuppressWarnings("unused")
@Override
protected boolean isValidUrl(final String url) {
if (url.startsWith("http://") || url.startsWith("https://")) //$NON-NLS-1$ //$NON-NLS-2$
@@ -59,6 +60,7 @@ public abstract class HttpRepositorySettingsPage extends
/**
* @see org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositorySettingsPage#canValidate()
*/
+ @Override
public boolean canValidate() {
return isPageComplete()
&& (getMessage() == null || getMessageType() != IMessageProvider.ERROR);
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistAttachmentPart.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistAttachmentPart.java
index 82e26477..6e336cfd 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistAttachmentPart.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistAttachmentPart.java
@@ -158,6 +158,7 @@ public class GistAttachmentPart extends AbstractTaskEditorPart {
super.dispose();
}
+ @SuppressWarnings("unused")
private void createAttachmentTable(FormToolkit toolkit,
final Composite attachmentsComposite) {
attachmentsTable = toolkit.createTable(attachmentsComposite, SWT.MULTI
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java
index c589f00d..c8eb95ee 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java
@@ -77,6 +77,7 @@ public class GistRepositorySettingsPage extends AbstractRepositorySettingsPage {
/**
* @see org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositorySettingsPage#isValidUrl(java.lang.String)
*/
+ @SuppressWarnings("unused")
@Override
protected boolean isValidUrl(String url) {
if (url.startsWith("http://") || url.startsWith("https://")) //$NON-NLS-1$ //$NON-NLS-2$
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java
index 5e01c87b..805fa210 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java
@@ -167,6 +167,7 @@ public class IssueRepositorySettingsPage extends AbstractRepositorySettingsPage
return validator;
}
+ @SuppressWarnings("unused")
@Override
protected boolean isValidUrl(final String url) {
if (url.startsWith("http://") || url.startsWith("https://")) //$NON-NLS-1$ //$NON-NLS-2$

Back to the top