Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Keppler2018-10-08 03:10:48 -0400
committerMichael Keppler2018-10-08 03:10:48 -0400
commit6228786e3ff33faea49550e1fcf57e51f31e8950 (patch)
treed8038dbe019066df33d1edf1fa051331f01c818a
parent90a14ca471277f527848ea0411ef5697f572d65c (diff)
downloadegit-github-6228786e3ff33faea49550e1fcf57e51f31e8950.tar.gz
egit-github-6228786e3ff33faea49550e1fcf57e51f31e8950.tar.xz
egit-github-6228786e3ff33faea49550e1fcf57e51f31e8950.zip
minor: fix all empty block warnings
Comment all empty blocks to get rid of the many warnings. Either comment as empty or as visibility change. There is no functional change. Changes outside adding comments in empty blocks are all due to format on save. Change-Id: Ie42e97cfe1d418bdfb9a5293ff7d3a8d01dbdb82 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CollaboratorService.java1
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java4
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/ContentsService.java1
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DataService.java13
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DeployKeyService.java1
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DownloadService.java7
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/EventService.java7
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/GistService.java4
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java5
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/LabelService.java2
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/MilestoneService.java1
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OAuthService.java1
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OrganizationService.java3
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/PullRequestService.java12
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java10
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/StargazerService.java7
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/TeamService.java12
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/UserService.java4
-rw-r--r--org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/RepositoryConnector.java5
-rw-r--r--org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java1
-rwxr-xr-xorg.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositoryImportWizard.java5
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySearchWizardPage.java2
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySelectionWizardPage.java2
-rw-r--r--org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/TaskRepositoryImportWizard.java6
24 files changed, 96 insertions, 20 deletions
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CollaboratorService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CollaboratorService.java
index 931aca6e..3dc26a01 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CollaboratorService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CollaboratorService.java
@@ -65,6 +65,7 @@ public class CollaboratorService extends GitHubService {
PagedRequest<User> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java
index 2a923885..5e271acd 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java
@@ -144,6 +144,7 @@ public class CommitService extends GitHubService {
size);
request.setUri(uri);
request.setType(new TypeToken<List<RepositoryCommit>>() {
+ // make protected type visible
}.getType());
if (sha != null || path != null) {
@@ -284,6 +285,7 @@ public class CommitService extends GitHubService {
PagedRequest<CommitComment> request = createPagedRequest(start, size);
request.setUri(uri);
request.setType(new TypeToken<List<CommitComment>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -465,6 +467,7 @@ public class CommitService extends GitHubService {
uri.append('/').append(sha);
PagedRequest<CommitStatus> request = createPagedRequest();
request.setType(new TypeToken<List<CommitStatus>>() {
+ // make protected type visible
}.getType());
request.setUri(uri);
return getAll(request);
@@ -560,6 +563,7 @@ public class CommitService extends GitHubService {
PagedRequest<CommitComment> request = createPagedRequest(start, size);
request.setUri(uri);
request.setType(new TypeToken<List<CommitComment>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/ContentsService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/ContentsService.java
index 53fa12bc..a9f8bf5e 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/ContentsService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/ContentsService.java
@@ -141,6 +141,7 @@ public class ContentsService extends GitHubService {
request.setUri(uri);
request.setType(RepositoryContents.class);
request.setArrayType(new TypeToken<List<RepositoryContents>>() {
+ // make protected type visible
}.getType());
if (ref != null && ref.length() > 0)
request.setParams(Collections.singletonMap("ref", ref)); //$NON-NLS-1$
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DataService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DataService.java
index 928c18df..439b12ec 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DataService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DataService.java
@@ -197,7 +197,7 @@ public class DataService extends GitHubService {
GitHubRequest request = createRequest();
request.setType(Tree.class);
request.setUri(uri);
- Map<String, Object> params = new HashMap<String, Object>();
+ Map<String, Object> params = new HashMap<>();
if (entries != null)
params.put("tree", entries.toArray()); //$NON-NLS-1$
if (baseTree != null)
@@ -251,6 +251,7 @@ public class DataService extends GitHubService {
uri.append(SEGMENT_REFS);
PagedRequest<Reference> request = createPagedRequest();
request.setType(new TypeToken<List<Reference>>() {
+ // make protected type visible
}.getType());
request.setUri(uri);
return getAll(request);
@@ -279,7 +280,7 @@ public class DataService extends GitHubService {
uri.append('/').append(id);
uri.append(SEGMENT_GIT);
uri.append(SEGMENT_REFS);
- Map<String, String> params = new HashMap<String, String>();
+ Map<String, String> params = new HashMap<>();
params.put("sha", object.getSha()); //$NON-NLS-1$
params.put("ref", reference.getRef()); //$NON-NLS-1$
return client.post(uri.toString(), params, Reference.class);
@@ -328,7 +329,7 @@ public class DataService extends GitHubService {
if (!ref.startsWith("refs/")) //$NON-NLS-1$
uri.append(SEGMENT_REFS);
uri.append('/').append(ref);
- Map<String, Object> params = new HashMap<String, Object>();
+ Map<String, Object> params = new HashMap<>();
params.put("sha", object.getSha()); //$NON-NLS-1$
if (force)
params.put("force", true); //$NON-NLS-1$
@@ -382,13 +383,13 @@ public class DataService extends GitHubService {
uri.append('/').append(id);
uri.append(SEGMENT_GIT);
uri.append(SEGMENT_COMMITS);
- Map<String, Object> params = new HashMap<String, Object>();
+ Map<String, Object> params = new HashMap<>();
params.put("author", commit.getAuthor()); //$NON-NLS-1$
params.put("committer", commit.getCommitter()); //$NON-NLS-1$
params.put("message", commit.getMessage()); //$NON-NLS-1$
List<Commit> parents = commit.getParents();
if (parents != null && parents.size() > 0) {
- List<String> parentIds = new ArrayList<String>();
+ List<String> parentIds = new ArrayList<>();
for (Commit parent : parents)
parentIds.add(parent.getSha());
params.put("parents", parentIds); //$NON-NLS-1$
@@ -446,7 +447,7 @@ public class DataService extends GitHubService {
uri.append('/').append(id);
uri.append(SEGMENT_GIT);
uri.append(SEGMENT_TAGS);
- Map<String, Object> params = new HashMap<String, Object>();
+ Map<String, Object> params = new HashMap<>();
params.put("tag", tag.getTag()); //$NON-NLS-1$
params.put("message", tag.getMessage()); //$NON-NLS-1$
TypedResource object = tag.getObject();
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DeployKeyService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DeployKeyService.java
index 0bd0b019..3ba920de 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DeployKeyService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DeployKeyService.java
@@ -66,6 +66,7 @@ public class DeployKeyService extends GitHubService {
PagedRequest<Key> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Key>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DownloadService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DownloadService.java
index 2a22719a..7db076cc 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DownloadService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/DownloadService.java
@@ -18,6 +18,8 @@ import static org.eclipse.egit.github.core.client.IGitHubConstants.SEGMENT_REPOS
import static org.eclipse.egit.github.core.client.PagedRequest.PAGE_FIRST;
import static org.eclipse.egit.github.core.client.PagedRequest.PAGE_SIZE;
+import com.google.gson.reflect.TypeToken;
+
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
@@ -36,8 +38,6 @@ import org.eclipse.egit.github.core.client.PageIterator;
import org.eclipse.egit.github.core.client.PagedRequest;
import org.eclipse.egit.github.core.util.MultiPartUtils;
-import com.google.gson.reflect.TypeToken;
-
/**
* Service for accessing, creating, and deleting repositories downloads.
*
@@ -144,6 +144,7 @@ public class DownloadService extends GitHubService {
uri.append(SEGMENT_DOWNLOADS);
PagedRequest<Download> request = createPagedRequest(start, size);
request.setType(new TypeToken<List<Download>>() {
+ // make protected type visible
}.getType());
request.setUri(uri);
return request;
@@ -251,7 +252,7 @@ public class DownloadService extends GitHubService {
throw new IllegalArgumentException(
"Content input stream cannot be null"); //$NON-NLS-1$
- Map<String, Object> parts = new LinkedHashMap<String, Object>();
+ Map<String, Object> parts = new LinkedHashMap<>();
parts.put(UPLOAD_KEY, resource.getPath());
parts.put(UPLOAD_ACL, resource.getAcl());
parts.put(UPLOAD_SUCCESS_ACTION_STATUS, Integer.toString(HTTP_CREATED));
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/EventService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/EventService.java
index f783d56f..7bc94d79 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/EventService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/EventService.java
@@ -91,6 +91,7 @@ public class EventService extends GitHubService {
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(SEGMENT_EVENTS);
request.setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -390,6 +391,7 @@ public class EventService extends GitHubService {
uri.append(SEGMENT_EVENTS);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -412,6 +414,7 @@ public class EventService extends GitHubService {
uri.append(SEGMENT_EVENTS);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -433,6 +436,7 @@ public class EventService extends GitHubService {
uri.append(SEGMENT_EVENTS);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -458,6 +462,7 @@ public class EventService extends GitHubService {
uri.append(SEGMENT_PUBLIC);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -483,6 +488,7 @@ public class EventService extends GitHubService {
uri.append(SEGMENT_PUBLIC);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -506,6 +512,7 @@ public class EventService extends GitHubService {
uri.append('/').append(org);
PagedRequest<Event> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Event>>() {
+ // make protected type visible
}.getType());
return request;
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/GistService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/GistService.java
index ae00cfbe..8c97d1e5 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/GistService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/GistService.java
@@ -126,6 +126,7 @@ public class GistService extends GitHubService {
PagedRequest<Gist> request = createPagedRequest(start, size);
request.setUri(SEGMENT_GISTS + SEGMENT_STARRED);
request.setType(new TypeToken<List<Gist>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -160,6 +161,7 @@ public class GistService extends GitHubService {
uri.append(SEGMENT_GISTS);
PagedRequest<Gist> request = createPagedRequest(start, size);
request.setUri(uri).setType(new TypeToken<List<Gist>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -246,6 +248,7 @@ public class GistService extends GitHubService {
PagedRequest<Gist> request = createPagedRequest(start, size);
request.setUri(SEGMENT_GISTS + SEGMENT_PUBLIC);
request.setType(new TypeToken<List<Gist>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -320,6 +323,7 @@ public class GistService extends GitHubService {
uri.append(SEGMENT_COMMENTS);
PagedRequest<Comment> request = createPagedRequest();
request.setUri(uri).setType(new TypeToken<List<Comment>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
index 09589f70..cb59ce7b 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
@@ -259,6 +259,7 @@ public class IssueService extends GitHubService {
request.setParams(filterData);
request.setUri(SEGMENT_ISSUES);
request.setType(new TypeToken<List<RepositoryIssue>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -418,6 +419,7 @@ public class IssueService extends GitHubService {
PagedRequest<Comment> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Comment>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -439,6 +441,7 @@ public class IssueService extends GitHubService {
PagedRequest<Issue> request = createPagedRequest(start, size);
request.setParams(filterData).setUri(uri);
request.setType(new TypeToken<List<Issue>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -1008,6 +1011,7 @@ public class IssueService extends GitHubService {
uri.append(SEGMENT_EVENTS);
request.setUri(uri);
request.setType(new TypeToken<List<IssueEvent>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -1061,6 +1065,7 @@ public class IssueService extends GitHubService {
uri.append(SEGMENT_EVENTS);
request.setUri(uri);
request.setType(new TypeToken<List<IssueEvent>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/LabelService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/LabelService.java
index 0c7a1e54..feaa5cf2 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/LabelService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/LabelService.java
@@ -88,6 +88,7 @@ public class LabelService extends GitHubService {
PagedRequest<Label> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Label>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -139,6 +140,7 @@ public class LabelService extends GitHubService {
uri.append(SEGMENT_LABELS);
return client.put(uri.toString(), labels, new TypeToken<List<Label>>() {
+ // make protected type visible
}.getType());
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/MilestoneService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/MilestoneService.java
index eca3e6cb..a6546f48 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/MilestoneService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/MilestoneService.java
@@ -95,6 +95,7 @@ public class MilestoneService extends GitHubService {
request.setParams(Collections.singletonMap(
IssueService.FILTER_STATE, state));
request.setUri(uri).setType(new TypeToken<List<Milestone>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OAuthService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OAuthService.java
index 3abc9e17..34280563 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OAuthService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OAuthService.java
@@ -61,6 +61,7 @@ public class OAuthService extends GitHubService {
PagedRequest<Authorization> request = createPagedRequest();
request.setUri(SEGMENT_AUTHORIZATIONS);
request.setType(new TypeToken<List<Authorization>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OrganizationService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OrganizationService.java
index fb0769a2..52b0ed8f 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OrganizationService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/OrganizationService.java
@@ -90,6 +90,7 @@ public class OrganizationService extends GitHubService {
request.setUri(uri);
}
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -213,6 +214,7 @@ public class OrganizationService extends GitHubService {
request.setParams(params);
request.setUri(uri);
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -236,6 +238,7 @@ public class OrganizationService extends GitHubService {
PagedRequest<User> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/PullRequestService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/PullRequestService.java
index b8bd2206..41f4b275 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/PullRequestService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/PullRequestService.java
@@ -137,6 +137,7 @@ public class PullRequestService extends GitHubService {
request.setParams(Collections.singletonMap(
IssueService.FILTER_STATE, state));
request.setType(new TypeToken<List<PullRequest>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -196,7 +197,7 @@ public class PullRequestService extends GitHubService {
}
private Map<String, String> createPrMap(PullRequest request) {
- Map<String, String> params = new HashMap<String, String>();
+ Map<String, String> params = new HashMap<>();
if (request != null) {
String title = request.getTitle();
if (title != null)
@@ -221,7 +222,7 @@ public class PullRequestService extends GitHubService {
}
private Map<String, String> editPrMap(PullRequest request) {
- Map<String, String> params = new HashMap<String, String>();
+ Map<String, String> params = new HashMap<>();
String title = request.getTitle();
if (title != null)
params.put(PR_TITLE, title);
@@ -269,7 +270,7 @@ public class PullRequestService extends GitHubService {
StringBuilder uri = new StringBuilder(SEGMENT_REPOS);
uri.append('/').append(id);
uri.append(SEGMENT_PULLS);
- Map<String, Object> params = new HashMap<String, Object>();
+ Map<String, Object> params = new HashMap<>();
params.put("issue", issueId); //$NON-NLS-1$
params.put("head", head); //$NON-NLS-1$
params.put("base", base); //$NON-NLS-1$
@@ -317,6 +318,7 @@ public class PullRequestService extends GitHubService {
PagedRequest<RepositoryCommit> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<RepositoryCommit>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -340,6 +342,7 @@ public class PullRequestService extends GitHubService {
PagedRequest<CommitFile> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<CommitFile>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -443,6 +446,7 @@ public class PullRequestService extends GitHubService {
PagedRequest<CommitComment> request = createPagedRequest(start, size);
request.setUri(uri);
request.setType(new TypeToken<List<CommitComment>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -508,7 +512,7 @@ public class PullRequestService extends GitHubService {
uri.append(SEGMENT_PULLS);
uri.append('/').append(pullRequestId);
uri.append(SEGMENT_COMMENTS);
- Map<String, String> params = new HashMap<String, String>();
+ Map<String, String> params = new HashMap<>();
params.put("in_reply_to", Integer.toString(commentId)); //$NON-NLS-1$
params.put("body", body); //$NON-NLS-1$
return client.post(uri.toString(), params, CommitComment.class);
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
index 2fad529b..7a056224 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
@@ -231,6 +231,7 @@ public class RepositoryService extends GitHubService {
request.setUri(SEGMENT_USER + SEGMENT_REPOS);
request.setParams(filterData);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -257,6 +258,7 @@ public class RepositoryService extends GitHubService {
request.setParams(Collections.singletonMap("since", //$NON-NLS-1$
Long.toString(since)));
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -314,6 +316,7 @@ public class RepositoryService extends GitHubService {
PagedRequest<Repository> request = createPagedRequest(start, size);
request.setUri(uri);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -426,6 +429,7 @@ public class RepositoryService extends GitHubService {
request.setParams(filterData);
request.setUri(uri);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return createPageIterator(request);
}
@@ -626,6 +630,7 @@ public class RepositoryService extends GitHubService {
PagedRequest<Repository> request = createPagedRequest(start, size);
request.setUri(uri);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -791,6 +796,7 @@ public class RepositoryService extends GitHubService {
GitHubRequest request = createRequest();
request.setUri(uri);
request.setType(new TypeToken<Map<String, Long>>() {
+ // make protected type visible
}.getType());
return (Map<String, Long>) client.get(request).getBody();
}
@@ -811,6 +817,7 @@ public class RepositoryService extends GitHubService {
PagedRequest<RepositoryBranch> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<RepositoryBranch>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -831,6 +838,7 @@ public class RepositoryService extends GitHubService {
PagedRequest<RepositoryTag> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<RepositoryTag>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -854,6 +862,7 @@ public class RepositoryService extends GitHubService {
if (includeAnonymous)
request.setParams(Collections.singletonMap("anon", "1")); //$NON-NLS-1$ //$NON-NLS-2$
request.setType(new TypeToken<List<Contributor>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -874,6 +883,7 @@ public class RepositoryService extends GitHubService {
PagedRequest<RepositoryHook> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<RepositoryHook>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/StargazerService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/StargazerService.java
index ee866c93..3d7d61ca 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/StargazerService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/StargazerService.java
@@ -20,6 +20,8 @@ import static org.eclipse.egit.github.core.client.IGitHubConstants.SEGMENT_USERS
import static org.eclipse.egit.github.core.client.PagedRequest.PAGE_FIRST;
import static org.eclipse.egit.github.core.client.PagedRequest.PAGE_SIZE;
+import com.google.gson.reflect.TypeToken;
+
import java.io.IOException;
import java.util.List;
@@ -30,8 +32,6 @@ import org.eclipse.egit.github.core.client.GitHubClient;
import org.eclipse.egit.github.core.client.PageIterator;
import org.eclipse.egit.github.core.client.PagedRequest;
-import com.google.gson.reflect.TypeToken;
-
/**
* Service class for dealing with users starring GitHub repositories.
*
@@ -74,6 +74,7 @@ public class StargazerService extends GitHubService {
uri.append(SEGMENT_STARGAZERS);
request.setUri(uri);
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -150,6 +151,7 @@ public class StargazerService extends GitHubService {
uri.append(SEGMENT_STARRED);
request.setUri(uri);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -165,6 +167,7 @@ public class StargazerService extends GitHubService {
PagedRequest<Repository> request = createPagedRequest(start, size);
request.setUri(SEGMENT_USER + SEGMENT_STARRED);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return request;
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/TeamService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/TeamService.java
index 55af8280..28c9d45b 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/TeamService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/TeamService.java
@@ -23,6 +23,8 @@ import static org.eclipse.egit.github.core.client.IGitHubConstants.SEGMENT_REPOS
import static org.eclipse.egit.github.core.client.IGitHubConstants.SEGMENT_TEAMS;
import static org.eclipse.egit.github.core.client.IGitHubConstants.SEGMENT_USER;
+import com.google.gson.reflect.TypeToken;
+
import java.io.IOException;
import java.util.HashMap;
import java.util.List;
@@ -37,8 +39,6 @@ import org.eclipse.egit.github.core.client.GitHubClient;
import org.eclipse.egit.github.core.client.GitHubRequest;
import org.eclipse.egit.github.core.client.PagedRequest;
-import com.google.gson.reflect.TypeToken;
-
/**
* Service class for working with organization teams
*
@@ -98,6 +98,7 @@ public class TeamService extends GitHubService {
PagedRequest<Team> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Team>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -186,6 +187,7 @@ public class TeamService extends GitHubService {
PagedRequest<User> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -344,6 +346,7 @@ public class TeamService extends GitHubService {
PagedRequest<Repository> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Repository>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -416,6 +419,7 @@ public class TeamService extends GitHubService {
PagedRequest<Team> request = createPagedRequest();
request.setUri(uri);
request.setType(new TypeToken<List<Team>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -430,7 +434,9 @@ public class TeamService extends GitHubService {
StringBuilder uri = new StringBuilder(SEGMENT_USER).append(SEGMENT_TEAMS);
PagedRequest<Team> request = createPagedRequest();
request.setUri(uri);
- request.setType(new TypeToken<List<Team>>(){}.getType());
+ request.setType(new TypeToken<List<Team>>() {
+ // make protected type visible
+ }.getType());
return getAll(request);
}
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/UserService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/UserService.java
index 583b8f52..be65a60d 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/UserService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/UserService.java
@@ -131,6 +131,7 @@ public class UserService extends GitHubService {
request.setUri(uri);
}
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -155,6 +156,7 @@ public class UserService extends GitHubService {
request.setUri(uri);
}
request.setType(new TypeToken<List<User>>() {
+ // make protected type visible
}.getType());
return request;
}
@@ -405,6 +407,7 @@ public class UserService extends GitHubService {
PagedRequest<String> request = createPagedRequest();
request.setUri(SEGMENT_USER + SEGMENT_EMAILS);
request.setType(new TypeToken<List<String>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
@@ -451,6 +454,7 @@ public class UserService extends GitHubService {
PagedRequest<Key> request = createPagedRequest();
request.setUri(SEGMENT_USER + SEGMENT_KEYS);
request.setType(new TypeToken<List<Key>>() {
+ // make protected type visible
}.getType());
return getAll(request);
}
diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/RepositoryConnector.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/RepositoryConnector.java
index 970896cd..5a837e79 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/RepositoryConnector.java
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/RepositoryConnector.java
@@ -27,14 +27,17 @@ import org.eclipse.mylyn.tasks.core.data.TaskMapper;
*/
public abstract class RepositoryConnector extends AbstractRepositoryConnector {
+ @Override
public boolean canCreateNewTask(TaskRepository repository) {
return true;
}
+ @Override
public boolean canCreateTaskFromKey(TaskRepository repository) {
return true;
}
+ @Override
public boolean hasTaskChanged(TaskRepository taskRepository, ITask task,
TaskData taskData) {
Date dataDate = getTaskMapping(taskData).getModificationDate();
@@ -42,8 +45,10 @@ public abstract class RepositoryConnector extends AbstractRepositoryConnector {
return dataDate == null || !dataDate.equals(taskDate);
}
+ @Override
public void updateRepositoryConfiguration(TaskRepository taskRepository,
IProgressMonitor monitor) throws CoreException {
+ // empty
}
@Override
diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
index 0d680746..cb69a64c 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/pr/PullRequestTaskDataHandler.java
@@ -50,6 +50,7 @@ public class PullRequestTaskDataHandler extends GitHubTaskDataHandler {
* @param connector
*/
public PullRequestTaskDataHandler(PullRequestConnector connector) {
+ // empty
}
/**
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositoryImportWizard.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositoryImportWizard.java
index 9772e962..adc06c6d 100755
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositoryImportWizard.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositoryImportWizard.java
@@ -65,7 +65,9 @@ public class RepositoryImportWizard extends Wizard implements IImportWizard {
/**
* {@inheritDoc}
*/
+ @Override
public void init(IWorkbench workbench, IStructuredSelection selection) {
+ // empty
}
/**
@@ -106,6 +108,7 @@ public class RepositoryImportWizard extends Wizard implements IImportWizard {
repositories.length)
: Messages.RepositoryImportWizard_CloningRepository;
Job job = new Job(name) {
+ @Override
protected IStatus run(IProgressMonitor monitor) {
monitor.beginTask(
Messages.RepositoryImportWizard_CloningRepository,
@@ -150,7 +153,7 @@ public class RepositoryImportWizard extends Wizard implements IImportWizard {
return Status.OK_STATUS;
}
};
- IWorkbenchSiteProgressService progress = (IWorkbenchSiteProgressService) PlatformUI
+ IWorkbenchSiteProgressService progress = PlatformUI
.getWorkbench().getService(IWorkbenchSiteProgressService.class);
if (progress != null)
progress.schedule(job);
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySearchWizardPage.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySearchWizardPage.java
index 81c9635a..45643bcd 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySearchWizardPage.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySearchWizardPage.java
@@ -139,6 +139,7 @@ public class RepositorySearchWizardPage extends WizardPage implements
@Override
public void removeListener(ILabelProviderListener listener) {
+ // empty
}
@Override
@@ -154,6 +155,7 @@ public class RepositorySearchWizardPage extends WizardPage implements
@Override
public void addListener(ILabelProviderListener listener) {
+ // empty
}
@Override
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySelectionWizardPage.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySelectionWizardPage.java
index 26c8d47c..620bd4f5 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySelectionWizardPage.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/RepositorySelectionWizardPage.java
@@ -79,6 +79,7 @@ public class RepositorySelectionWizardPage extends WizardPage {
@Override
public void addListener(ILabelProviderListener listener) {
+ // empty
}
@Override
@@ -93,6 +94,7 @@ public class RepositorySelectionWizardPage extends WizardPage {
@Override
public void removeListener(ILabelProviderListener listener) {
+ // empty
}
@Override
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/TaskRepositoryImportWizard.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/TaskRepositoryImportWizard.java
index 91ead424..17368550 100644
--- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/TaskRepositoryImportWizard.java
+++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/TaskRepositoryImportWizard.java
@@ -56,6 +56,7 @@ public class TaskRepositoryImportWizard extends Wizard implements IImportWizard
/**
* @see org.eclipse.jface.wizard.Wizard#addPages()
*/
+ @Override
public void addPages() {
credentialsPage = new CredentialsWizardPage();
addPage(credentialsPage);
@@ -66,6 +67,7 @@ public class TaskRepositoryImportWizard extends Wizard implements IImportWizard
/**
* @see org.eclipse.jface.wizard.Wizard#getNextPage(org.eclipse.jface.wizard.IWizardPage)
*/
+ @Override
public IWizardPage getNextPage(IWizardPage page) {
IWizardPage next = super.getNextPage(page);
if (next == reposPage) {
@@ -79,13 +81,15 @@ public class TaskRepositoryImportWizard extends Wizard implements IImportWizard
* @see org.eclipse.ui.IWorkbenchWizard#init(org.eclipse.ui.IWorkbench,
* org.eclipse.jface.viewers.IStructuredSelection)
*/
+ @Override
public void init(IWorkbench workbench, IStructuredSelection selection) {
-
+ // empty
}
/**
* @see org.eclipse.jface.wizard.Wizard#performFinish()
*/
+ @Override
public boolean performFinish() {
String user = credentialsPage.getUserName();
String password = credentialsPage.getPassword();

Back to the top