Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Sawicki2012-05-03 11:55:36 -0400
committerKevin Sawicki2012-05-03 11:55:36 -0400
commite876b9847b536e89c0be0147d79fdca84a0dac12 (patch)
tree91cb404f82c20717fe9df2963cbfe739f0aa4275
parent2af7e007686a898e511bbb7dc21c6948bb358f2f (diff)
downloadegit-github-e876b9847b536e89c0be0147d79fdca84a0dac12.tar.gz
egit-github-e876b9847b536e89c0be0147d79fdca84a0dac12.tar.xz
egit-github-e876b9847b536e89c0be0147d79fdca84a0dac12.zip
Removes throws IOException declaration from page calls
These don't actually throw exceptions and were declared this way mistakenly in the initial implementation Change-Id: Ib2bb903f02881a5b840558219462e528cbb42c12
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java20
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java32
-rw-r--r--org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/WatcherService.java10
3 files changed, 18 insertions, 44 deletions
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
index aee17b14..71888ecf 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/IssueService.java
@@ -951,10 +951,8 @@ public class IssueService extends GitHubService {
* @param user
* @param repository
* @return iterator over issue event pages
- * @throws IOException
*/
- public PageIterator<IssueEvent> pageEvents(String user, String repository)
- throws IOException {
+ public PageIterator<IssueEvent> pageEvents(String user, String repository) {
return pageEvents(user, repository, PAGE_SIZE);
}
@@ -965,10 +963,9 @@ public class IssueService extends GitHubService {
* @param repository
* @param size
* @return iterator over issue event pages
- * @throws IOException
*/
public PageIterator<IssueEvent> pageEvents(String user, String repository,
- int size) throws IOException {
+ int size) {
return pageEvents(user, repository, PAGE_FIRST, size);
}
@@ -980,10 +977,9 @@ public class IssueService extends GitHubService {
* @param start
* @param size
* @return iterator over issue event pages
- * @throws IOException
*/
public PageIterator<IssueEvent> pageEvents(String user, String repository,
- int start, int size) throws IOException {
+ int start, int size) {
verifyRepository(user, repository);
PagedRequest<IssueEvent> request = createPagedRequest(start, size);
@@ -1004,10 +1000,9 @@ public class IssueService extends GitHubService {
* @param repository
* @param issueId
* @return iterator over issue event pages
- * @throws IOException
*/
public PageIterator<IssueEvent> pageIssueEvents(String user,
- String repository, int issueId) throws IOException {
+ String repository, int issueId) {
return pageIssueEvents(user, repository, issueId, PAGE_SIZE);
}
@@ -1019,10 +1014,9 @@ public class IssueService extends GitHubService {
* @param issueId
* @param size
* @return iterator over issue event pages
- * @throws IOException
*/
public PageIterator<IssueEvent> pageIssueEvents(String user,
- String repository, int issueId, int size) throws IOException {
+ String repository, int issueId, int size) {
return pageIssueEvents(user, repository, issueId, PAGE_FIRST, size);
}
@@ -1035,11 +1029,9 @@ public class IssueService extends GitHubService {
* @param start
* @param size
* @return iterator over issue event pages
- * @throws IOException
*/
public PageIterator<IssueEvent> pageIssueEvents(String user,
- String repository, int issueId, int start, int size)
- throws IOException {
+ String repository, int issueId, int start, int size) {
verifyRepository(user, repository);
PagedRequest<IssueEvent> request = createPagedRequest(start, size);
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
index d77069f0..75817acc 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java
@@ -164,9 +164,8 @@ public class RepositoryService extends GitHubService {
* Page repositories for currently authenticated user
*
* @return iterator over pages of repositories
- * @throws IOException
*/
- public PageIterator<Repository> pageRepositories() throws IOException {
+ public PageIterator<Repository> pageRepositories() {
return pageRepositories(PAGE_SIZE);
}
@@ -175,10 +174,8 @@ public class RepositoryService extends GitHubService {
*
* @param size
* @return iterator over pages of repositories
- * @throws IOException
*/
- public PageIterator<Repository> pageRepositories(int size)
- throws IOException {
+ public PageIterator<Repository> pageRepositories(int size) {
return pageRepositories(PAGE_FIRST, size);
}
@@ -188,10 +185,8 @@ public class RepositoryService extends GitHubService {
* @param start
* @param size
* @return iterator over pages of repositories
- * @throws IOException
*/
- public PageIterator<Repository> pageRepositories(int start, int size)
- throws IOException {
+ public PageIterator<Repository> pageRepositories(int start, int size) {
return pageRepositories((Map<String, String>) null, start, size);
}
@@ -200,10 +195,9 @@ public class RepositoryService extends GitHubService {
*
* @param filterData
* @return iterator over pages of repositories
- * @throws IOException
*/
public PageIterator<Repository> pageRepositories(
- Map<String, String> filterData) throws IOException {
+ Map<String, String> filterData) {
return pageRepositories(filterData, PAGE_SIZE);
}
@@ -213,10 +207,9 @@ public class RepositoryService extends GitHubService {
* @param filterData
* @param size
* @return iterator over pages of repositories
- * @throws IOException
*/
public PageIterator<Repository> pageRepositories(
- Map<String, String> filterData, int size) throws IOException {
+ Map<String, String> filterData, int size) {
return pageRepositories(filterData, PAGE_FIRST, size);
}
@@ -227,11 +220,9 @@ public class RepositoryService extends GitHubService {
* @param start
* @param size
* @return iterator over pages of repositories
- * @throws IOException
*/
public PageIterator<Repository> pageRepositories(
- Map<String, String> filterData, int start, int size)
- throws IOException {
+ Map<String, String> filterData, int start, int size) {
PagedRequest<Repository> request = createPagedRequest(start, size);
request.setUri(SEGMENT_USER + SEGMENT_REPOS);
request.setParams(filterData);
@@ -256,10 +247,8 @@ public class RepositoryService extends GitHubService {
*
* @param user
* @return iterator over pages of repositories
- * @throws IOException
*/
- public PageIterator<Repository> pageRepositories(String user)
- throws IOException {
+ public PageIterator<Repository> pageRepositories(String user) {
return pageRepositories(user, PAGE_SIZE);
}
@@ -269,10 +258,8 @@ public class RepositoryService extends GitHubService {
* @param user
* @param size
* @return iterator over pages of repositories
- * @throws IOException
*/
- public PageIterator<Repository> pageRepositories(String user, int size)
- throws IOException {
+ public PageIterator<Repository> pageRepositories(String user, int size) {
return pageRepositories(user, PAGE_FIRST, size);
}
@@ -283,10 +270,9 @@ public class RepositoryService extends GitHubService {
* @param start
* @param size
* @return iterator over repository page
- * @throws IOException
*/
public PageIterator<Repository> pageRepositories(String user, int start,
- int size) throws IOException {
+ int size) {
if (user == null)
throw new IllegalArgumentException("User cannot be null"); //$NON-NLS-1$
if (user.length() == 0)
diff --git a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/WatcherService.java b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/WatcherService.java
index df6c256b..a341ded5 100644
--- a/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/WatcherService.java
+++ b/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/WatcherService.java
@@ -94,10 +94,8 @@ public class WatcherService extends GitHubService {
*
* @param repository
* @return page iterator
- * @throws IOException
*/
- public PageIterator<User> pageWatchers(IRepositoryIdProvider repository)
- throws IOException {
+ public PageIterator<User> pageWatchers(IRepositoryIdProvider repository) {
return pageWatchers(repository, PAGE_SIZE);
}
@@ -107,10 +105,9 @@ public class WatcherService extends GitHubService {
* @param repository
* @param size
* @return page iterator
- * @throws IOException
*/
public PageIterator<User> pageWatchers(IRepositoryIdProvider repository,
- int size) throws IOException {
+ int size) {
return pageWatchers(repository, PAGE_FIRST, size);
}
@@ -121,10 +118,9 @@ public class WatcherService extends GitHubService {
* @param start
* @param size
* @return page iterator
- * @throws IOException
*/
public PageIterator<User> pageWatchers(IRepositoryIdProvider repository,
- int start, int size) throws IOException {
+ int start, int size) {
PagedRequest<User> request = createWatcherRequest(repository, start,
size);
return createPageIterator(request);

Back to the top