Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Schindl2016-02-19 13:18:19 -0500
committerTom Schindl2016-02-19 13:18:19 -0500
commitc82c996ca782fb04db7c2f281a07f7fa3fc796c5 (patch)
treecc9c8161f19a901da39e604e20b35552202c900e
parent346918c4c741ae2c2fd05285a22cfb95020a8176 (diff)
downloadorg.eclipse.efxclipse-codeeditor.tar.gz
org.eclipse.efxclipse-codeeditor.tar.xz
org.eclipse.efxclipse-codeeditor.zip
Bug 488008 - StyledTextArea annotation supportcodeeditor
-rw-r--r--bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java4
-rw-r--r--bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java2
2 files changed, 3 insertions, 3 deletions
diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java
index b147bd8db..d9698bc55 100644
--- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java
+++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java
@@ -22,8 +22,8 @@ public class NodeCachePane extends Pane {
}
node.setVisible(true);
});
- cache.addOnRelease(node->node.setVisible(false));
- cache.addOnClear(node->getChildren().remove(node));
+ cache.addOnRelease( node -> getChildren().remove(node)); // FIXME modified by Tom leads to more and more text instances in AnnotationOverlay
+ cache.addOnClear( node -> getChildren().remove(node));
}
protected Node getNode() {
diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java
index c47957e18..e32e5ba6f 100644
--- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java
+++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java
@@ -51,7 +51,7 @@ public class ReuseCache<T> {
public void releaseElement(T element) {
active.remove(element);
onRelease.forEach(a->a.accept(element));
- free.push(element);
+// free.push(element); //FIXME Tom no caching as of NOW
}
public void clearFreeElements() {

Back to the top