Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEd Merks2019-05-30 05:55:42 -0400
committerEd Merks2019-05-30 05:55:42 -0400
commita75749442339274ac12d30b98536462303bb73b4 (patch)
treef9657ead5676d62b4309b3f681cae16ce7fab099
parent4eef8c9b66f035b9b520da7fbabccd0ed4530210 (diff)
downloadorg.eclipse.ecf-a75749442339274ac12d30b98536462303bb73b4.tar.gz
org.eclipse.ecf-a75749442339274ac12d30b98536462303bb73b4.tar.xz
org.eclipse.ecf-a75749442339274ac12d30b98536462303bb73b4.zip
Bug 544447 - [provider] Implement filetransfer provider using HttpClient
4.5 API The guard in HttpClientRetrieveFileTransfer.hardClose() is wrong. I imagine the httpResponse should be closed when we are done but not paused rather than if we are not done but paused which sounds like the opposite because we should certainly not close when we are paused! Anyway, someone can confirm what the logic should be, but certainly like this the SetupArchiver works properly again and leases are released properly, i.e., I see mostly just pairs of the operations and the per-route count never exceeds the number of threads that I'm using to load in parallel. Change-Id: I4285b278278c9f3cb7c6d1bae4d8e8b335e90b37 Signed-off-by: Ed Merks <ed.merks@gmail.com>
-rw-r--r--providers/bundles/org.eclipse.ecf.provider.filetransfer.httpclient45/src/org/eclipse/ecf/provider/filetransfer/httpclient45/HttpClientRetrieveFileTransfer.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/providers/bundles/org.eclipse.ecf.provider.filetransfer.httpclient45/src/org/eclipse/ecf/provider/filetransfer/httpclient45/HttpClientRetrieveFileTransfer.java b/providers/bundles/org.eclipse.ecf.provider.filetransfer.httpclient45/src/org/eclipse/ecf/provider/filetransfer/httpclient45/HttpClientRetrieveFileTransfer.java
index 80630635b..f0f148326 100644
--- a/providers/bundles/org.eclipse.ecf.provider.filetransfer.httpclient45/src/org/eclipse/ecf/provider/filetransfer/httpclient45/HttpClientRetrieveFileTransfer.java
+++ b/providers/bundles/org.eclipse.ecf.provider.filetransfer.httpclient45/src/org/eclipse/ecf/provider/filetransfer/httpclient45/HttpClientRetrieveFileTransfer.java
@@ -192,7 +192,7 @@ public class HttpClientRetrieveFileTransfer extends AbstractRetrieveFileTransfer
getMethod = null;
}
- if (httpResponse != null && !isDone() && isPaused()) {
+ if (httpResponse != null && isDone() && !isPaused()) {
try {
httpResponse.close();
} catch (final IOException e) {

Back to the top