Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorslewis2007-04-16 18:34:59 +0000
committerslewis2007-04-16 18:34:59 +0000
commit59600a452b6890ae7799861de965f62fa62d26e9 (patch)
tree6e6c3384380ecf48c00db77d94d33dc49cf41098
parentbce4dcd856475c057914229dc5ec7acae9fb843b (diff)
downloadorg.eclipse.ecf-59600a452b6890ae7799861de965f62fa62d26e9.tar.gz
org.eclipse.ecf-59600a452b6890ae7799861de965f62fa62d26e9.tar.xz
org.eclipse.ecf-59600a452b6890ae7799861de965f62fa62d26e9.zip
Fix for possible NPE in XMPPOutgoingFileTransferHelper.setConnection(null)
-rw-r--r--providers/bundles/org.eclipse.ecf.provider.xmpp/src/org/eclipse/ecf/internal/provider/xmpp/filetransfer/XMPPOutgoingFileTransferHelper.java14
1 files changed, 8 insertions, 6 deletions
diff --git a/providers/bundles/org.eclipse.ecf.provider.xmpp/src/org/eclipse/ecf/internal/provider/xmpp/filetransfer/XMPPOutgoingFileTransferHelper.java b/providers/bundles/org.eclipse.ecf.provider.xmpp/src/org/eclipse/ecf/internal/provider/xmpp/filetransfer/XMPPOutgoingFileTransferHelper.java
index 3741d86b4..864bfcfca 100644
--- a/providers/bundles/org.eclipse.ecf.provider.xmpp/src/org/eclipse/ecf/internal/provider/xmpp/filetransfer/XMPPOutgoingFileTransferHelper.java
+++ b/providers/bundles/org.eclipse.ecf.provider.xmpp/src/org/eclipse/ecf/internal/provider/xmpp/filetransfer/XMPPOutgoingFileTransferHelper.java
@@ -148,13 +148,15 @@ public class XMPPOutgoingFileTransferHelper implements
}
}
} else {
- synchronized (incomingListeners) {
- for (Iterator i = incomingListeners.iterator(); i.hasNext();) {
- XMPPFileTransferRequestListener ftl = (XMPPFileTransferRequestListener) i
- .next();
- this.manager.removeFileTransferListener(ftl);
+ if (this.manager != null) {
+ synchronized (incomingListeners) {
+ for (Iterator i = incomingListeners.iterator(); i.hasNext();) {
+ XMPPFileTransferRequestListener ftl = (XMPPFileTransferRequestListener) i
+ .next();
+ this.manager.removeFileTransferListener(ftl);
+ }
+ this.manager = null;
}
- this.manager = null;
}
}
}

Back to the top